Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 13 Aug 2019 12:21:56 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc:     lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regulator: core: Add of_node_put() before return
Message-ID: <20190813112156.GB5093@sirena.co.uk>
References: <20190808070553.13097-1-nishkadg.linux@gmail.com>
 <20190808122740.GB3795@sirena.co.uk>
 <106177ee-d6e0-5825-83f0-ca199b05ac20@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="TakKZr9L6Hm6aLOc"
Content-Disposition: inline
In-Reply-To: <106177ee-d6e0-5825-83f0-ca199b05ac20@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--TakKZr9L6Hm6aLOc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 13, 2019 at 09:57:47AM +0530, Nishka Dasgupta wrote:
> On 08/08/19 5:57 PM, Mark Brown wrote:

> > Please do not submit new versions of already applied patches, please
> > submit incremental updates to the existing code.  Modifying existing
> > commits creates problems for other users building on top of those
> > commits so it's best practice to only change pubished git commits if
> > absolutely essential.

> I am very sorry about this; I wasn't sure whether this particular commit had
> been applied. Should I split the commit and resend only the change to the
> old commit, or should I leave it as it is?

If there's any changes you think are a good idea please send a new patch
for them.

--TakKZr9L6Hm6aLOc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1SnVMACgkQJNaLcl1U
h9Cimgf9Eex8ZpWx60ww9ZeOCtXNnH6VRaLEs5gLgCE1r+7wdh7sK0qRBDyRUlBY
za6XFJSxW086pma5Td2h2e73KHa3hYZ1QlsYcwCkCU10ZQYJxCQdThuOpmxnGSlX
J3aQDmggq1XGB4XJvkrOQZrdiU9+ioSCNvQuvBVph+ETk0c6xxI0ZEk1aDdM9Qk7
mPpHuCLFY7nk29JKvIAgHRwzkTGgGLCPLUET8qnPZTX7lRMvS3/RFYrCQ3g9nk9Q
D9ojCmTF0DMkEqVznlpIQHRE8kfSe1E+fIxxe6+ed0rZamOBqMU834QBp6CkU2N9
SZ6p40Y7cPOXrDYEt2eK9KZTXAxUhA==
=LpVL
-----END PGP SIGNATURE-----

--TakKZr9L6Hm6aLOc--