Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp980651ybl; Tue, 13 Aug 2019 05:44:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwSPQqjz7q6Ut806Ua53ZDEJVrFd8KEENGby+0rJk5woFRuS8D8psdXlkdrzTywnmbk94Q8 X-Received: by 2002:a17:902:4201:: with SMTP id g1mr37704598pld.300.1565700257020; Tue, 13 Aug 2019 05:44:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565700257; cv=none; d=google.com; s=arc-20160816; b=ckF/q5ZC9S6rVWlooSpOWgs2uTocJwZOo3OP3nThAc/FXoSDCtH0epq25qzrGvj1l6 3LxClilc9NaKBVQkTXZUrLHsyWYrjg5eZb1GAoFwaNkZWXQDl4Bu69Nk6aIR1KY+389o h/akTSsYymjnl2GIw6WuVkDlm1QTUuPcN8k+EnY1swQZwd4KzmikGngtkrvS2orTxL3m nshw2N2FhikvBnFhJS4H7wZmqLE3Ur0rDVZaI7VhSq5HoxhQZap/HwOlTHn2nOaXUBAx FxkKOblH4cZvvT7fq1FKUseETuel0BODMmGKwyhujYBu514UbkTmRuGe1xnpFUGgyXfO NrGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=GFPi2JkPAePg1BI3ULg0QDKkjGjuVBHM9hSRj60tq5E=; b=vCMd1802gXcKLQyIboZGMz68FP92mdJt4+V60sT+/v8tCvdd3SzH/6m8oZMatCfCtB /vZzloETHwSU6TBvcXtfKbDSvM40mhkmXZE9NopoEohZimg8z4nR7mBMbWsK8i9Svi9M /sfpeQLIBFZhbkazbRzOFM4Kmi10BnIEiJ4DbRvobQ9lG8VHD+AF/IMYgCVKFEnPXCrw u05AVypUR+x6n9Uv7FTR3lMoLUrTkWJnGxQHsEouf9sG2gygucL4VWJVblbW55DdMojb P77hvutgF3rCqOurnhAYg4qy0oCLeKxaLhuvacROd9sFQ+PHCxXWzjGftRzkEa5/FfFN ShAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t17si31465974pgu.48.2019.08.13.05.44.00; Tue, 13 Aug 2019 05:44:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728458AbfHMMnQ (ORCPT + 99 others); Tue, 13 Aug 2019 08:43:16 -0400 Received: from inva021.nxp.com ([92.121.34.21]:51604 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728423AbfHMMnO (ORCPT ); Tue, 13 Aug 2019 08:43:14 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 5174320079B; Tue, 13 Aug 2019 14:43:13 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 44B1720078C; Tue, 13 Aug 2019 14:43:13 +0200 (CEST) Received: from fsr-ub1464-137.ea.freescale.net (fsr-ub1464-137.ea.freescale.net [10.171.82.114]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id E6BE62060E; Tue, 13 Aug 2019 14:43:12 +0200 (CEST) From: Ioana Ciornei To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: joe@perches.com, andrew@lunn.ch, ruxandra.radulescu@nxp.com, Ioana Ciornei Subject: [PATCH v3 04/10] staging: fsl-dpaa2/ethsw: remove debug message Date: Tue, 13 Aug 2019 15:43:01 +0300 Message-Id: <1565700187-16048-5-git-send-email-ioana.ciornei@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1565700187-16048-1-git-send-email-ioana.ciornei@nxp.com> References: <1565700187-16048-1-git-send-email-ioana.ciornei@nxp.com> Reply-to: ioana.ciornei@nxp.com X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since ethtool will be loud enough if the .set_link_ksettings() callback fails, remove the debug messages which do not add additional information. Reported-by: Andrew Lunn Signed-off-by: Ioana Ciornei --- Changes in v2: - added Reported-by tag Changes in v3: - none drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c index 95e9f1096999..12e33a3a1bf1 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c @@ -91,8 +91,6 @@ static void ethsw_get_drvinfo(struct net_device *netdev, struct dpsw_link_cfg cfg = {0}; int err = 0; - netdev_dbg(netdev, "Setting link parameters..."); - /* Due to a temporary MC limitation, the DPSW port must be down * in order to be able to change link settings. Taking steps to let * the user know that. @@ -116,11 +114,6 @@ static void ethsw_get_drvinfo(struct net_device *netdev, port_priv->ethsw_data->dpsw_handle, port_priv->idx, &cfg); - if (err) - /* ethtool will be loud enough if we return an error; no point - * in putting our own error message on the console by default - */ - netdev_dbg(netdev, "ERROR %d setting link cfg", err); return err; } -- 1.9.1