Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp980989ybl; Tue, 13 Aug 2019 05:44:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHE6XxzuAQzbEwQT0gCaGEO3qauMfs5GmLht/4bvLWGTcWVSwYInxu/KEOM7ugETfEbQmA X-Received: by 2002:a63:e010:: with SMTP id e16mr33896449pgh.285.1565700275317; Tue, 13 Aug 2019 05:44:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565700275; cv=none; d=google.com; s=arc-20160816; b=mn98/mMwoR1/3MvI8yxutcGN0KnbEuwU7eK9yMcpi2xOM4MBQKEqt+GuouZ8ru3rrN E9SB3mZEOaSpDqBUb9HlvWOVcOS8LNf1nDaoxkQBrcrWDU60rDBKBBIFtHIz0ozaLqok HrgtsuqeNgPRWFKVlEGzJ+j/ZOPEEsnwkm4bt11NaYgpBX5XEDjZQYmVvsyZM+YU8U8L UZYVvl3gPtkv/WaX3HbtELFP6ktmqM+bVGMMs3zgtdl++sNJmOhsfb+PfEOvOOQNB5Yu tO78J5SjA0VcSic8OvOjnYhUTTYnhJmQmFOhHoadRmSUpp/yYiQqkSaf1Wavzfgc5Jv9 AIVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=aT6xm18Lcj1qxX3TBL3b3I2Lm1bAWuLaYsbRm/RhfRs=; b=NfqbwrNwvzkFx5QR8yh4pIeQ/VAkl6r1DPam0rro7N04BzOXK/V46dXqqvWOknFtsH YHZRmfoE+nZH9dDKJCh/klBeECfqU9ck69jSdz7CMjjOY4DlTlAO/ZrfoGeXLRS+kcg5 M01+WD7H0PmX8h9uyOvm1Ej9ioZgv7c3yKjrrMSIAGTKtIuhb4XfS9LUfPTKGsAWdgur T6eex7AKYiAXJaPjLrx4iDX7moJOXCy1fh+/CVI7F3gH289hwugaQBlncIR/8yfG3CIo 184ntMKssfc94T4L4Ap2Ic0VAnIT/89dBIldpEPTbKlXuDztxr7573hA06SeVq8AN09x 49Hg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k192si66006544pge.222.2019.08.13.05.44.19; Tue, 13 Aug 2019 05:44:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728516AbfHMMnW (ORCPT + 99 others); Tue, 13 Aug 2019 08:43:22 -0400 Received: from inva021.nxp.com ([92.121.34.21]:51646 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728442AbfHMMnQ (ORCPT ); Tue, 13 Aug 2019 08:43:16 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id DC04F2007A0; Tue, 13 Aug 2019 14:43:14 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id D01F820079E; Tue, 13 Aug 2019 14:43:14 +0200 (CEST) Received: from fsr-ub1464-137.ea.freescale.net (fsr-ub1464-137.ea.freescale.net [10.171.82.114]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 7D2FB2060E; Tue, 13 Aug 2019 14:43:14 +0200 (CEST) From: Ioana Ciornei To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: joe@perches.com, andrew@lunn.ch, ruxandra.radulescu@nxp.com, Ioana Ciornei Subject: [PATCH v3 08/10] staging: fsl-dpaa2/ethsw: reword error message Date: Tue, 13 Aug 2019 15:43:05 +0300 Message-Id: <1565700187-16048-9-git-send-email-ioana.ciornei@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1565700187-16048-1-git-send-email-ioana.ciornei@nxp.com> References: <1565700187-16048-1-git-send-email-ioana.ciornei@nxp.com> Reply-to: ioana.ciornei@nxp.com X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the current state, the dpaa2-ethsw driver supports only one bridge per DPSW object. Reword the error message so that this information is much more clear. Suggested-by: Andrew Lunn Signed-off-by: Ioana Ciornei --- Changes in v2: - added Suggested-by tag Changes in v3: - none drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index b69b2b7be972..28da109aef5e 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c @@ -1119,8 +1119,7 @@ static int port_bridge_join(struct net_device *netdev, if (ethsw->ports[i]->bridge_dev && (ethsw->ports[i]->bridge_dev != upper_dev)) { netdev_err(netdev, - "Another switch port is connected to %s\n", - ethsw->ports[i]->bridge_dev->name); + "Only one bridge supported per DPSW object!\n"); return -EINVAL; } -- 1.9.1