Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1036346ybl; Tue, 13 Aug 2019 06:29:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqysbBAkHRijMHEsrJ/KL37e/arpjwrtjuRHm1kP02dhFZhABmr8+ziSVNlyekbWKdM3tBUm X-Received: by 2002:a17:902:b089:: with SMTP id p9mr1710753plr.269.1565702954890; Tue, 13 Aug 2019 06:29:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565702954; cv=none; d=google.com; s=arc-20160816; b=e88a/iU6RBzmR627nRADBM5tesIJ41WaxjI+MV4QVnalgcAI6/1V5K/Zbj4KX8ucNQ tTgbavvp4RgR4mo03WniXdMVID59LpgiqyF1C8Ugg6pT7gHfcmSMrKm3bQ02LJPrfeGh EXeXAKrPT75aCkU1L5QJlaY5v5ez9Ip6PnHw+2gDvRgL5zoNpEszVJjCpA0Et1/zLjgg GHeV7l50en9vxulGreREFt6Icm4PjwGdObgTbVJkUd2ZzUMVQ6mNaqvosimVAPid+B81 6Qi1CEatwyuTdSd/HFgyskQ912pvNcCZEQO5pGft73Z64ma5sBUAqNQPhBn/VZZKVhjp p5hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:cc:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=OUnI5qShYtHQYww3X1RCBrfCURbBQ7wCunEPYxXRUns=; b=SJ29aXh7QYzxQqM+VLmQilZrmBLdX6MHnXnsO9lR+KBIzy22XJ+OvSuyr0ZmEIbEOm EDBg0HxlTFg8fdbGNf/P1Q3+r4hrgV/9G8VJLjAPUOZWL7ILH3UJpj/T4Z19c/Wxbi+D KyLdbEqdaPD5UGu/az9uJuoURAag22JkIngUqhBBMsstLCx9RwI7SK47MA459jdTBDNj J1bzOx3U2fqLkAeiIXkSWLi0JEoQ6Rx7WkKjyZtKvrGy+meiI/6EyTC5fQzM9FuRTgIB riAB0AGts2VQ9peepWU9qDeZTj23D5L6btOYDwMbZFepUqtSdIX9l0+GzjesN9hvoGrc fzFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=nWLJmN3X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si64426638pgw.174.2019.08.13.06.28.59; Tue, 13 Aug 2019 06:29:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=nWLJmN3X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729091AbfHMN2I (ORCPT + 99 others); Tue, 13 Aug 2019 09:28:08 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42192 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbfHMN2H (ORCPT ); Tue, 13 Aug 2019 09:28:07 -0400 Received: by mail-pf1-f196.google.com with SMTP id i30so2906938pfk.9 for ; Tue, 13 Aug 2019 06:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc; bh=OUnI5qShYtHQYww3X1RCBrfCURbBQ7wCunEPYxXRUns=; b=nWLJmN3XZAPFpmXl7Lv98vYL2f5xide0ABgIuYQFZZy15vy2ONsAm/1UZ1JzukTcw8 BDL9RltV2YBhTQzX/UahXxHNWCr/8Keym9JDfL3ahYwsNuC4giB2KQKu7++6dUgM8TFE P6qh+xMHedLkv8UeXIvk2EEtNRkgXTxPRyLvS0BFcTiKCe5pEJJKl2C9mC/eGEO3YITH DhjzZKGkp2ZpBHONUrIyNRZT3nllrg8L7eJ5iJLoOJ0IzAtMZO7BcMylAdEVx6QlokCn a0MZnqnB0LTfx2UOYhlbfsLSiPNmhvVBO8Kverf0iE+bOYedAXdiln/RagrrcmBCM8QZ QwwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=OUnI5qShYtHQYww3X1RCBrfCURbBQ7wCunEPYxXRUns=; b=Byy2TR6FxBFB/VA1njlMNPZuWQG6A9W5+CZnHHs5o8WUbhknEGZBx8Vjp2AuMT7heO WpUKMNRrOAtfpKrycdnN/F83aXhDqmRs5oge6H0CsVqxcEiIz9NlaeaG7slBw3sAm4kg bUNaWa+WonjNuOg+jYikjc3EqUvhAq146r9z/JlGO1x7CYBMNyP7vpuD/Wfrz5xvje+x U7xrb+BpXoPxEHNpUpDFPVTFYL5lD5d7ZRk/+0Mw8uT7f36bJ7YJPdHDPSAU97j0JA68 Vtl20nA+beSMroXu7c78aWdXrqEFwxEjazisowDVwrrBQNeZxQZdlAR2PvUCprZAmjuw OI+w== X-Gm-Message-State: APjAAAUCvHqueuCPfPqegfJfRPWDAO8N8slRsNWuUMiW5nojJtp1QNWZ N61CCIEnIhfnpB3+FVF9kSCUzXD+ht405lm4aE9z2w== X-Received: by 2002:a17:90a:a116:: with SMTP id s22mt2038033pjp.47.1565702886660; Tue, 13 Aug 2019 06:28:06 -0700 (PDT) MIME-Version: 1.0 References: <000000000000f00cf1058bb7fb56@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 13 Aug 2019 15:27:55 +0200 Message-ID: Subject: Re: KASAN: slab-out-of-bounds Read in p54u_load_firmware_cb Cc: syzbot , Christian Lamparter , "David S. Miller" , Kalle Valo , Kernel development list , USB list , linux-wireless@vger.kernel.org, netdev , syzkaller-bugs , Alan Stern Content-Type: text/plain; charset="UTF-8" To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 20, 2019 at 9:46 PM Alan Stern wrote: > > On Wed, 19 Jun 2019, syzbot wrote: > > > syzbot has found a reproducer for the following crash on: > > > > HEAD commit: 9939f56e usb-fuzzer: main usb gadget fuzzer driver > > git tree: https://github.com/google/kasan.git usb-fuzzer > > console output: https://syzkaller.appspot.com/x/log.txt?x=135e29faa00000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=df134eda130bb43a > > dashboard link: https://syzkaller.appspot.com/bug?extid=6d237e74cdc13f036473 > > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=175d946ea00000 > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+6d237e74cdc13f036473@syzkaller.appspotmail.com > > > > usb 3-1: Direct firmware load for isl3887usb failed with error -2 > > usb 3-1: Firmware not found. > > ================================================================== > > BUG: KASAN: slab-out-of-bounds in p54u_load_firmware_cb.cold+0x97/0x13d > > drivers/net/wireless/intersil/p54/p54usb.c:936 > > Read of size 8 at addr ffff8881c9cf7588 by task kworker/1:5/2759 > > > > CPU: 1 PID: 2759 Comm: kworker/1:5 Not tainted 5.2.0-rc5+ #11 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > > Google 01/01/2011 > > Workqueue: events request_firmware_work_func > > Call Trace: > > __dump_stack lib/dump_stack.c:77 [inline] > > dump_stack+0xca/0x13e lib/dump_stack.c:113 > > print_address_description+0x67/0x231 mm/kasan/report.c:188 > > __kasan_report.cold+0x1a/0x32 mm/kasan/report.c:317 > > kasan_report+0xe/0x20 mm/kasan/common.c:614 > > p54u_load_firmware_cb.cold+0x97/0x13d > > drivers/net/wireless/intersil/p54/p54usb.c:936 > > request_firmware_work_func+0x126/0x242 > > drivers/base/firmware_loader/main.c:785 > > process_one_work+0x905/0x1570 kernel/workqueue.c:2269 > > worker_thread+0x96/0xe20 kernel/workqueue.c:2415 > > kthread+0x30b/0x410 kernel/kthread.c:255 > > ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 > > > > Allocated by task 1612: > > save_stack+0x1b/0x80 mm/kasan/common.c:71 > > set_track mm/kasan/common.c:79 [inline] > > __kasan_kmalloc mm/kasan/common.c:489 [inline] > > __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:462 > > kmalloc include/linux/slab.h:547 [inline] > > syslog_print kernel/printk/printk.c:1346 [inline] > > do_syslog kernel/printk/printk.c:1519 [inline] > > do_syslog+0x4f4/0x12e0 kernel/printk/printk.c:1493 > > kmsg_read+0x8a/0xb0 fs/proc/kmsg.c:40 > > proc_reg_read+0x1c1/0x280 fs/proc/inode.c:221 > > __vfs_read+0x76/0x100 fs/read_write.c:425 > > vfs_read+0x18e/0x3d0 fs/read_write.c:461 > > ksys_read+0x127/0x250 fs/read_write.c:587 > > do_syscall_64+0xb7/0x560 arch/x86/entry/common.c:301 > > entry_SYSCALL_64_after_hwframe+0x49/0xbe > > > > Freed by task 1612: > > save_stack+0x1b/0x80 mm/kasan/common.c:71 > > set_track mm/kasan/common.c:79 [inline] > > __kasan_slab_free+0x130/0x180 mm/kasan/common.c:451 > > slab_free_hook mm/slub.c:1421 [inline] > > slab_free_freelist_hook mm/slub.c:1448 [inline] > > slab_free mm/slub.c:2994 [inline] > > kfree+0xd7/0x280 mm/slub.c:3949 > > syslog_print kernel/printk/printk.c:1405 [inline] > > do_syslog kernel/printk/printk.c:1519 [inline] > > do_syslog+0xff3/0x12e0 kernel/printk/printk.c:1493 > > kmsg_read+0x8a/0xb0 fs/proc/kmsg.c:40 > > proc_reg_read+0x1c1/0x280 fs/proc/inode.c:221 > > __vfs_read+0x76/0x100 fs/read_write.c:425 > > vfs_read+0x18e/0x3d0 fs/read_write.c:461 > > ksys_read+0x127/0x250 fs/read_write.c:587 > > do_syscall_64+0xb7/0x560 arch/x86/entry/common.c:301 > > entry_SYSCALL_64_after_hwframe+0x49/0xbe > > > > The buggy address belongs to the object at ffff8881c9cf7180 > > which belongs to the cache kmalloc-1k of size 1024 > > The buggy address is located 8 bytes to the right of > > 1024-byte region [ffff8881c9cf7180, ffff8881c9cf7580) > > The buggy address belongs to the page: > > page:ffffea0007273d00 refcount:1 mapcount:0 mapping:ffff8881dac02a00 > > index:0x0 compound_mapcount: 0 > > flags: 0x200000000010200(slab|head) > > raw: 0200000000010200 dead000000000100 dead000000000200 ffff8881dac02a00 > > raw: 0000000000000000 00000000000e000e 00000001ffffffff 0000000000000000 > > page dumped because: kasan: bad access detected > > > > Memory state around the buggy address: > > ffff8881c9cf7480: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > ffff8881c9cf7500: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > > ffff8881c9cf7580: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc > > ^ > > ffff8881c9cf7600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > ffff8881c9cf7680: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > ================================================================== > > Isn't this the same as syzkaller bug 200d4bb11b23d929335f ? Doesn't > the same patch fix it? #syz dup: KASAN: use-after-free Read in p54u_load_firmware_cb