Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1199069ybl; Tue, 13 Aug 2019 08:51:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqycHqBiDkaarLgfIiRPXlCSHybp+A0KFcNfmDU0Ri/8iZdF19HFG7kILGARmlj858M1Lm0C X-Received: by 2002:a62:1688:: with SMTP id 130mr13829804pfw.187.1565711501727; Tue, 13 Aug 2019 08:51:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565711501; cv=none; d=google.com; s=arc-20160816; b=eV73CT4nFmEp0oY8ZMe99jLaUH5wOyWcycisJrAy3bdHxfxlFkEK5+AnkIBUYC2io9 n/dn2uq6u1BUj422HbyOeAG+gZkong+oqh53LH1iJ/1jTzwES3fYyqOiKFL0VCa/WhCP vbeF3K6mdch4rgPqohub0DMAFhSnfubX/1co5CwkBFDnh4ON4QFHEwVpwJNJ3q2/ZIQP LZ9jd/GUUPnwWe3fcuZwYRPR+UvRl54IZ3fVwS3txWgWbrG41XKyc8WLpAFEzlh+pWhL uWRNxiQJzftxuJNbiw8O9OISpRKxXgeiHF+QCiCyEB98aVq/cg58hkkoANgXA3S36CWk CdSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AO+4c0ecIi/uQLR0CK7Q9a7X2o8vLwm3CNoO+BGwqJg=; b=1DaluEr6jdTPJIM/vcSqF2r/wlxQYXlCWS4jww77xMu6eDJGzSbUbX5h7qRYhZct0X BSsCEVXKEzZxYL/7vyDob9LZBYypt8TCru/XIyms/PHGfoKepdAzvpMukSBFEUFlDPPt VHsX87KVHcwDm3WqFK1y2Y3aB+1cXPZI8xvRkzrW29iXuIoXn+8EeuwKCwa8aTehfP9O TaWTmaPgReauQT/cPTukNQs9kQodPqml7SfwaT0ZcfUEq4IKFEhgCZu0t+jtINuNSnNe ui6LxzMwCr08KZ4qal9VRwe9siYwcHCV9rSFyEfjP4bFY1F34cRu/FM0zyz6wQbg/Wl4 5eBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=BUC5njc7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si65296986pgw.81.2019.08.13.08.51.25; Tue, 13 Aug 2019 08:51:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=BUC5njc7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730179AbfHMPsI (ORCPT + 99 others); Tue, 13 Aug 2019 11:48:08 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44158 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730167AbfHMPsF (ORCPT ); Tue, 13 Aug 2019 11:48:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AO+4c0ecIi/uQLR0CK7Q9a7X2o8vLwm3CNoO+BGwqJg=; b=BUC5njc7cJ4ycTCKrUoVAIUDiU M2O8l3cujM2hjuWnyxV+LQOek5j8D8LzJwXNN6uaqD6btVceWLFkeS12A6OJforpmOhPaIjjV3bi4 7MFwBPjgB7g96YWKhPAwo8y1JBPLwTxjZCoaqBZQ1e5tbVi+1NlZRpvWLxMLhQsBVqxLSjBmj3EU6 6+6bSolI52RKDAFISaHEaisWd1vtcgabet1ZO0fLAVikUILOSmzT60um0jG211EZblvS0gR83BZe9 eZQoy4recnudfgoeOSEYxxN1rxENMhNqDTw7AV3/WcVWyQhLwNXvbQk+D/BiVrWdTa/LEaS4FLzvy IjW+Aq4g==; Received: from [2001:4bb8:180:1ec3:c70:4a89:bc61:2] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hxZ1m-0004tx-V9; Tue, 13 Aug 2019 15:48:03 +0000 From: Christoph Hellwig To: Palmer Dabbelt , Paul Walmsley Cc: Damien Le Moal , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Atish Patra Subject: [PATCH 05/15] riscv: improve the default power off implementation Date: Tue, 13 Aug 2019 17:47:37 +0200 Message-Id: <20190813154747.24256-6-hch@lst.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190813154747.24256-1-hch@lst.de> References: <20190813154747.24256-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Only call the SBI code if we are not running in M mode, and if we didn't do the SBI call, or it didn't succeed call wfi in a loop to at least save some power. Signed-off-by: Christoph Hellwig Reviewed-by: Atish Patra --- arch/riscv/kernel/reset.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c index d0fe623bfb8f..2f5ca379747e 100644 --- a/arch/riscv/kernel/reset.c +++ b/arch/riscv/kernel/reset.c @@ -8,8 +8,11 @@ static void default_power_off(void) { +#ifndef CONFIG_M_MODE sbi_shutdown(); - while (1); +#endif + while (1) + wait_for_interrupt(); } void (*pm_power_off)(void) = default_power_off; -- 2.20.1