Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1210935ybl; Tue, 13 Aug 2019 09:02:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqyiIf2HYgt1nwH+cfmCEgyvaYqARfuB7ih8IuSwZpX+TwBt668xh221hs5dUbURZ8Lu94X0 X-Received: by 2002:a63:8ac3:: with SMTP id y186mr35031126pgd.13.1565712159014; Tue, 13 Aug 2019 09:02:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565712159; cv=none; d=google.com; s=arc-20160816; b=zoj2hk9gozN3cPZMjZgo+5T9Jrqng5Fejz8MXInUfzG42MrxzS8OXhSBURy3BRO3uw KdNuRZ7lfbKTK17rP1sWfsEE6glj4Cj6Eb4jXzW/m2qCr5FhUYXRruvYgk+A3x/0Rvgq OQfRpU4lVZBw6GtwPQUlMwxdEcFhEJt/aghsq0hFcyd6HKIO9gTsMuFeXAN4/x4ZuNmW 2jp81/1NlRMBxoN2wfY8lkHdAG13PnHKqiiGF4YIM/Plw014OpVNB5HEwrnukgQqOfw/ 6TqAITAf2bLRIzSAEh4h0eRhxAz4aqzjz6IwH3jOD+ZVEvRJ+MNGPXH49W8LWh+J7NER 7xTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=u2xvKIFDx1GL5oTSP01MeCVOPBZI+ggPw3/ysWgy6nQ=; b=ZqclaEDHsNKU24VVGFmkVL0lNSW0wl1oNyNXyOBrrOpXlRMHI4XAeu1j0JC9tDUNYC 52IqAMuN9vNhcckAdws/0QvHbJzuPpJweMRCydc9RfI+R8d0GFn3CThcZfhqWcKYWSQ+ QXZLqYZ2rcXW5DdCPnLFuRrSS0zLPT+Q1TS8xbg4HEUPRhdlKfx734gIBmV97tvIOCvn Kfidt1u7hYGtw3gn0ZrqmDvVvSnznsKfUWcdxTWxSjqj8BT7EgQGBupN33Dm555tFed+ 8R3T72d/x091BGt89+5imZa3NLgx0OJkaSqAjW3Tqv4gHMHcvlUPAYWTE5fURGd5oexZ g4zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AMQCAmjV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 91si17047657ply.113.2019.08.13.09.02.22; Tue, 13 Aug 2019 09:02:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AMQCAmjV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728925AbfHMNHF (ORCPT + 99 others); Tue, 13 Aug 2019 09:07:05 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:41925 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728359AbfHMNHF (ORCPT ); Tue, 13 Aug 2019 09:07:05 -0400 Received: by mail-qk1-f196.google.com with SMTP id g17so8865156qkk.8; Tue, 13 Aug 2019 06:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=u2xvKIFDx1GL5oTSP01MeCVOPBZI+ggPw3/ysWgy6nQ=; b=AMQCAmjVMkny/5BGWEJOty2vX6MCoQOq1G95l9/RhyYwDeuU1PMYleA2bWX5YliVyH rOauuQZa/wbMZf2yl6pD0hCEWri5sJtc3UjkvirA0NdQZoRA6c8M94xWGChvU/JmHNqt AMVDQAKeV8OOie/K4ms5uDBSsivZB7M+hlK/9skh8vbJJCO6V0a2vgY7cn8oEYUNeubg 1Lg52jf2CO154nU8/4GHcAoz8DThCz1yU76rM2x+akAQjE8TesDkXLiCRVGfZ4bXEgyW kpOXbQ9xTc0dlYdPf2yGSqH43dJ5sNs6pDt3QOF8N/DPjsWSmy+59G0ej6J3mPFa6WAd P8vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=u2xvKIFDx1GL5oTSP01MeCVOPBZI+ggPw3/ysWgy6nQ=; b=J/0rPUQRWvFXnfzCc+YSoxt016YnAEtZAoHutTgMaYzGVJShF9kVWgLa5Ks8cLXjjD C+or4lPP/LMp7Jg33jn/IDMhOiid02aXWsdPa7vmhZA3BUwX6Nalby3w8Rm/yGIpb1eL A9H/vWM2huvRY22SRUN7bkqptYnMNCHzTaWqg71/F6C9LW4ZXpqGTrf8e2/09n679TT9 cqDebtDO4wT/ACVO9+TJrL/AOvGNv8FjBwZAZdbuyx6Zc+aXFWKjPj4TThHicHLu2HRw pHRFKtEHUOhuykudsGi8HRtt8+FSktFWVD5tBxeZDld9ndLYCmS9NidosRWVl04hyEUG tOFw== X-Gm-Message-State: APjAAAXVySD/hJNQnH4AfRteSKqOyCa3RmBOfHYR+pbF2Xqxe/ocasx/ LCBJaqngp2VeU9nt6cMvaOc= X-Received: by 2002:a05:620a:12d2:: with SMTP id e18mr33667320qkl.176.1565701623607; Tue, 13 Aug 2019 06:07:03 -0700 (PDT) Received: from localhost (tripoint.kitware.com. [66.194.253.20]) by smtp.gmail.com with ESMTPSA id f7sm2448257qtj.16.2019.08.13.06.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2019 06:07:03 -0700 (PDT) Date: Tue, 13 Aug 2019 09:07:02 -0400 From: Ben Boeckel To: Alison Schofield Cc: "Kirill A. Shutemov" , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , David Howells , Kees Cook , Dave Hansen , Kai Huang , Jacob Pan , linux-mm@kvack.org, kvm@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" Subject: Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API Message-ID: <20190813130702.GC9079@rotor.kitware.com> Reply-To: mathstuf@gmail.com References: <20190731150813.26289-1-kirill.shutemov@linux.intel.com> <20190731150813.26289-58-kirill.shutemov@linux.intel.com> <20190805115837.GB31656@rotor> <20190805204453.GB7592@alison-desk.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190805204453.GB7592@alison-desk.jf.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 05, 2019 at 13:44:53 -0700, Alison Schofield wrote: > Yes. Fixed up as follows: > > Add a "no-encrypt' type key:: > > char \*options_NOENCRYPT = "type=no-encrypt"; > > key = add_key("mktme", "name", options_NOENCRYPT, > strlen(options_NOENCRYPT), KEY_SPEC_THREAD_KEYRING); Thanks. Looks good to me. Reviewed-by: Ben Boeckel --Ben