Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1214626ybl; Tue, 13 Aug 2019 09:05:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqy5fcs0WNvJdAz5f8SvqV6a+MTPoWiMvvsfjh/Rp5BMWrQJrHIrXPqT3vqql2HuvRB+tyaN X-Received: by 2002:a17:902:b08a:: with SMTP id p10mr38928118plr.83.1565712314141; Tue, 13 Aug 2019 09:05:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565712314; cv=none; d=google.com; s=arc-20160816; b=JFhp9oiUO1U90Md9lHrhVczOHmDzAgWsy5q4GmaSIoEZT1zvk05o1BSCdIkZdbh/kM Lf7Slc5QlijSApAR1UZNVN1N/2MYsnY3DBfm8ikth4F2CyIOWHucNyzR1nsG1x7U2Vy2 yB7SCHObzy27+T/qm40vvtnYJ2xZ9PFJ2egCYk4/KGHVljbwi/zKeCM3fhilT1sisnmH C2ZT/cQqoBxzah2mD+zczpl4/6sZOdtBcoyUxGUGg+38RAG1uuYkXgqvmn4iVE5HCJE6 tsQIDMTxLkIMRkA7KF8VBhAAUnHf1X2NZIkVUHnaVxDUZNZius0nWh531LjMsKzRA5sk R7Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jE493WARNpki0AIpBNviYm5ayChOhb0dqTWQhuNrBt8=; b=cuf2/P7uvuMCUDbN5sa6SH1WGFweQyZ9aVHWQue14FWS4pVBq8rHd36fOm/v8FBZcw MnCzb4vagyLUcvuqK6g9NU6ELgoNDAheFanp9fa0Z3hRgpmGuBVTfT2FhRWI4tPoxCfg 4iN6nOVpSEyF6wPqLSfzJQwEOkw+fk+hidb6wFgfJbCoE00DVrjjjXHXFE0iS837/7Wq TiXv1I9D62H+l5i5n+JwHo0poNlHJqvPDHaSzmatUb1OhdGMIGFGBP42IsLjMnN+rIxi xAEo694V5/ZPVpcPvTv1j8RYwDSfRCKyew5VFF1WTm1f+ljLtCXGAHRy7XgBKgvl+egm h3ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y92si59006198plb.209.2019.08.13.09.04.57; Tue, 13 Aug 2019 09:05:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729488AbfHMOFg (ORCPT + 99 others); Tue, 13 Aug 2019 10:05:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42088 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729387AbfHMOFg (ORCPT ); Tue, 13 Aug 2019 10:05:36 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F28EF30A5A64; Tue, 13 Aug 2019 14:05:35 +0000 (UTC) Received: from dhcp201-121.englab.pnq.redhat.com (unknown [10.65.16.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F5537FB8C; Tue, 13 Aug 2019 14:05:30 +0000 (UTC) From: Pankaj Gupta To: mst@redhat.com, amit@kernel.org Cc: virtualization@lists.linux-foundation.org, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jasowang@redhat.com, pagupta@redhat.com Subject: [PATCH v4 0/2] virtio_console: fix replug of virtio console port Date: Tue, 13 Aug 2019 19:35:27 +0530 Message-Id: <20190813140529.12939-1-pagupta@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 13 Aug 2019 14:05:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series fixes the issue with unplug/replug of a port in virtio console driver which fails with an error "Error allocating inbufs\n". Patch 1 updates the next avail index for packed ring code. Patch 2 makes use of 'virtqueue_detach_unused_buf' function to detach the unused buffers during port hotunplug time. Tested the packed ring code with the qemu virtio 1.1 device code posted here [1]. Also, sent a patch to document the behavior in virtio spec as suggested by Michael. Changes from v3 - Swap patch 1 with patch 2 - [Michael] - Added acked-by tag by Jason in patch 1 - Add reference to spec change Changes from v2 - Better change log in patch2 - [Greg] Changes from v1[2] - Make virtio packed ring code compatible with split ring - [Michael] [1] https://marc.info/?l=qemu-devel&m=156471883703948&w=2 [2] https://lkml.org/lkml/2019/3/4/517 [3] https://lists.oasis-open.org/archives/virtio-dev/201908/msg00055.html Pankaj Gupta (2): virtio: decrement avail idx with buffer detach for packed ring virtio_console: free unused buffers with port delete char/virtio_console.c | 14 +++++++++++--- virtio/virtio_ring.c | 6 ++++++ 2 files changed, 17 insertions(+), 3 deletions(-) -- 2.21.0