Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1426142ybl; Tue, 13 Aug 2019 12:21:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqwbXS659Az3/SKXQOdO4qN7R8nI2l2diLEcPQO+AdiYojg9HhHwEJ1tocJVJL3AGO6vweeT X-Received: by 2002:a62:7789:: with SMTP id s131mr9681113pfc.50.1565724071458; Tue, 13 Aug 2019 12:21:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565724071; cv=none; d=google.com; s=arc-20160816; b=Tsrl9i0t5/0aGrBTusmQuJJdLV1tyKt4oNGyqMLI0FbDndkAjx88Mvz7ZrvTeLPWX6 bazRsI94IPFwUWgsS4KEy2IOdTr5hEvN1VUJTVmDHThI/z8DsLZeaxxHJsxcprpUH+/o k9JBtltL9F8rsA5ml/o3tadn4HO43mdA5ostfLXDr963myaPtrfP9rWdR33AuyBe8BHj qDAOlo2ZIjaVncy9Yu/cy6z4HmBAlZ4qqb3ofJgMvRv3hWL2ALdJNXVVGFUGt2JTcaiO mV0n6/9/aRz+3WsZVIMdx+5X+T6d/Wd9zcWkkxkoTBtFhxyKzHYhYkF4jOMN7+QUve9v K4lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=3gNGjIIX5OSATJPrjiaqC4tEdgA2GhEQ3ri4YNXQssg=; b=E5/FTBi7VtDEW5K5vQniacwV7zxh8WxVtIA0/zLx94BCab6v+VuZ9Ez7zyXNbX+sUy 8c9UCqU9+PE+ImDxzfsuRcgv8bT5rmTQr6t+ESv6KH140+zQVgskQlrzav26LrMhwZjU 3B1YKvEBd1O6bCb3GxV7QwAk0uY+vyjh9EQD+QkpP6O2Kt896cg6m9lxIOvvsZi2Lc+E UXkJrJ9aeB7FQPBadsb7as7YQDQZV5mC3Wybz4K3OXGHwbJg9vZf9LjyxJkqNmHClUfS FRJAh6bXG1yCD0em9quD56p0wndCa1EGZ+mHaRddWwXUZHKhTDYP5hqfYF9GSUiUx988 uy2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x18si62469179plm.292.2019.08.13.12.20.54; Tue, 13 Aug 2019 12:21:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbfHMTSb (ORCPT + 99 others); Tue, 13 Aug 2019 15:18:31 -0400 Received: from mail-ed1-f97.google.com ([209.85.208.97]:39191 "EHLO mail-ed1-f97.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbfHMTSa (ORCPT ); Tue, 13 Aug 2019 15:18:30 -0400 Received: by mail-ed1-f97.google.com with SMTP id e16so14610989edv.6 for ; Tue, 13 Aug 2019 12:18:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3gNGjIIX5OSATJPrjiaqC4tEdgA2GhEQ3ri4YNXQssg=; b=a14pmDg1Eno5af+a+uQRzFaCRJhfBN+e/9a7KrVoY0fu3vaNYHfiPqcuoxagtGBM5D gzf3jU6K2dhy+CKVtstycSNXgEZkXmj/oFeR7tRzzv/7u+RS3BeCEnvjrAyw6oJcKw8E tzIa/gHSAmTQ7br04o0mVuMvR58O3Zqpu8EmDPbPyQo6Sgz1ifIoE1J5LSZcDkkqJl1K uxt9sE3aSjuJ9gf0yOF3JN80c8/CYoT+otSdhidRssS/ZzUBRB+GcGcfSqz2LL4UNBw5 /EVNHlOqAnFJ6xM+/cgZrD4WTh/HG6g8lAIzgomIR3nqinygRvZdzYXZ0jEFjdO5sC/Z DGaA== X-Gm-Message-State: APjAAAVhtFuBeZ5z7C8xQwb7gmIx1u84joDJ5HFJXfISzOVX1KjTuzZd bg8Q/jYWR/zSeFQxZ1sg/otBudllNCZYgipSM8D26W2jrImR+yqgKLxs69/JACG9Jg== X-Received: by 2002:a17:906:3c7:: with SMTP id c7mr27689622eja.187.1565723908955; Tue, 13 Aug 2019 12:18:28 -0700 (PDT) Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk. [2a01:7e01::f03c:91ff:fed4:a3b6]) by smtp-relay.gmail.com with ESMTPS id l50sm29867edc.15.2019.08.13.12.18.28 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 13 Aug 2019 12:18:28 -0700 (PDT) X-Relaying-Domain: sirena.org.uk Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hxcJQ-0000z1-E5; Tue, 13 Aug 2019 19:18:28 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 896132742B44; Tue, 13 Aug 2019 20:18:27 +0100 (BST) Date: Tue, 13 Aug 2019 20:18:27 +0100 From: Mark Brown To: Pierre-Louis Bossart Cc: Srinivas Kandagatla , vkoul@kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, plai@codeaurora.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, spapothi@codeaurora.org Subject: Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream() Message-ID: <20190813191827.GI5093@sirena.co.uk> References: <20190813083550.5877-1-srinivas.kandagatla@linaro.org> <20190813083550.5877-4-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9Iq5ULCa7nGtWwZS" Content-Disposition: inline In-Reply-To: X-Cookie: Poverty begins at home. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9Iq5ULCa7nGtWwZS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 13, 2019 at 02:15:18PM -0500, Pierre-Louis Bossart wrote: > On 8/13/19 1:06 PM, Srinivas Kandagatla wrote: > > sorry for the confusion. It was too quick reply. :-) > > I was suppose to say sdw_stream_add_slave() instead of set_sdw_stream(). > ok, so get_sdw_stream() and set_sdw_stream() are not meant to be mirrors or > both implemented. It's just a helper to respectively get a context or set a > context but a get-modify-set type of operation is not expected. > Do I get this right? This seems like it's going to be confusing... --9Iq5ULCa7nGtWwZS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1TDQIACgkQJNaLcl1U h9CEJgf/WNOBdWoFpepTAzRC/SOiL/VJjBnXIPHLxH3lof4Yx/1pbBvUPjYOwCHy bBVUntfQnRhu7zgAjp1M5uC97VkFZbrj9s+32Tvcb43ye0dto5d63K3c3edekkjQ ngfPnOA+yWL1BcfMLOAGY3OmTBIuUknyiMWfiLUVIDozt5dTHB0f9W02Qclp7J5I BtoyMIUdvCVbUMc0KnQkZ19K/IZqBvqNQ6ca9T8gn3K50X30ab0jBgsbm1IXckpH zmV/b4T553l8j47i/CyXS6K4trYVQ06tUcqyIRWzJZrPHQ/Ji/N62kTq2SOQV56w nL8ZqN1yL7MUwJM3Qu7yx1MpwPJYYA== =Xi1X -----END PGP SIGNATURE----- --9Iq5ULCa7nGtWwZS--