Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1455296ybl; Tue, 13 Aug 2019 12:57:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqwhrQYYC2swEoePDu1JG8nEqytctvovH2GExzJcL49TO+oiV3wazeS819EyX/cCcAUF2yCh X-Received: by 2002:a17:902:1107:: with SMTP id d7mr5397856pla.184.1565726279697; Tue, 13 Aug 2019 12:57:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565726279; cv=none; d=google.com; s=arc-20160816; b=IiQGI+6a+bKuBI0xmolivGzadGgIoHoOe6B0h+01gPuf0ha4nNY+e5czDLySw2acKU HIll9IjR/+cCEaQFAM73CjnUuS96CBaxIYy71lxkHcKBprQ5KvnNVlE7PYJUq5WfkEQF zuHNGlJhdYW0Hd1q8Y2L+ZMBAFJUjFU7QSSLXZcw/bTwQRll5Qmg9DW/Tp6+L54wViVZ w2qBtxOxPn2L1cLomZLr5GOQgtStoMhUnSNE/ZCyKU4+mDdHH9/OSzzu2V6AInw6Et9y 7s975pANRU/W/8YxWGcm7z47p9AC3LsJOePhYUVct+fCbmy76kgF5rdJi5+iF2iEdhqJ 3+hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:to:subject :dkim-signature; bh=8mmwMdSIxHKL+N2l79bW3KL8G8IFMC9DegPuvh32BO8=; b=gtwrMmlMeVlRKHkm73m8UC67zG0430sBeprzEt3buP48om3F16p9XlbRzY5vyUj+cv SSsqwvhShaTw9+iA7kk6d1uMxGIDMvtfdCAsDbpUeVL3AZ0J3Ib4oFWyuWYRek9mCevu gmxFRbOYF4btgpJseaYlHyDqUdOT2Br5+85HckA0iBEXqth/rY5wiPK8KVyQZj1CmQ0c UB7CiZabDsXdbC6r438quhzZD/vKG/MdipSaKHFMV9yflzUeKjQurO/tOJSI/S3hWSAM kGSaUvOGmZy8zj2ro2lZl0QI22255DRnO4yI6h7ZuncqNgxw3XpsoL+waHeDUi4kfDOC NYuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FlxHe2XB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6si62454039pla.88.2019.08.13.12.57.40; Tue, 13 Aug 2019 12:57:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FlxHe2XB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726710AbfHMTyp (ORCPT + 99 others); Tue, 13 Aug 2019 15:54:45 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:34277 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbfHMTyj (ORCPT ); Tue, 13 Aug 2019 15:54:39 -0400 Received: by mail-pg1-f193.google.com with SMTP id n9so45581610pgc.1; Tue, 13 Aug 2019 12:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8mmwMdSIxHKL+N2l79bW3KL8G8IFMC9DegPuvh32BO8=; b=FlxHe2XB4W5HEqUkxjZrLqqO9jEwDa+n68XWuL3o+xg5N99FHly3S5x6OjUe7xctqC HwjR9XpW2v1bzENxGDZxlcVb9i3oKiNq89bCg7uNl8uVhmST+k0J7aOU6EG3tRdUQa9y T62yZ28lh1vLQKbn9CXjdT8MQGaqgV+NQgjFokbhUJZuu/VhzSzB5uaZGErRcGsCBsvL ku0Om5MsBd4+32lRPoZbhMVsJPBhFMiVe+d7dkCJEVLrDCKncmZWf20j1L97iLKXxK6f BjTgRKZA8Q+RQOpJSJwzcKihGTFs3rRB4PxwGz17WYiS7FGjYsjoILtGdYVQ0nv29wZB UPjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8mmwMdSIxHKL+N2l79bW3KL8G8IFMC9DegPuvh32BO8=; b=K/wQd66xj3Yw+7EKqeQiiBieeMq7a8nBmGEMXQIBJoMC8qkt4jQpK+3wajHRKYFG3w Oi76BiYMOo+vKECnsqcm+6SzaSUdcNIp/W7npPNjE4ZCaD9Sw+MLBcb5/TjB+4hTP8JK i6JCq1y/ij49moD6Vlgg5SWq+3X/+6wQZX2M1pSiEWScZ13dQUFjCvm30xUgPqwHQ6DG 0jhYMhmKlyhy6KwhIZXGzHufU18DpsVbiMF/h1aCVUzw2pAZCH93eLpgxMXziRPZ+cf3 H2ljMv5DzVc8qWykzmqfd3ptFV3roBOrfF+5/hI+k23ruVK2cQbPJ+0VONPyYO5gKxcO s4Fg== X-Gm-Message-State: APjAAAWBF28tXGAR1q6yNtUNhEgICn/iUONT1qFdonyhhlUpAGEJXUq0 pR71dkwZV0dtVccChSueY9o= X-Received: by 2002:a17:90a:b395:: with SMTP id e21mr3776070pjr.76.1565726078730; Tue, 13 Aug 2019 12:54:38 -0700 (PDT) Received: from [10.67.49.31] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id e13sm13267103pfl.130.2019.08.13.12.54.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 12:54:38 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: modify assignment to OR for dev_flags in phy_attach_direct To: Tao Ren , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Vladimir Oltean , Arun Parameswaran , Justin Chen , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org References: <20190805185551.3140564-1-taoren@fb.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Tue, 13 Aug 2019 12:54:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190805185551.3140564-1-taoren@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/5/19 11:55 AM, Tao Ren wrote: > Modify the assignment to OR when dealing with phydev->dev_flags in > phy_attach_direct function, and this is to make sure dev_flags set in > driver's probe callback won't be lost. As Andrew pointed out already, this probably needs to be reworked, but for now this looks reasonable: Reviewed-by: Florian Fainelli -- Florian