Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp6378ybl; Tue, 13 Aug 2019 14:46:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqwC+dti2X+xjW9mhYlG3yLw6gP6m9m5PKt4F6RqHvjGE4rToQjfpNNFSe0rVwz/hia3egFg X-Received: by 2002:a63:290:: with SMTP id 138mr33243613pgc.402.1565732785885; Tue, 13 Aug 2019 14:46:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565732785; cv=none; d=google.com; s=arc-20160816; b=gavRPN6cyi1ZHKVIvAUjCguPXVnKEh30j3XH9RgArTRiW7OchMepIUdAlIQmQv3+1V Y3AI3z01PlD+d8nlNpLXm7d+n62zEoGchXdM6jnzXpLQ7sOCocI1NGGK5txDgm/C+PrZ VDfE1q0n8XKTzHPNZHwwLYLlm1z30wGg54+wrMhlLhEDR2hu84RoipMIhXHDJ4lacDZZ B4H0w68OvrXJWBzj/T4OwEzj/EFJMSsofG6ulEc5C0iRoCu+42/AbL03W0+xrLeDJVlP 7AUmehnwlLMnjg6tmT31G5xdcb+hFDX/iiZKaofgl5ojWZfyfqPH1il3QSlX58qwgMgG 2egA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=HA9k4jWcE6EwpyfOVUWvgKBkx2GCDQVhMAM3RavZwSg=; b=XfEWhbC0FOW/sNEeOLIX/hBbyw/shK5yNBT3C5prCdCBbvkRWcq5Xa9DBRU1jXB/Vt T/NI5pkrpztzd7SpjqXYzYRHsEXM7kYtf4vE46n7p/GSnHh4MkBMvqyCR2plVf3HSyWo 4rxOh1M0WsbDZlcxcHEjyYz8KnX0JaZ0ciyXhxK1BElx/CSJzHiDh7fvVC4cxTS2PGhe O/gj22S4ACOacsluyUdX9GLTzllMrv8foN6GzYhg9OmngIHnPL9Qxnz9xAsmJ3aOIxvN IV9u8hwIMj0wWV3CidwJfrgUdbTFk5vU+UT1lvtnEf21HbkQkLdR8G5pWSjRKhgnsnhP I5gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="MZ8f+5k/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y9si69023635pfm.236.2019.08.13.14.46.07; Tue, 13 Aug 2019 14:46:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="MZ8f+5k/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726809AbfHMVno (ORCPT + 99 others); Tue, 13 Aug 2019 17:43:44 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44932 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726316AbfHMVno (ORCPT ); Tue, 13 Aug 2019 17:43:44 -0400 Received: by mail-wr1-f67.google.com with SMTP id p17so109117256wrf.11 for ; Tue, 13 Aug 2019 14:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HA9k4jWcE6EwpyfOVUWvgKBkx2GCDQVhMAM3RavZwSg=; b=MZ8f+5k/fznc/QyZGQ49I994yYlfbf9RAnpB0jyHIPrUh3mMdiOFe3fkYs2TiTiBPy Wl7N73j2Ax6sZSOd65X6LBFT5iH4lHRU2szMkMqFtwaDxrGnjON8WdtK3vKq6eCLxIdc yVPjBrtZgx6r5OocIKhakmMryH4iulCdqewIr6aoyLxlVTiPtpCfja4ZUdWK6EBLZ5CT Oml3VqmkzSkURgzZEzLmRNyRJbxqlQ+bTgIXnZYigiiNv9twJdtivck2hFpp4lRMxLu1 oynIeRB8iADJn5Yfy9PMQxsF6Lplkhqt3oOmP5L2OfA7XQJ0l+gnyu/r5gHKvH8wA2TK GJmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HA9k4jWcE6EwpyfOVUWvgKBkx2GCDQVhMAM3RavZwSg=; b=LSgkXjCnzlC3nvHH0xMrYM1EVyi4sMDQpJXicoHy/ItavKfSSqELKXzjUr9f2epYk1 130NVVYGwPB6UWzRPkhDwG7bRV+vbQdV1fu/sBUNout2Dz9IFF+/yuq0qFcytDBRbey0 wcSB0nUhkYBewKyV9jqZCDnUgdXTcSQFGTZBhIzYVhqjN0DPSsQGoRLvKzGaEPNaj5i2 zJAH6FJJmMLp9MYXUNqJmCKneTFm/2mPOzmxsBDzn7BMZOeUPHY5yj7gd/vGhdaACL+y 1aMo1GDmmoMI9SYE1aBLUZFCbAtaliXz5QI2gdZX04sAtuzHjBifuCW7NTcUcGRqj2+W ffnw== X-Gm-Message-State: APjAAAXjnj/9YO/hU26oHOic89HZSfCbmjwIgehJQzATvsIf/i2ephho 9VxXH5gk6krRcZfQ1GopqTkg8JHl/5bdhg63A/9wXw== X-Received: by 2002:a05:6000:12c3:: with SMTP id l3mr44881907wrx.100.1565732621921; Tue, 13 Aug 2019 14:43:41 -0700 (PDT) MIME-Version: 1.0 References: <1563602720-113903-1-git-send-email-chengzhihao1@huawei.com> <0B80F9D4116B2F4484E7279D5A66984F7A7472@dggemi524-mbx.china.huawei.com> In-Reply-To: <0B80F9D4116B2F4484E7279D5A66984F7A7472@dggemi524-mbx.china.huawei.com> From: Richard Weinberger Date: Tue, 13 Aug 2019 23:43:30 +0200 Message-ID: Subject: Re: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps To: chengzhihao Cc: Richard Weinberger , Sascha Hauer , Artem Bityutskiy , "zhangyi (F)" , "linux-mtd@lists.infradead.org" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 3:21 AM chengzhihao wrote: > > OK, that's fine, and I will continue to understand more implementation code related to this part. I think we can go with the realloc() approach for now. Can you please check whether the assert() triggers? -- Thanks, //richard