Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp51741ybl; Tue, 13 Aug 2019 15:43:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqw3hctgS7QxMTNQMlvLUTdWeoOqeIRpQH6a8kXb91Hp1seIZb6OHm7nnWbxELJH6jeHROOx X-Received: by 2002:a17:902:b591:: with SMTP id a17mr15624889pls.189.1565736215586; Tue, 13 Aug 2019 15:43:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565736215; cv=none; d=google.com; s=arc-20160816; b=RyTKIvlFgNbR2ezbc85qV30Z2Dk3IDAK2zLfATKSoH0rYUdPnjtE0FAOPMn8pPjyTK G+dGgoXUb39RjsmBKFqC6girwVFdDhhM8aDVEfsoRjMVbyNA47DFqJQMrBgHmQ2oi6eK PhB+N7L8Ofkz6j0tKlVAC9t1KHGpPmVtJFbQ2OYg4K2dkBGZLHt9/jqbSlTEl/Hlkvv6 KmJERepuBceFk5kdISRzv9G7LsCdqX8RjRAkixEc0861Se8WKk2RfCyNhgVPHFu8sTpl p1Cj1E+Uke9rNW+wtjzReKd+NrZYSs8vDcGcIJizlqq2kUNvy5qOLSm2Jxy0bS+baO/g 8/EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-filter; bh=kKYnRsq8EQdKKGwLSP33n/ANzqknvJ1OIeBVtGJSNbI=; b=BN+POUUaf1DdtMI+ntKF7wDXl+P1p3dYjoiE+MJidgSf642XAkm3SwKXpvDCjH+93H TL/yC41KKj1IiKsbHHSURnP5xS0N5BPjNNWJVTrruiYpE5IGHekqeWQoSpPVA74//Cv9 OtsHx9oz948Jwqjh5U61KMH5H0RlIz/FA6G4psBoRndLrA6PLYn3vb+TnkKzj6u76R4n MGoNxJ4pBePEfSnf1or9pOvMeigDWXVV8XBla2bHnjd8aUu7+9fJ2X0yEej4CKASH+ss rNUrorT+pcLAdsYr55opsl5vOueXwxn8U8EUM7DatGM3q+fw2g2scD51QhvQ22K0zlo/ aSNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d27si53344584pgd.328.2019.08.13.15.43.18; Tue, 13 Aug 2019 15:43:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727418AbfHMWmX (ORCPT + 99 others); Tue, 13 Aug 2019 18:42:23 -0400 Received: from linux.microsoft.com ([13.77.154.182]:40528 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbfHMWmW (ORCPT ); Tue, 13 Aug 2019 18:42:22 -0400 Received: by linux.microsoft.com (Postfix, from userid 1029) id CD4FE20B7187; Tue, 13 Aug 2019 11:49:40 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CD4FE20B7187 Received: from localhost (localhost [127.0.0.1]) by linux.microsoft.com (Postfix) with ESMTP id 039FE3005457; Tue, 13 Aug 2019 11:49:40 -0700 (PDT) Date: Tue, 13 Aug 2019 11:49:39 -0700 (PDT) From: Jaskaran Singh Khurana X-X-Sender: jaskarankhurana@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net To: Mike Snitzer cc: gmazyland@gmail.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-fsdevel@vger.kernel.org, scottsh@microsoft.com, ebiggers@google.com, jmorris@namei.org, dm-devel@redhat.com, mpatocka@redhat.com, agk@redhat.com Subject: Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation. In-Reply-To: <20190625182004.GA32075@redhat.com> Message-ID: References: <20190619191048.20365-1-jaskarankhurana@linux.microsoft.com> <20190619191048.20365-2-jaskarankhurana@linux.microsoft.com> <20190625182004.GA32075@redhat.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mike, On Tue, 25 Jun 2019, Mike Snitzer wrote: > On Wed, Jun 19 2019 at 3:10pm -0400, > Jaskaran Khurana wrote: > >> The verification is to support cases where the roothash is not secured by >> Trusted Boot, UEFI Secureboot or similar technologies. >> One of the use cases for this is for dm-verity volumes mounted after boot, >> the root hash provided during the creation of the dm-verity volume has to >> be secure and thus in-kernel validation implemented here will be used >> before we trust the root hash and allow the block device to be created. >> >> The signature being provided for verification must verify the root hash and >> must be trusted by the builtin keyring for verification to succeed. >> >> The hash is added as a key of type "user" and the description is passed to >> the kernel so it can look it up and use it for verification. >> >> Kernel commandline parameter will indicate whether to check (only if >> specified) or force (for all dm verity volumes) roothash signature >> verification. >> >> Kernel commandline: dm_verity.verify_sig=1 or 2 for check/force root hash >> signature validation respectively. >> >> Signed-off-by: Jaskaran Khurana > > Milan and/or others: could you please provide review and if you're OK > with this patch respond accordingly? > The v7 of this patch was Reviewed and Tested by Milan Broz. Could you tell me when this will be merged/next steps, if required I can post the patches again. > Thanks, > Mike > Regards, Jaskaran