Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp173169ybl; Tue, 13 Aug 2019 18:18:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwqfxJddlWXD06LTnv3hluXXASVZFhGwdrujQuD4E0+OqAj7KOyprt87A2BL2bf6wOCxa9p X-Received: by 2002:a17:902:aa95:: with SMTP id d21mr38752326plr.185.1565745490041; Tue, 13 Aug 2019 18:18:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565745490; cv=none; d=google.com; s=arc-20160816; b=Qtn9RVT9qdLRB8+YoMyQ7QKDs9NT7O5pWUzXn8ZL2qGqn00eE9HCRSvkPE8WOa+4Er LJoNNo/akHUpxuUWvAWbzcopj+R1IfL0gpf1bTBClDFHWB9kToEEaW7kYzaJ98oBxACc 2r/ja6piqrvQl1RgUKZuhJ8XxM5LgwRaKgfP1Snf5LEBdA3hgGpHTzJIN6PsWd2I+0o2 0l9r+ayoHXm5XW9BU1vdnQlnwxy6GH2SlOeogVjLFgxTQSc5fddjV0NGVXDbCXFeVfZN t0aHVxDUjDzySldSY2rzibkExAhARCThU+xBM3ONDpT+G9Kiien90NI0kDmLQez940WI 5T7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=gIDHACBtZG4QwgSbC4cEbESKInKtg+TuqLMDUeDDSt8=; b=k5Iunjm9nB4wFXFD0PKJEaLUdSaVvrLab0wD17L9pq9uNHC5o5hi9EAJYLlAFNU1VD k/JVvbHOyTbp5jiWPoc8gwl1saJG2XGowyeUEwSSIxEf2STMVIhju65WsqQD9VTSSYK2 UENsG1AbHiq1i0xMg2GzsaZgmb+2r6KW1fVAAzwaw6s0V6yepsgDXv50ZZHtoKFlmnoH KIQLBu5xuNnC91yxShLwKsXKtQ9nwFuQhWBDZLOvs7EA37ZxN6bfyB0zpPv6A5pT/neK GqghLE8V+jtZek1JJdJbrR7u5XddGNVpUvjUclnZENzKbC8mOL7h7stDS/ZviN1mUBd2 NyAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b="zNc/D6Mi"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j191si67234213pgd.88.2019.08.13.18.17.52; Tue, 13 Aug 2019 18:18:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b="zNc/D6Mi"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726966AbfHNBPk (ORCPT + 99 others); Tue, 13 Aug 2019 21:15:40 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:37518 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726888AbfHNBPj (ORCPT ); Tue, 13 Aug 2019 21:15:39 -0400 Received: by mail-qk1-f196.google.com with SMTP id s14so10887327qkm.4 for ; Tue, 13 Aug 2019 18:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=gIDHACBtZG4QwgSbC4cEbESKInKtg+TuqLMDUeDDSt8=; b=zNc/D6MilOoRrB00soRn0mjxyGTsDiube/BSjdz6cyK7z4qSM0DbNjxFk2/ngCHwjj KPZBgmc6foRZ4ZzN3jqpQksWg3ioHMk6n++KvSFKKaFHJnSefIO5UVuab13lL+xXnd3K ikw+Uc4dUvRP+c6iIidWvLxoWelpk7RRECXxMnibtvLAHF/HWcYc/TVwjMLjPfGBQwbI WgMJLPF1637QnWcEWOcuCFzzJwH1y0wG54lMbM2TLVCSF319xaBCyNxidRBnNpB8PI6c zD7uaULnVp77lKsKYDEtVXx/Pia0KYO5imIuiH5ylXLeVrboaJFD+BYLEaxBBZCqsyqS HcZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=gIDHACBtZG4QwgSbC4cEbESKInKtg+TuqLMDUeDDSt8=; b=PcTq6oxDxDapt/kLBOwGysUAWG1XaixWOhdKfOsxox8pTpcC+/5nhI4Vxs2ybUxsAa thFOXbbLaYyzjqO8VKvo/DbfMFTUPLREZIDf3FXSj4UshhFptnR2jR3wLqFLBab7kCPg BgSZYpOQxH0jyaeaRGTLViWwozgDfVTLP3t3vPlbSjoSerzerdA0vWME+GP3b6tNO2mY i+vEdiXIiFxHuHi146H+cOiBEG8wv3iX0XrOljCsdKc1xhIiMk0EK0AwOFUpniIO0yZC L9MQNbV0xrL2/loYgr81mPhrD9LFus2erPQysnxDZ4jDLxv/x5rxSEOGqXnDqJBx3Bzj ABlQ== X-Gm-Message-State: APjAAAWRhgtDMlah4i6308R7yJ1Vqy6xUFz7uxLJXYOT67i944zehGHx PILF5KxKCSrQZsyfsfambpjVbQ== X-Received: by 2002:a37:a742:: with SMTP id q63mr34544957qke.421.1565745338982; Tue, 13 Aug 2019 18:15:38 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id q29sm13587113qtf.74.2019.08.13.18.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2019 18:15:38 -0700 (PDT) Date: Tue, 13 Aug 2019 18:15:29 -0700 From: Jakub Kicinski To: Hayes Wang Cc: , , , Subject: Re: [PATCH net-next v2 0/5] r8152: RX improve Message-ID: <20190813181529.23d5c2d5@cakuba.netronome.com> In-Reply-To: <1394712342-15778-295-albertk@realtek.com> References: <1394712342-15778-289-Taiwan-albertk@realtek.com> <1394712342-15778-295-albertk@realtek.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Aug 2019 11:42:04 +0800, Hayes Wang wrote: > v2: > For patch #2, replace list_for_each_safe with list_for_each_entry_safe. > Remove unlikely in WARN_ON. Adjust the coding style. > > For patch #4, replace list_for_each_safe with list_for_each_entry_safe. > Remove "else" after "continue". > > For patch #5. replace sysfs with ethtool to modify rx_copybreak and > rx_pending. > > v1: > The different chips use different rx buffer size. > > Use skb_add_rx_frag() to reduce memory copy for RX. Applied, thank you.