Subject: Serial: bug in 8250.c when handling PCI or other level triggers
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: rmk@arm.linux.org.uk, linux-kernel@vger.kernel.org
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Wed, 14 Dec 2005 15:23:23 +0000
Message-Id: <1134573803.25663.35.camel@localhost.localdomain>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 882
Lines: 20

The receive_chars function is designed to handle the case where the port
is jammed full on by aborting after 256 characters in one IRQ.
Unfortunately the author of this code forgot that some systems are level
triggered. On these systems the IRQ simply gets invoked again and the
count loop just makes the problem take longer to clear.

In the non level case it appears that a jam could leave the IRQ jammed
forever and ignored - the remaining bytes never appearing.

As far as I can see the code would actually need to clear the interrupt
enable and then restore it on a timer event or similar in order to get
the intended effect.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/