Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp348938ybl; Tue, 13 Aug 2019 22:19:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqxVvSehvE/3eA9JxI9rwUG0j+f2eL8V8l9hVhcuIqaxVv0NFSuXRgW+5yMmFLu6U+ic+WFN X-Received: by 2002:a17:902:7c12:: with SMTP id x18mr32094740pll.123.1565759981219; Tue, 13 Aug 2019 22:19:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565759981; cv=none; d=google.com; s=arc-20160816; b=dEf/Q2efH9i5GzzdTqVEHXkNja11Jd0fapbDBYrkCJi/q76OUWLNyi9J6JvRmnnD+o UQ7+EDqHFX+NpjwHMREW6xHfH6XdOMVcuxtgqIzVXm1QN7EezG+OUVZ7f23mA33Cv91l sousWmENVhvieNK9zVtjblTT65PtDuj43cWhU18cecfFvgMSM01gW9umrlcb0HqaHXoU TSOXau3gXrAVyP7qIYEotOiLi6G6xGIUmFxxeY/KI2gv/eqxxq/XBsVh+967HWIFSg4u omGK+ZKpIzuqw7r5H2SUvbIF1fju3jRNtnXSFBickFuosG0RzuPGCKx74a+f8+6g+hXC qBQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=N5UgffLx0K9E7sg8gJhbNytPcPQiUdiEfXRwQzPYz8M=; b=acv1DYV1/Z5gOOG5p3QlcIkHbpkmGWytpF8QB4o0nzklQGBiRAkIBazn/rkarWZWx+ K1AJ2Wx5ZLC8Ouh1CgiOowr91V1Rcz+OOajLnNiMFD3VjNo6jXMof6yuYK+KG+PTX3qq mbbzecEvlpZm/6QyTA2QxYLeFguxBTZaK02cltjf+yQlAINtkZH28Ddv20lc1FuB+8rf QYWM1aFLYfkBSifxbq0JXLtH2GA4DixRvXNe8IoeF8vdWykTxqa7FoEb1EXaNmwZ01tY IJOB+Gg4kz3HrcVCTOeUt3D7NWhWGlGUg4o5US4lAF6p6STkd5Lyvs7XWx73ugqJMW1i +KSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=T4LZ3dc4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q15si38276280pgk.537.2019.08.13.22.19.24; Tue, 13 Aug 2019 22:19:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=T4LZ3dc4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727398AbfHNFQZ (ORCPT + 99 others); Wed, 14 Aug 2019 01:16:25 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59204 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725263AbfHNFQZ (ORCPT ); Wed, 14 Aug 2019 01:16:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=N5UgffLx0K9E7sg8gJhbNytPcPQiUdiEfXRwQzPYz8M=; b=T4LZ3dc4L7KIXFyNLJInPyudn B/ntFTV2Au8ljYqdObvWwLB/8U2dwgaV7MhxXWpfSy6/RZJZCp7VJ0KDvTogqmgcIJWxOwVqGoqAm d7WGhRVuSLvtFMzyYwrFSrbQj9kFsBzqw6OIxsmOTpcV2Y6C4drERFtKvvXDjoUll8X6l+XLz3Pks 59L/rbuv+kTE+bAgEWUSIfqbjl98Odw0hAS5k5xAvxgopQLYs7QHi5KWP50nV3XLonvnGLE4P0hwL GCdw2ky9NRSES21nonHbSkpQTOAA8cEnMR80zexx1I8iiLsupG0ABL2/LZiVvhOSKQSRKS6pPttDP O1OK21zQg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hxldr-0001tl-8b; Wed, 14 Aug 2019 05:16:11 +0000 Date: Tue, 13 Aug 2019 22:16:11 -0700 From: Christoph Hellwig To: Wei Yang Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, vbabka@suse.cz, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list Message-ID: <20190814051611.GA1958@infradead.org> References: <20190814021755.1977-1-richardw.yang@linux.intel.com> <20190814021755.1977-3-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814021755.1977-3-richardw.yang@linux.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Btw, is there any good reason we don't use a list_head for vma linkage?