Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp367912ybl; Tue, 13 Aug 2019 22:43:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqxtK98Y0ilVczLBEviQ3IZkhW+aYXAKkNxzlucLrwbdKuYROZbRlNvb6mSqXQXcLhEknNlj X-Received: by 2002:a63:6901:: with SMTP id e1mr36286940pgc.390.1565761389557; Tue, 13 Aug 2019 22:43:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565761389; cv=none; d=google.com; s=arc-20160816; b=Mt3RUnTL6kDmNBiFbyJUTeDSuyG5sjFP8GHzOgyabzK2tL/dtwk2EXbWAQ5ufuHmuz YjHiI7uTaYIzpOqPadpK9rdxcqrQN34yt7dHOlMZVcXb44EWkkZzwgYdDhu0oy0ms7Im g/b0Brpz225bV+iOlgJn/N8weRFNFpylP1EY9j/qzbgjhdc782pAjNmFnye1Ou1koIHn hqMSS+cqe8ewqK7PbUQrAVn0Rxv3BqAiy5w/Y1qRsxFGZH5EgBm8tSG6f//07naCcfBI MPueStULf63mXqOiBrFYDV+UlLIMbZeiDztRklnY0LJuySuEdjRPh4gFoTdlQkNXhXnl JfYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=F0cWN81BVAMFJ0/xPnwZWS50E+BFnUwABWXU1XpT1NU=; b=L7gs0JQ/HUQsZ4mPn35PvL5QnJnowwVOqyiPxBTc7mFgjcmJV5wJjtGmqQwyCfVv01 McgkN1coAU1n3VaCBVUWbCH4Vxuw9kMq1QI7ghAQVIiP/62+qnJeFbPHQN0ZK3XIi1Yw dYUPFq8U3EAK6uquob2tEg3TgSx6hG287I3DBUPA0Vx7YPgm6ZsoYX3BLwfoP+9kEchV quq+YV0JbVCA1mnuMKCctb4LOpfydVJCj/bx6EIBT7L+/CQW878VxYJ+gvK/3fUI5gI7 gBjL85B6GBO56Sri9I91tZhocN6HtoFLGiOWUBR74Rt1MS2IPIru4N6xl6fV4+MOIerS kE2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EMzCqMDB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a143si4805599pfd.237.2019.08.13.22.42.52; Tue, 13 Aug 2019 22:43:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EMzCqMDB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727422AbfHNFkk (ORCPT + 99 others); Wed, 14 Aug 2019 01:40:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:60836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726882AbfHNFkk (ORCPT ); Wed, 14 Aug 2019 01:40:40 -0400 Received: from localhost (c-73-15-1-175.hsd1.ca.comcast.net [73.15.1.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F3B120843; Wed, 14 Aug 2019 05:40:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565761239; bh=BcTVOpWjejlJQLRKMOuwLxgamclM2LKtYDZAFC7tU0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EMzCqMDBjkofqdOZx59ict1Fr6TMdqw0s4RuTCigOU3/xywNMLDhFt/E1awRwhuyH uZLmCsD58zb1pfz1g2Ya3zLjA6sl+alQU9UVYjLYzSovK6pEHohGXcB58juvbRNMqS p35vDmmxYK6fDlwB4gNiGKRYkRG5S3pVk5mBODfY= Date: Wed, 14 Aug 2019 00:40:38 -0500 From: Bjorn Helgaas To: Kelsey Skunberg Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Greg Kroah-Hartman Subject: Re: [Linux-kernel-mentees] [PATCH v2 0/3] PCI: pci-sysfs.c cleanup Message-ID: <20190814054038.GB253360@google.com> References: <20190809195721.34237-1-skunberg.kelsey@gmail.com> <20190813204513.4790-1-skunberg.kelsey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190813204513.4790-1-skunberg.kelsey@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Greg] On Tue, Aug 13, 2019 at 02:45:10PM -0600, Kelsey Skunberg wrote: > This series is designed to clean up device attributes and permissions in > pci-sysfs.c. Then move the sysfs SR-IOV functions from pci-sysfs.c to > iov.c for better organization. Patches build off of each other. > > Patch 1: Define device attributes with DEVICE_ATTR*() instead of __ATTR*(). > > Patch 2: Change permissions from symbolic to the preferred octal. > > Patch 3: Move sysfs SR-IOV functions to iov.c to keep the feature's code > together. > > Changes since v1: > Add patch 1 and 2 to fix the way device attributes are defined > and change permissions from symbolic to octal. Patch 3 which moves > sysfs SR-IOV functions to iov.c will then apply cleaner. > > > Kelsey Skunberg (3): > PCI: sysfs: Define device attributes with DEVICE_ATTR*() > PCI: sysfs: Change permissions from symbolic to octal > PCI/IOV: Move sysfs SR-IOV functions to iov.c > > drivers/pci/iov.c | 168 +++++++++++++++++++++++++++++++ > drivers/pci/pci-sysfs.c | 217 ++++------------------------------------ > drivers/pci/pci.h | 2 +- > 3 files changed, 188 insertions(+), 199 deletions(-) Applied to pci/virtualization for v5.4, thanks! Beginning of thread: https://lore.kernel.org/r/20190813204513.4790-1-skunberg.kelsey@gmail.com