Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp375183ybl; Tue, 13 Aug 2019 22:52:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqyGuQmuSCrzqyr4S2o+Qz2fmz+74CnNXpZmWnXcXMDeXVY8dQBAsX8garpw/PGtwURCdj/0 X-Received: by 2002:a17:90a:dc82:: with SMTP id j2mr5670004pjv.89.1565761933091; Tue, 13 Aug 2019 22:52:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565761933; cv=none; d=google.com; s=arc-20160816; b=rGU4GZ2S88M/JSiPBL2MxfAZqSlw9opuHduQwwRDCdZlXEk0EogrkVhiu7mtRXIydk dbWccR0cabwsHm4HbrVR6BohVbjD4LzNIPsi0jKYDzVyX0IlWL7SQWSOADsEkVOyjZ46 5jrs4cQ+82NQcfGteOF/xj/cW+IOylC1bPpTC9ERQ0EKQiZ4hKrC5OGDzcE2Ki35TbWN zdxTT2OPLBHK444vloLHBDpC+gEDabz84sGhXG6eSPg5/T6aDLYsIV2T7SGqB0dJXmtB NqJ1u6vIgNWpbNf5ll3pQJxGWToYx9XSrJEqUUFWwWtzgk9c7gmUSryQEiDSM+dQQjmy +ECw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=yLBvjgIz0/4kJcpvkkBD2mhvRhrr916GyFhs+M2+Ar0=; b=Dt6ul5dN6/eG5ZWj/NgRMUAfE0tSo4fQieemyATcUhC7kd8/kE4PI8itz2PEOAhLbt DaULKlh3KbPEbozdL2g1u2i770aXYBv0BUpdF241tvOS2F1tsJ/UFjnGE33/IDj1hCpr JXKly/PR7Z9JctG3bPpfc5XFEJ/Sa1yuWq4rKdglweMhf5DAs9ZEk9hUFFirEYZrsE+P 2RwfEqF7l3XqKkX9sazINPTDFary7Zi5U/BjFcW0S4K3NkoqKFtDq0GuXmuc1peU1Zqf cGH30Dt5y96ox0PpC3Tz9rACYLgaf6YLdQZd3fARCqjayc6LxQPu+xR4hy3xQB14W8ER oFRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=l89PZLe3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2si64396070pgv.417.2019.08.13.22.51.56; Tue, 13 Aug 2019 22:52:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=l89PZLe3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbfHNFtt (ORCPT + 99 others); Wed, 14 Aug 2019 01:49:49 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:60128 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726882AbfHNFtt (ORCPT ); Wed, 14 Aug 2019 01:49:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yLBvjgIz0/4kJcpvkkBD2mhvRhrr916GyFhs+M2+Ar0=; b=l89PZLe3h8ePNmyh0C6eM6wvl fuUGOalLN8UJhfga5/x6cM+wfPZjKyP5Rya55baqZOzsQaDLp7ZtDMIikFLTGJo/jvDrqoaEEJso8 4bSX88LZau5MGKh18xEunO8WFA4fU3P+9LXlt7chI7aR+md32QQUHCsE61yupuvbCWyVZnzzDRmwR toolzrEcnVxrJi9pBe/2uCpjXcOzUyZMnSlov9ZZKHDGRhPv60trWYFwKnuLXr+eNoG7iATOE8tjX v1TrZew0KtMKapyRN+nODjjWFxz23lJr7W2y5Q7+JksSuUOURqm/FAzzBa/MdsQM8Jxc9jVpz76rT DVAssgY+A==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hxmAH-0001Q6-5w; Wed, 14 Aug 2019 05:49:41 +0000 Date: Tue, 13 Aug 2019 22:49:41 -0700 From: Christoph Hellwig To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 10/10] powerpc/mm: refactor ioremap_range() and use ioremap_page_range() Message-ID: <20190814054941.GC27497@infradead.org> References: <6bc35eca507359075528bc0e55938bc1ce8ee485.1565726867.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Somehow this series is missing a cover letter. While you are touching all this "fun" can you also look into killing __ioremap? It seems to be a weird non-standard version of ioremap_prot (probably predating ioremap_prot) that is missing a few lines of code setting attributes that might not even be applicable for the two drivers calling it.