Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp405138ybl; Tue, 13 Aug 2019 23:24:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqw0E8dwjQxXUYr8vK7Qastfq87YGSYN0956mvErLFAkQbbFzb8GB7n/zA1a7nzWkM7Srk3l X-Received: by 2002:a17:90a:9903:: with SMTP id b3mr5631913pjp.80.1565763886240; Tue, 13 Aug 2019 23:24:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565763886; cv=none; d=google.com; s=arc-20160816; b=h2MDm+gb7D7iHlQE38whMHzBbZEn149kwOCIiq7qhTj4Vv000InNvWqU++/woZuA6N 9m3DNKUtqj4n5V4vEml/sWJTj2Bc44Ce6+3zXFfrBT7VkN4lcuz/6bWr7qCeLHe9E3Jv ZTrQpWCV2XciVaPO449sGx8QInD/FFEvasK/IwCWJLVQmpitOtvEINNehO32GFqx4YbP 2IwFtWIxkpwkDbTa0HTVPJMx/sDnmSQaph9zByWV8tVxHcFxteezfSifU+e5AGTBkuR1 i/bOzQyetzYmoQkXcB4HaJNSiDWDuFUDOdn91pGIrnlkgyaeA/wV+fQ5gOz4DeVMlCwH Wt6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=riZMoyaCD1+ZQ3eW9ssk+3+aGprxE6J0aY0oTm8WUHk=; b=l7Svoq++TvpGxJxtYXHyZnqPRksivk0pKRWjiB7gcFoDp+EKrz2KjMC2ll7u2+/wWt vJJxr5oM2lODMaroO/2MJq/aGQk8jl/7yRLJa/v9arBx80BqYs19s4joUJiPYkYVbRL6 lVwfxf2Tb0Sk5v6muLNgg4q/UiotnZu33hWhbSqePgks1nng1tZK4NBnn9vmf2t3V5An ZaepoNg7j3KD/DehsnWrcdkBDblYTTv5wA0sm8vsI0eyk6DbQQPcdo5541AE4HDDtbow 8TLywngo9AvbVZJJb7FWAlIUZwv17jc7b12AQGFWPXbaLHKLSJbmyH0Z5IcmwmKf0Dup 6pQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=avbdMWC6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p23si36821811pgi.76.2019.08.13.23.24.29; Tue, 13 Aug 2019 23:24:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=avbdMWC6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbfHNGX5 (ORCPT + 99 others); Wed, 14 Aug 2019 02:23:57 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:33162 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725265AbfHNGX5 (ORCPT ); Wed, 14 Aug 2019 02:23:57 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 467ffy4tKYz9vBn1; Wed, 14 Aug 2019 08:23:54 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=avbdMWC6; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id a4nZaAJs1IUV; Wed, 14 Aug 2019 08:23:54 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 467ffy3jSmz9vBn0; Wed, 14 Aug 2019 08:23:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1565763834; bh=riZMoyaCD1+ZQ3eW9ssk+3+aGprxE6J0aY0oTm8WUHk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=avbdMWC6gc6VxruvxXJGtYUHAYWYzSiS4yb5QNH+51hPcJHVoUSm6e/d/DNpYKicI vS8BErZ65r9GgWrakVITqUbxe3MQx1YDyYqkEDsIDZE0uQCzGij7OUCEWw2XfNC49T 7TCdqwMlO5wSet+PmpAdKey3vLAnVDf8FPuOq+Uc= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 828FD8B780; Wed, 14 Aug 2019 08:23:55 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id ApWTthVaOqfG; Wed, 14 Aug 2019 08:23:55 +0200 (CEST) Received: from [172.25.230.101] (po15451.idsi0.si.c-s.fr [172.25.230.101]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 5FC4F8B761; Wed, 14 Aug 2019 08:23:55 +0200 (CEST) Subject: Re: [PATCH v1 10/10] powerpc/mm: refactor ioremap_range() and use ioremap_page_range() To: Christoph Hellwig Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <6bc35eca507359075528bc0e55938bc1ce8ee485.1565726867.git.christophe.leroy@c-s.fr> <20190814054941.GC27497@infradead.org> From: Christophe Leroy Message-ID: <3f866bc8-7cc3-cb09-92f3-016dfb906526@c-s.fr> Date: Wed, 14 Aug 2019 08:23:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190814054941.GC27497@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 14/08/2019 à 07:49, Christoph Hellwig a écrit : > Somehow this series is missing a cover letter. > > While you are touching all this "fun" can you also look into killing > __ioremap? It seems to be a weird non-standard version of ioremap_prot > (probably predating ioremap_prot) that is missing a few lines of code > setting attributes that might not even be applicable for the two drivers > calling it. > ocm_init_node() [arch/powerpc/platforms/4xx/ocm.c] calls __ioremap() with _PAGE_EXEC set while ioremap_prot() clears _PAGE_EXEC Christophe