Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp415797ybl; Tue, 13 Aug 2019 23:37:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqybsfRx0mk46tsZ4Sc8ppisT1p8AXr0zwdpMvDa66CB2gIAlYGfQdHWmL0TPGnhvGm0H+LB X-Received: by 2002:a62:3347:: with SMTP id z68mr45884997pfz.174.1565764649985; Tue, 13 Aug 2019 23:37:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565764649; cv=none; d=google.com; s=arc-20160816; b=NQYI5eIiRDqv2kEqwMFu69uMSf0WVLUOsO2+r13iyFxfn7cAz+s5f0FCqyvgshEU+j vWo7E+XeJpl+DCOP5eh8A7qwmxSYqV1u8JadXoy7lkwXuV8iqUUmZLXngg+ePlgxZdLv XNnQj4mx0bGbXeUrRIvmVrkiYqZWXT7FuMMT8CWtIyj9LkzuNWW1dUwGNWLY+ngJYjoa 85Tqokwe1LdYYgod80m6eYGiumDOFoi4bJZaTSWicJ+t310//0vdTgrzJRwzQXn5N0Mu 3gyuW2Z0l/8PKQxxilXw1Y/N0taedjPTdMwTD4Kb9Er7nlAAwax19Ws5lhsXfxiwqnGI +Mww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=V2ZJmMM7eBUrb1Y12nRIIaugrWodscFeaE9AP4JG/Zg=; b=ExUk4ZdcwIcn4m7Enu/We1Tb6gNSjOL5c0YTHTUu7hKTRBefQzZqaLW+6RHSnfmcSP bmtJO0mSZY/h8taPQrFxQSyZjU6Q6cjRQD+8XNF4jkii43xCdYARQ/wuJzQ6EMf6KMOC lq0kNxsDlAmtWlfpsqyXdE3zcGQglVROxboE4/lIHOdHi91TpCDVbVp/F0NnTcmpe5yk BpgWpibOSEKL3sop/oGWv1lLVYrKtuSX1u34XBi9QyhPEuvHvO9XKpNZpuigl+GMnxoI yaAFSq3/x/9NQBhSrfIn0MDx1XAyAmNyn4QPY4aJLPb82w6wrrWh9Hu+4G2W7CLNs+wd fCjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Gr/yUIA7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si60561672plb.14.2019.08.13.23.37.14; Tue, 13 Aug 2019 23:37:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Gr/yUIA7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727452AbfHNGgb (ORCPT + 99 others); Wed, 14 Aug 2019 02:36:31 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33540 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726940AbfHNGga (ORCPT ); Wed, 14 Aug 2019 02:36:30 -0400 Received: by mail-pg1-f194.google.com with SMTP id n190so11760227pgn.0; Tue, 13 Aug 2019 23:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V2ZJmMM7eBUrb1Y12nRIIaugrWodscFeaE9AP4JG/Zg=; b=Gr/yUIA7h/3eBDYc9/YH3PmK0TnssS6CO/9hFNunLAWWczG3OiVHN4WIIgL3E9ZCpt lxw0s7tI4ERoXSIwh3JMsdgc8zNzPjnA6BXgqeWAmqEyh+LbCMXm65+O4nT6k1c31e4G 72a+RzjyGS+EkSW5x52rptXOtidXTsKAuxWhyJ3b6xCpOT6ucihhvpEg52ywhW82gF/O HmWN/pIGHF5t5B5reCnO/nsCfzeJAwUmX5rfj3UfluGG3M6/UTPt0Rx+R75a3hwPVGGS CEB7dg3ncNyljnIstqsOyQ3HSCSlywswvj4u3icgmk4pUqxyXQc3S7rYfldNhw5/Vge5 lm7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=V2ZJmMM7eBUrb1Y12nRIIaugrWodscFeaE9AP4JG/Zg=; b=VfatWZi2jk7Da/3tWd0auYKCJzuJ73Eomf0Rg677KQTiokULd0hOD1t1WPIULL7+Ur lDUCIJBzyKz0R1pex0yauixfhb42Bawzo8Iw98YK2Uu+TcAWn5/kr+7/oHTEZ1vixfHC CzMQf0d4r0xBuuCKc5bAsgNiEr9sYqC9Fj5xKyTO8oNyII2y0fgD8PAzO5Y18BR6rQej otuuqy5J2anmqabhuhamJqThvBZIFjZSHu95nLHmNqK8P+MCbpTNC5GNfvrN03dqPOle nuLxSSz+22KYDAi9rvwNqe7sEOmzv59aBjnBSUH5fbisihdM7FIaOUfSGzmzvdxsbacF yVKA== X-Gm-Message-State: APjAAAWC77hMiweIYiz8Dz6e1XlrzLJTIFlC62+4O6kJMAFj5mHIW1VO TZ/MeaJIAlK7ag24t4NnmqA= X-Received: by 2002:a63:89c2:: with SMTP id v185mr37393202pgd.241.1565764588977; Tue, 13 Aug 2019 23:36:28 -0700 (PDT) Received: from himanshu-Vostro-3559 ([103.77.43.147]) by smtp.gmail.com with ESMTPSA id j15sm109471223pfr.146.2019.08.13.23.36.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Aug 2019 23:36:27 -0700 (PDT) Date: Wed, 14 Aug 2019 12:06:11 +0530 From: Himanshu Jha To: Matthias Maennich Cc: linux-kernel@vger.kernel.org, maco@android.com, kstewart@linuxfoundation.org, linux-m68k@vger.kernel.org, oneukum@suse.com, Mauro Carvalho Chehab , usb-storage@lists.one-eyed-alien.net, hpa@zytor.com, joel@joelfernandes.org, sam@ravnborg.org, cocci@systeme.lip6.fr, linux-arch@vger.kernel.org, linux-scsi@vger.kernel.org, x86@kernel.org, lucas.de.marchi@gmail.com, mingo@redhat.com, geert@linux-m68k.org, stern@rowland.harvard.edu, kernel-team@android.com, sspatil@google.com, arnd@arndb.de, linux-kbuild@vger.kernel.org, Nicolas Palix , jeyu@kernel.org, Jonathan Cameron , tglx@linutronix.de, michal.lkml@markovi.net, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, sboyd@codeaurora.org, Nicolas Ferre , maco@google.com, pombredanne@nexb.com, "David S. Miller" , linux-modules@vger.kernel.org Subject: Re: [Cocci] [PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies. Message-ID: <20190814063611.GA22387@himanshu-Vostro-3559> References: <20180716122125.175792-1-maco@android.com> <20190813121733.52480-1-maennich@google.com> <20190813121733.52480-9-maennich@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190813121733.52480-9-maennich@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 13, 2019 at 01:17:05PM +0100, Matthias Maennich wrote: > A script that uses the '.ns_deps' file generated by modpost to > automatically add the required symbol namespace dependencies to each > module. > > Usage: > 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define > DEFAULT_SYMBOL_NAMESPACE > 2) Run 'make' (or 'make modules') and get warnings about modules not > importing that namespace. > 3) Run 'make nsdeps' to automatically add required import statements > to said modules. > > This makes it easer for subsystem maintainers to introduce and maintain > symbol namespaces into their codebase. > > Co-developed-by: Martijn Coenen > Signed-off-by: Martijn Coenen > Signed-off-by: Matthias Maennich > --- [] > MAINTAINERS | 5 ++ > Makefile | 12 +++++ > scripts/Makefile.modpost | 4 +- > scripts/coccinelle/misc/add_namespace.cocci | 23 +++++++++ > scripts/nsdeps | 54 +++++++++++++++++++++ > 5 files changed, 97 insertions(+), 1 deletion(-) > create mode 100644 scripts/coccinelle/misc/add_namespace.cocci > create mode 100644 scripts/nsdeps [] > +if [ "$SPATCH_VERSION_NUM" -lt "$SPATCH_REQ_VERSION_NUM" ] ; then > + echo 'spatch needs to be version 1.06 or higher' Nitpick: 1.0.6 > + exit 1 > +fi -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology