Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp475954ybl; Wed, 14 Aug 2019 00:45:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqygqVLuH0HOeGSAMStntRZj4uQAG4yYTZ3MUR7Q56uxubvU01+vk5gDtfK+j2B1n9k93MuW X-Received: by 2002:a17:90a:1a1a:: with SMTP id 26mr5949961pjk.118.1565768710620; Wed, 14 Aug 2019 00:45:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565768710; cv=none; d=google.com; s=arc-20160816; b=GWCmwq38o+52E7U88RI4tfPlXoj03n4mhoB1wNhg09XwSMx+9smaLLHvldzvrCk5zb QQnHKjqWVpyR4mY3jrRyZY2xaY0uXK2w1fUoKYO3NLxcEG45fhpQu7pOI1t4Gd+G1/8Y zZv/nWmD8z9+AvcHAHraYFnPmTd4Ky5PFh0Ec0U0JN9BhiuQ4VW7xTNm+aIJNh04Yjqx uqe3I3Ld5R4O8SBzzlsqJqC+J+Ej1jVgI6RvK4oS17TdJVVO5p1fDEu4hxboH4n8Y8Dk e9wQ5h7uo3fHv43H7HliLw5sr9CACR/iWW4A5n45oz/8JsE81CPmHfx/UEYrxiK55ITl ddkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature; bh=OVqTMuVn+mqdQt7MmLOLMJ+Zf6M1un1MsCf6ZmhvSSo=; b=dflfXJyuoJ7Hsd47kFhLAOoCrbH7ETqiLQXk498B2nNhR2EAsmDVVRFfN7eOtG9lH/ o0l814X+KaHa3EDSVr4Kk6fetQtAyiqk4JF+olcFytfa5YWhMoNJ4KTKNpHOrkTeFU79 cC9vTKciervr1m976ZoOvhbmsyfTnebWrzDXxclcxeN+x2S62Bz6n0QWUXNlQ9OFOfAV scb/OgbZ9CKacL5j95tzQv6IVFXsQFuXg502+CiPzLiYcOzoOLCo9z950TvNDW0HjVhE lAnLcSD9CDlS3TDxYcpYG04upjeowmnICekm2VMTY8zGUe4773EQ+kRyURe9BuM/GLhD fF+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=kT2sRsBR; dkim=pass header.i=@codeaurora.org header.s=default header.b=kT2sRsBR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j24si7685250pgh.287.2019.08.14.00.44.31; Wed, 14 Aug 2019 00:45:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=kT2sRsBR; dkim=pass header.i=@codeaurora.org header.s=default header.b=kT2sRsBR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727154AbfHNHnT (ORCPT + 99 others); Wed, 14 Aug 2019 03:43:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60608 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbfHNHnT (ORCPT ); Wed, 14 Aug 2019 03:43:19 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8066A607DE; Wed, 14 Aug 2019 07:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565768598; bh=SNdKX9aeCldaAT6R793W5ewPrb6x1ertjSoz3YWnHCE=; h=From:To:Cc:Subject:Date:From; b=kT2sRsBRlbWw9Gpw8yrjU1DnTIddArYInKnmJO1RysRZ37oF2CcIkxxGRbm387AIl W35vTvacAIB0i7qeaIfi3OkAssRJO1QkmF/KQywhtH7Cpnm9Jx51cWd/vEPHOr2k0C S4nVRsCGJ2ppWP93jlyWweqgoLyGSMeptw+7a2oQ= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from rocky-HP-EliteBook-8460p.qca.qualcomm.com (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rjliao@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 72276602E0; Wed, 14 Aug 2019 07:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565768598; bh=SNdKX9aeCldaAT6R793W5ewPrb6x1ertjSoz3YWnHCE=; h=From:To:Cc:Subject:Date:From; b=kT2sRsBRlbWw9Gpw8yrjU1DnTIddArYInKnmJO1RysRZ37oF2CcIkxxGRbm387AIl W35vTvacAIB0i7qeaIfi3OkAssRJO1QkmF/KQywhtH7Cpnm9Jx51cWd/vEPHOr2k0C S4nVRsCGJ2ppWP93jlyWweqgoLyGSMeptw+7a2oQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 72276602E0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=rjliao@codeaurora.org From: Rocky Liao To: marcel@holtmann.org, johan.hedberg@gmail.com Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, Rocky Liao Subject: [PATCH v1] Bluetooth: hci_qca: Skip 1 error print in device_want_to_sleep() Date: Wed, 14 Aug 2019 15:42:39 +0800 Message-Id: <1565768559-30755-1-git-send-email-rjliao@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't fall through to print error message when receive sleep indication in HCI_IBS_RX_ASLEEP state, this is allowed behavior. Signed-off-by: Rocky Liao --- drivers/bluetooth/hci_qca.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index a054210..2affb4e 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -686,7 +686,7 @@ static void device_want_to_sleep(struct hci_uart *hu) unsigned long flags; struct qca_data *qca = hu->priv; - BT_DBG("hu %p want to sleep", hu); + BT_DBG("hu %p want to sleep in %d state", hu, qca->rx_ibs_state); spin_lock_irqsave(&qca->hci_ibs_lock, flags); @@ -701,7 +701,7 @@ static void device_want_to_sleep(struct hci_uart *hu) break; case HCI_IBS_RX_ASLEEP: - /* Fall through */ + break; default: /* Any other state is illegal */ -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project