Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp518131ybl; Wed, 14 Aug 2019 01:33:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVjkVy0uUyuNEU7jRlkyD386kGwH2bkl7JLcRaiLleEBn/Pj3mHenR/MuKOLr5To+UNoeM X-Received: by 2002:a63:d84e:: with SMTP id k14mr38025106pgj.234.1565771635453; Wed, 14 Aug 2019 01:33:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565771635; cv=none; d=google.com; s=arc-20160816; b=uNO8hTN3Av12jSyH3pyIQOPUW8xe6iELyzG81ZjF+LkHKtzoTWaLMSvhaZPtSxTWFL jJ36Mh9Wd0ggd9CCBBULAAJ9g7cgGaCjxFsQ5LX9aLtabc0nKF4QvO63W6KoX+1wA/XC ftWI7VHuDAGtspQpAutE/V2TtSVrbxlBw4UExxkKfA6fyG0zyVX2LoqbC8t4OsU20JJU LdAJch2Vd0WMtUkgBf3zt7JM6Jxw1XxHq1CzMDpt5QMVdtoNQ0AH6wPdCbTw/GgbdPf8 l5MEM8+FVKBgtC3zlSiJkW13XK5wdoe+TUa4xe6BFyWQTCVwRcp4mNfgKUTgAQrtDS2E GrGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Qprk97I1dFe+WA8kDtJTqkPzn2PSILy5kREIC5Uixm4=; b=svvUaDLJXlLvB5BUoOb1nJbJlHwLs4SGePCY0iy21VuwVGonfYBWz+be7xfr3x/ekE K6AGFwtz6betJgDKs8A0Y6bzKaKc/w98KbXZfs+q/M00p8wbYup73TCl1MpEOpGMWGhj TJtrqSUv/jIK8zNiV4jBTPmyUkwHXrB16+vCkmO6N7PWoUppari22zxPpG2ttQ392zbC ii7UdspWBxZJjM1wgUifd286FRjqpD1UiEf/oUSYuP6qbdW17d+FCyYxoLImrUYmoydj eAzpiQWnc1ESVwxn0r3w6aDCC1Fh91/Z3YcohyRMkuioD2FRjol7z2fDOKLbLqaEjlLs O6kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qMdw+xMV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6si71432400pfi.240.2019.08.14.01.33.38; Wed, 14 Aug 2019 01:33:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qMdw+xMV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727200AbfHNIcl (ORCPT + 99 others); Wed, 14 Aug 2019 04:32:41 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:42491 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbfHNIcl (ORCPT ); Wed, 14 Aug 2019 04:32:41 -0400 Received: by mail-lj1-f196.google.com with SMTP id l14so1348981ljj.9 for ; Wed, 14 Aug 2019 01:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qprk97I1dFe+WA8kDtJTqkPzn2PSILy5kREIC5Uixm4=; b=qMdw+xMV024LAbvccUI3jC70aaEEO5YWomLZhuABCdzO2cL+7TrxzWBaQItupTGIe5 V5iI287R6yEzuK4400Xf11LNmZT5SP6D3BpwXIiP0REHYCp8lEccJQsiTnSQK7+qJw5c Adf6kT0NahAxCaB61a4PDzWh0bZsvpdye0vrJeeZ3SE9yW+n4tXTOd0BO1uq9rjGvYuB 5Nnv5m31Aj9HkD49sGMjQwz//29/ywzsTipoA+S2vbv/e5ERHrl6TQtuGZhTkqDX2q/6 Bt86uvuXeQ6/przYNgkxiJfzspWLBBF/cOGwWI6Nx23yadkF0Xae3G66sAVLnvA6hs3F KrJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qprk97I1dFe+WA8kDtJTqkPzn2PSILy5kREIC5Uixm4=; b=NhpWDt60NqzsFGqGNRLkKMblDaji80kSUAECk09ZeIKv1gaZSwzGWvjmjcIE/ZLx/M ffYihIkVKvVEr10rrxunGgY1swaADecvZYpKuCZOla/bdCF8w6BDZSZsycVZS/NI2X31 AvIKehE9GjLJ/q+sTa+Bz1p9K4FKry0Y3zSCqOj2J5jlH/XKf6yEqqAA/c1pTQpfgj0d gKQg5wDM2hQB1zMmdYsJgKcBjYkXabJnyhFwfgFbj65qsEpgfOLYie4g18K2AqpDdJgW HYZgq1vh9pkaj5HGHcFfCFMM1lyI8nVgBiCOaX5zdTdLQ5UlY5uCKtPJ+c5lcHMZHqyK WbeA== X-Gm-Message-State: APjAAAXLaGORNTbKhZoqfvszsk0peBOvqeyMhRzri16wevxE06Kv4Pn2 VuCsLqy0bTOyOemcO676YRKtvH/G050VxjH6FlnN8A== X-Received: by 2002:a2e:9f0f:: with SMTP id u15mr14722764ljk.54.1565771559322; Wed, 14 Aug 2019 01:32:39 -0700 (PDT) MIME-Version: 1.0 References: <1565308020-31952-1-git-send-email-skomatineni@nvidia.com> <1565308020-31952-2-git-send-email-skomatineni@nvidia.com> In-Reply-To: <1565308020-31952-2-git-send-email-skomatineni@nvidia.com> From: Linus Walleij Date: Wed, 14 Aug 2019 10:32:28 +0200 Message-ID: Subject: Re: [PATCH v8 01/21] pinctrl: tegra: Fix write barrier placement in pmx_writel To: Sowjanya Komatineni Cc: "thierry.reding@gmail.com" , Jon Hunter , Thomas Gleixner , Jason Cooper , Marc Zyngier , Stefan Agner , Mark Rutland , Peter De Schrijver , Prashant Gaikwad , Stephen Boyd , linux-clk , "open list:GPIO SUBSYSTEM" , jckuo@nvidia.com, Joseph Lo , talho@nvidia.com, linux-tegra@vger.kernel.org, "linux-kernel@vger.kernel.org" , Mikko Perttunen , spatra@nvidia.com, Rob Herring , Dmitry Osipenko , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "Rafael J. Wysocki" , viresh kumar , Linux PM list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 9, 2019 at 1:47 AM Sowjanya Komatineni wrote: > pmx_writel uses writel which inserts write barrier before the > register write rather. > > This patch has fix to replace writel with writel_relaxed followed > by a write barrier to ensure write operation before the barrier > is completed for successful pinctrl change. > > Signed-off-by: Sowjanya Komatineni Patch applied with the ACKs. Yours, Linus Walleij