Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932123AbVLNRRZ (ORCPT ); Wed, 14 Dec 2005 12:17:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751297AbVLNRRZ (ORCPT ); Wed, 14 Dec 2005 12:17:25 -0500 Received: from mtagate3.de.ibm.com ([195.212.29.152]:52923 "EHLO mtagate3.de.ibm.com") by vger.kernel.org with ESMTP id S1750786AbVLNRRY (ORCPT ); Wed, 14 Dec 2005 12:17:24 -0500 Date: Wed, 14 Dec 2005 18:17:14 +0100 From: Heiko Carstens To: Martin Peschke Cc: Matthew Wilcox , Andreas Herrmann , linux-kernel@vger.kernel.org, akpm@osdl.org, linux-scsi@vger.kernel.org Subject: Re: [patch 6/6] statistics infrastructure - exploitation: zfcp Message-ID: <20051214171714.GA11415@osiris.boeblingen.de.ibm.com> References: <43A044E6.7060403@de.ibm.com> <20051214162437.GW9286@parisc-linux.org> <43A04E73.2020808@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43A04E73.2020808@de.ibm.com> User-Agent: mutt-ng/devel (Linux) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 22 > >> if (device_register(&unit->sysfs_device)) { > >>+ zfcp_unit_statistic_unregister(unit); > >> kfree(unit); > >> return NULL; > >> } > >> if (zfcp_sysfs_unit_create_files(&unit->sysfs_device)) { > >>+ zfcp_unit_statistic_unregister(unit); > >> device_unregister(&unit->sysfs_device); > >> return NULL; > >> } > >Unrelated, but doesn't that error path forget to release unit? > > correct, I guess ... Andreas, could you fix this? The release function frees the unit. Nothing to fix here. Heiko - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/