Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 14 Aug 2019 11:01:15 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Ben Whitten <ben.whitten@gmail.com>
Cc:     linux-kernel@vger.kernel.org, afaerber@suse.de,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] regmap: fix writes to non incrementing registers
Message-ID: <20190814100115.GF4640@sirena.co.uk>
References: <20190813212251.12316-1-ben.whitten@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xaMk4Io5JJdpkLEb"
Content-Disposition: inline
In-Reply-To: <20190813212251.12316-1-ben.whitten@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--xaMk4Io5JJdpkLEb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 13, 2019 at 10:22:51PM +0100, Ben Whitten wrote:

> @@ -1489,10 +1489,11 @@ static int _regmap_raw_write_impl(struct regmap *=
map, unsigned int reg,
>  	WARN_ON(!map->bus);
> =20
>  	/* Check for unwritable registers before we start */
> -	for (i =3D 0; i < val_len / map->format.val_bytes; i++)
> -		if (!regmap_writeable(map,
> -				     reg + regmap_get_offset(map, i)))
> -			return -EINVAL;
> +	if (!regmap_writeable_noinc(map, reg))
> +		for (i =3D 0; i < val_len / map->format.val_bytes; i++)
> +			if (!regmap_writeable(map,
> +					     reg + regmap_get_offset(map, i)))
> +				return -EINVAL;

This feels like we're getting ourselves confused about nonincrementing
registers and probably have other breakage somewhere else - we're
already checking for nonincrementability in regmap_write_noinc(), and
here we're only checking if the first register in the block has that
property which might blow up on us if there's a register in the middle
of the block that is nonincrementable.  If we're going to check this
here I think we should check on every register, but this is
_raw_write_impl() which is part of the call path for implementing
regmap_noinc_write() so checking here will break the API purpose
designed for nonincrementing writes.

--xaMk4Io5JJdpkLEb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1T2+sACgkQJNaLcl1U
h9DiCAf+NkGrG44e6bBSmbdGlvwEH+uWw3YNmF8ZBR0BQ2PEj+JHd0Pmg+7mrtmi
SYF2DD/vUbZkALAWQWlo+/+bK96VutNUbuo1poKUEPbZt2f949bWi8XOCBkWRpgw
N0t8BbhjqSqv9eMtYdqukU8sXg3Jjwtp1ctnU/R/Y5sXGIBYaZnvrTUFPaJh42av
kyjurYlhXMIgwL25RTwwAoQelR7izDuktSg7f6J87OtUFJTSfdBzKvMgDcNo0k/a
68SvK7TpClIQyI3GJ0diwc8RUp7fAtS+9eStBdKRURFirPqqoyQF/QDa57PThX7y
NLciOVJy82hAyaJCQGgIM44v3iT5AQ==
=dgtC
-----END PGP SIGNATURE-----

--xaMk4Io5JJdpkLEb--