Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp609433ybl; Wed, 14 Aug 2019 03:15:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqx747vWkA8Ow7DbGIM8WDupOkK3/Av2J+49I6C4a1ldnmeVEsPbZnZlVjBLu9Q+O0Qw6wLn X-Received: by 2002:aa7:8a99:: with SMTP id a25mr45992580pfc.127.1565777702671; Wed, 14 Aug 2019 03:15:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565777702; cv=none; d=google.com; s=arc-20160816; b=fJz3o4ptDkgZKOTKvGL2RYGWzMi9aMnqu3WiJc/WqOcDuHPS0/hphPhUrvQAmCRrTJ DOcgi8qVwGtP3kYzHIiXNOSOMO0bB7DfH66E1BmGfH4JVKokkETwkdo3mNh+GvIK127g uCHzjZI9YabirqwUdtiEwijLP+RZDertW8YVJmEMIzATNnn04Vpxt248CgKelxyhVnRF JRt+Sq5PSoQhL4ZT3imZ13EbzKQsXbUcvfwP1eXwkq1Rq60CMz8Kq+svRP5DllfWfxZw gx/WwY6pw1zSFc/gai3C+xMRIrdMQ6R3pzxaaZ7Rhe+Y7KiIppYnsrgv0U4GBrJXaY7t A8Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=uQBeUL2DjgYlSzEfwzXGJbhK14qEWYi6u/s7m+dzfyY=; b=v3goCdW7xqg1wMX8dFyz7J2Z3EGioqgc+Y4hjMu6v9qdx8JT2xHlW0VGZPTTH1YRh0 t34nQYSf6bqtj/gy9NUCd+UKHofLSc8/a7ZHWn06Uiol1XFHUq/4hZUA/iwiprD6KU6t e3FkSCrgUiDliGaR8FJc3LRc6QwFe2J1mzhh4U3fwxk361VVqyNWC2jafhVJOp2JYPLo 2/ucAqKgl2NaM1Drtx06ufNrGHsCgeXJBUnzUgB4fJ/y7pDnjpFXqumv6paOFJjtSxUa Cjx2g+oFO2cM0b0CQfEQfSM3NLbXAfo+ynGuYVyTgTC1q8YR2E8lqiZO7DgomRQ5piwI b1sA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11si3418706pfj.59.2019.08.14.03.14.46; Wed, 14 Aug 2019 03:15:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfHNKOM (ORCPT + 99 others); Wed, 14 Aug 2019 06:14:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49766 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726019AbfHNKOM (ORCPT ); Wed, 14 Aug 2019 06:14:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 498122F366E; Wed, 14 Aug 2019 10:14:12 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-144.ams2.redhat.com [10.36.116.144]) by smtp.corp.redhat.com (Postfix) with ESMTP id 00501808DD; Wed, 14 Aug 2019 10:14:11 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 2A5FD9D42; Wed, 14 Aug 2019 12:14:11 +0200 (CEST) Date: Wed, 14 Aug 2019 12:14:11 +0200 From: Gerd Hoffmann To: Thierry Reding Cc: Ben Skeggs , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-graphics-maintainer@vmware.com, intel-gfx@lists.freedesktop.org, spice-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node Message-ID: <20190814101411.lj3p6zjzbjvnnjf4@sirius.home.kraxel.org> References: <20190805140119.7337-1-kraxel@redhat.com> <20190805140119.7337-9-kraxel@redhat.com> <20190813151115.GA29955@ulmo> <20190814055827.6hrxj6daovxxnnvw@sirius.home.kraxel.org> <20190814093524.GA31345@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814093524.GA31345@ulmo> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 14 Aug 2019 10:14:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > Changing the order doesn't look hard. Patch attached (untested, have no > > test hardware). But maybe I missed some detail ... > > I came up with something very similar by splitting up nouveau_bo_new() > into allocation and initialization steps, so that when necessary the GEM > object can be initialized in between. I think that's slightly more > flexible and easier to understand than a boolean flag. Yes, that should work too. Acked-by: Gerd Hoffmann cheers, Gerd