Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp641181ybl; Wed, 14 Aug 2019 03:48:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8H7q6PkncvW3nX5Sm8m1JOEeOKwrc9J1x+q9ZMN0t+DRsiLibYJ8YoR08rbu83RybMKRL X-Received: by 2002:a65:614a:: with SMTP id o10mr37691296pgv.407.1565779709423; Wed, 14 Aug 2019 03:48:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565779709; cv=none; d=google.com; s=arc-20160816; b=RhCANifo0Edgkaq/GnjfBXt7TmtwYi4vCJoWw5GUv/ejc17rK+rPODpfYaVuYbAnmN vwy3ZXbmhwhUaGW5tajpf3x1axdgD/8J146VqoWVtiQY215V6KxdfTsr6FP63A6welEN a3Y7KPRLuFAQhkntmInAUufbNwninzsLPl8AHyJXeuwd/no4zIwR6oKWJyFBRYcWFECN GMEerPoH7LB+zOuCZRmprIoFd3T+HJbxyF9GrbJWjAy5/wnq4ed204zpUAZO7gy8t5/f 2EzWjog8kbM2Z0rxatfpGx+LMPcVr5QviV6LQkmBmQvMu4R+egYkuX6Y2cnG1Sxc76wL huBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:references :mime-version:message-id:in-reply-to:date:dkim-signature; bh=8XQAtQU5Jlu+LsGTeIXfkeaCQsZPIsgrkBYJbMGoesk=; b=fNDt3XA+gHupW95K+nueEYt0LVXhaa89yVWIw1GlQDZGPJoQ5Z+BD3AeyPC+Ikw/Gm LmEK08ucsGrcIHQ4GTUJjU2p1dbDrLujyiwEkYallXokE2uwtrE6cZJZFrIQMV5DUePR dF7BGnwCr4F+bIVhBqlWDWq9bOr8imPUX/H0BXkoPU5W3UPIeRDBt/kdCLJXEWyzlaos tJW6h6lVhdTRlap1HFTjyjMBxU3yz3NIkdmzHAkFcqv4TjWt5eUGZzlmdXO/LVoGkrX9 6kAl4ILlmhYneW1TcjjhAero7tVOelWDYSFdUTj47ZNeFhdVdghw0a1C8z5aLvdpY/q6 C2bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=wAGnbRj9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b20si42068405plz.327.2019.08.14.03.48.11; Wed, 14 Aug 2019 03:48:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=wAGnbRj9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727826AbfHNKpx (ORCPT + 99 others); Wed, 14 Aug 2019 06:45:53 -0400 Received: from mail-qt1-f201.google.com ([209.85.160.201]:42577 "EHLO mail-qt1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbfHNKpw (ORCPT ); Wed, 14 Aug 2019 06:45:52 -0400 Received: by mail-qt1-f201.google.com with SMTP id e22so37188527qtp.9 for ; Wed, 14 Aug 2019 03:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=8XQAtQU5Jlu+LsGTeIXfkeaCQsZPIsgrkBYJbMGoesk=; b=wAGnbRj9PtduDVibdtuPHio7e/rJAlCgqGevJw5McsZd2dItB2v8f3QDxCwHSu8HnM hUudYGzKO7cP39DlSJRj4tGIzVVVD7YI5T4VmE5kX9Ysovpeys+pbhVZL19mRvhyQd+8 VLquRzmzP4RRraDhLhZzueBc3kZpUJqwnpT6b3CROj2A6T+JhMWMJRGpUjKUox6rDt72 F111botUFvVQxo0CP38qO0gmkZYQiQLXbzFf6gL2kTKpae0HQtsskmb1ezaYubpNWNwX 5o8X9kKoMAeofuebkUCLBd1/FR6Cd1qGADTZ3sbk+bh6Qg+9HVOoW6nWSeNsHZJ8SYh1 pu9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=8XQAtQU5Jlu+LsGTeIXfkeaCQsZPIsgrkBYJbMGoesk=; b=QfEdwRNrM5Cd2ohL9EwXNnSkFJ/cRD7VWrvXUK3DTyJ9qogQxKZ1zoM24xDw7ICj4T 794L4UNmGYjACT5GYnFgBScM9qWx7YcTNZchEjiTSr8tmFCkZ1QXvZBgz9Y3W6bMzQCX a5RzmywCTC8dEMNIbk383bcKdp/glqpCtsoX/ogDb0g9bOjaZPMm0rzht8om6s1k7Acv 1e/zUzG1eW6IXM3PYwyri9j+vbxQv0CKFwS+ayFrg+zDP+UYDDwSVpQgKAK2/2TWrKoB ufc44maP+Z02KFydpbEi/7PksqvRJMZ9NnfjGCq/kI2jsYEH0bsWQ5Ba9czCLc7p2k+Q RUJw== X-Gm-Message-State: APjAAAWBX8CcNuJQkrosD2OdbkBeJ6pOUvUVdzfP3DcL3VxtOsnNYjKI CH7fhyxIgDxJdLHpvvEqsX+o3I3hklY= X-Received: by 2002:a05:6214:1254:: with SMTP id q20mr2062924qvv.164.1565779550564; Wed, 14 Aug 2019 03:45:50 -0700 (PDT) Date: Wed, 14 Aug 2019 12:45:01 +0200 In-Reply-To: <20190814104520.6001-1-darekm@google.com> Message-Id: <20190814104520.6001-4-darekm@google.com> Mime-Version: 1.0 References: <20190814104520.6001-1-darekm@google.com> X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog Subject: [PATCH v7 3/9] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register From: Dariusz Marcinkiewicz To: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, hverkuil-cisco@xs4all.nl Cc: Dariusz Marcinkiewicz , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Kate Stewart , Allison Randal , Greg Kroah-Hartman , Thomas Gleixner , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the new cec_notifier_cec_adap_(un)register() functions to (un)register the notifier for the CEC adapter. Also adds CEC_CAP_CONNECTOR_INFO capability to the adapter. Changes since v3: - add CEC_CAP_CONNECTOR_INFO to cec_allocate_adapter, - replace CEC_CAP_LOG_ADDRS | CEC_CAP_TRANSMIT | CEC_CAP_RC | CEC_CAP_PASSTHROUGH with CEC_CAP_DEFAULTS. Signed-off-by: Dariusz Marcinkiewicz Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c index 0f949978d3fcd..ac1e001d08829 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c @@ -256,8 +256,8 @@ static int dw_hdmi_cec_probe(struct platform_device *pdev) dw_hdmi_write(cec, 0, HDMI_CEC_POLARITY); cec->adap = cec_allocate_adapter(&dw_hdmi_cec_ops, cec, "dw_hdmi", - CEC_CAP_LOG_ADDRS | CEC_CAP_TRANSMIT | - CEC_CAP_RC | CEC_CAP_PASSTHROUGH, + CEC_CAP_DEFAULTS | + CEC_CAP_CONNECTOR_INFO, CEC_MAX_LOG_ADDRS); if (IS_ERR(cec->adap)) return PTR_ERR(cec->adap); @@ -278,13 +278,14 @@ static int dw_hdmi_cec_probe(struct platform_device *pdev) if (ret < 0) return ret; - cec->notify = cec_notifier_get(pdev->dev.parent); + cec->notify = cec_notifier_cec_adap_register(pdev->dev.parent, + NULL, cec->adap); if (!cec->notify) return -ENOMEM; ret = cec_register_adapter(cec->adap, pdev->dev.parent); if (ret < 0) { - cec_notifier_put(cec->notify); + cec_notifier_cec_adap_unregister(cec->notify); return ret; } @@ -294,8 +295,6 @@ static int dw_hdmi_cec_probe(struct platform_device *pdev) */ devm_remove_action(&pdev->dev, dw_hdmi_cec_del, cec); - cec_register_cec_notifier(cec->adap, cec->notify); - return 0; } @@ -303,8 +302,8 @@ static int dw_hdmi_cec_remove(struct platform_device *pdev) { struct dw_hdmi_cec *cec = platform_get_drvdata(pdev); + cec_notifier_cec_adap_unregister(cec->notify); cec_unregister_adapter(cec->adap); - cec_notifier_put(cec->notify); return 0; } -- 2.23.0.rc1.153.gdeed80330f-goog