Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp684500ybl; Wed, 14 Aug 2019 04:30:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRKw9OvSmjF60x9m8vKjKnZVGq2O1i67kWAI/eWOrDUmH0Woy0qQybWBhtjWHvE+YGTrLe X-Received: by 2002:a17:90a:aa98:: with SMTP id l24mr6692698pjq.64.1565782243265; Wed, 14 Aug 2019 04:30:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565782243; cv=none; d=google.com; s=arc-20160816; b=Qst3DsdiMimdpt1RM4mEW/HGrK+Ft/l11RXm3qz2ITxuBqLffZCOGqfHIKgc+mSLy2 TIxKciKeUItr66vILwXAIcooZPcWTfW/PPsZWFfOy8XLYFiYCcKbQ7jxizCmhDFW4Llm MG2lLxV3coIx225egpchqD/tX7RVzmX7Y8BM1G75umojsi2aTFB2n7KTU/e09Zwo6VNG 6cqTrsdtczecwHUG9DgLMg91nPSyk3IizG3BNeLoGkmfbzsxm53DarFDoewDDzSP6uOC pjTyzy/pu8ICpz7l1joR2siyn3DAffZfZSQTIJsktmT7Tuubsqagcy4QdamhWO17OA+y Q7DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject:reply-to; bh=G7h9ZPs2SsF+ym2u1QKjCUIVuuVN1JS6MMNQMwIhLCM=; b=qXC14qxTE648iKnUfcVEwlZtRAa8MlUD0xTD2sESCWdnih9Xq/RQyjyb7SHx+rAvKU X4B0Q9YInzlJXWgWq/RlY4dR5xLTmRrM2ukd15eM57ZaRW8doHQFtNueS5PtqoOpj4VC SONnBewlyt9fU8Cxvc3R5dyL0SLxzsRQnNbeQm+Uah93mzydYGVlkgTZyWQmgKKZf47S wqKiuB0X4WteBUdW1MX84nsQetX9qww6+zf/8EBR7itQr4bn5jZQbIIlFdTLBpwDRTv1 xYoKMsLiAtNTYw08Gc990pxI98n/sEDRH4DFXjg76CUOEfWxOeiKjxm6E0ZUg06CVvxn t8+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c136si8816643pfb.13.2019.08.14.04.30.27; Wed, 14 Aug 2019 04:30:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727157AbfHNL3Z (ORCPT + 99 others); Wed, 14 Aug 2019 07:29:25 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:44723 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbfHNL3Y (ORCPT ); Wed, 14 Aug 2019 07:29:24 -0400 Received: by mail-lj1-f196.google.com with SMTP id e24so7757570ljg.11 for ; Wed, 14 Aug 2019 04:29:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=G7h9ZPs2SsF+ym2u1QKjCUIVuuVN1JS6MMNQMwIhLCM=; b=gZtysKbdZCZusq1uTun3u2iYwLAyaXENCWAYlAN7/diFXMW68DPJP9jjU2AAzxuGOk 73xJSX8Jazn1KFO+ce9EHBDaGWK0WAXwuh5q7HT6+AZjq8hAYDaaoz0M/ajsEsa+oEFt pk5RSwqpQrJn174aHK3fnLTDPdEKFiNztQkfcM5XZmGwlUm7CJmZOzuGOsKrFuIG/K9E 2sEdnUghP1SOu6rKxrrtoA3a3Tp1VDV1VWOSfyAYs+o0enzpFwFvldNfhEeKeW9Yl8by xQI3hPsgm7RuqFQ+Hn3PawXZQ4w00sGBmIWUG56/wbsd5JiPp4o6Uh2kpjz4rdobFNzL UsmQ== X-Gm-Message-State: APjAAAXqB8b+vO2dC9CyAKsoq73GtmeS4GwCzRPCV8qmCE8GXWSQO4tt O65Xt7yPSe8+epyEls11yKUay2m5 X-Received: by 2002:a2e:760f:: with SMTP id r15mr10438042ljc.92.1565782161565; Wed, 14 Aug 2019 04:29:21 -0700 (PDT) Received: from [192.168.42.130] ([213.87.138.18]) by smtp.gmail.com with ESMTPSA id i9sm20206108lfl.10.2019.08.14.04.29.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 04:29:20 -0700 (PDT) Reply-To: alex.popov@linux.com Subject: Re: [PATCH] Documentation patch (gcc-plugins kernel) To: Kees Cook , Robin Lindner Cc: re.emese@gmail.com, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org References: <201908011311.A06FB03C6C@keescook> From: Alexander Popov Openpgp: preference=signencrypt Autocrypt: addr=alex.popov@linux.com; prefer-encrypt=mutual; keydata= mQINBFX15q4BEADZartsIW3sQ9R+9TOuCFRIW+RDCoBWNHhqDLu+Tzf2mZevVSF0D5AMJW4f UB1QigxOuGIeSngfmgLspdYe2Kl8+P8qyfrnBcS4hLFyLGjaP7UVGtpUl7CUxz2Hct3yhsPz ID/rnCSd0Q+3thrJTq44b2kIKqM1swt/F2Er5Bl0B4o5WKx4J9k6Dz7bAMjKD8pHZJnScoP4 dzKPhrytN/iWM01eRZRc1TcIdVsRZC3hcVE6OtFoamaYmePDwWTRhmDtWYngbRDVGe3Tl8bT 7BYN7gv7Ikt7Nq2T2TOfXEQqr9CtidxBNsqFEaajbFvpLDpUPw692+4lUbQ7FL0B1WYLvWkG cVysClEyX3VBSMzIG5eTF0Dng9RqItUxpbD317ihKqYL95jk6eK6XyI8wVOCEa1V3MhtvzUo WGZVkwm9eMVZ05GbhzmT7KHBEBbCkihS+TpVxOgzvuV+heCEaaxIDWY/k8u4tgbrVVk+tIVG 99v1//kNLqd5KuwY1Y2/h2MhRrfxqGz+l/f/qghKh+1iptm6McN//1nNaIbzXQ2Ej34jeWDa xAN1C1OANOyV7mYuYPNDl5c9QrbcNGg3D6gOeGeGiMn11NjbjHae3ipH8MkX7/k8pH5q4Lhh Ra0vtJspeg77CS4b7+WC5jlK3UAKoUja3kGgkCrnfNkvKjrkEwARAQABtCZBbGV4YW5kZXIg UG9wb3YgPGFsZXgucG9wb3ZAbGludXguY29tPokCQAQTAQoAKgIbIwIeAQIXgAULCQgHAwUV CgkICwUWAgMBAAUJB8+UXAUCWgsUegIZAQAKCRCODp3rvH6PqqpOEACX+tXHOgMJ6fGxaNJZ HkKRFR/9AGP1bxp5QS528Sd6w17bMMQ87V5NSFUsTMPMcbIoO73DganKQ3nN6tW0ZvDTKpRt pBUCUP8KPqNvoSs3kkskaQgNQ3FXv46YqPZ7DoYj9HevY9NUyGLwCTEWD2ER5zKuNbI2ek82 j4rwdqXn9kqqBf1ExAoEsszeNHzTKRl2d+bXuGDcOdpnOi7avoQfwi/O0oapR+goxz49Oeov YFf1EVaogHjDBREaqiqJ0MSKexfVBt8RD9ev9SGSIMcwfhgUHhMTX2JY/+6BXnUbzVcHD6HR EgqVGn/0RXfJIYmFsjH0Z6cHy34Vn+aqcGa8faztPnmkA/vNfhw8k5fEE7VlBqdEY8YeOiza hHdpaUi4GofNy/GoHIqpz16UulMjGB5SBzgsYKgCO+faNBrCcBrscWTl1aJfSNJvImuS1JhB EQnl/MIegxyBBRsH68x5BCffERo4FjaG0NDCmZLjXPOgMvl3vRywHLdDZThjAea3pwdGUq+W C77i7tnnUqgK7P9i+nEKwNWZfLpfjYgH5JE/jOgMf4tpHvO6fu4AnOffdz3kOxDyi+zFLVcz rTP5b46aVjI7D0dIDTIaCKUT+PfsLnJmP18x7dU/gR/XDcUaSEbWU3D9u61AvxP47g7tN5+a 5pFIJhJ44JLk6I5H/bkCDQRV9eauARAArcUVf6RdT14hkm0zT5TPc/3BJc6PyAghV/iCoPm8 kbzjKBIK80NvGodDeUV0MnQbX40jjFdSI0m96HNt86FtifQ3nwuW/BtS8dk8+lakRVwuTgMb hJWmXqKMFdVRCbjdyLbZWpdPip0WGND6p5i801xgPRmI8P6e5e4jBO4Cx1ToIFyJOzD/jvtb UhH9t5/naKUGa5BD9gSkguooXVOFvPdvKQKca19S7bb9hzjySh63H4qlbhUrG/7JGhX+Lr3g DwuAGrrFIV0FaVyIPGZ8U2fjLKpcBC7/lZJv0jRFpZ9CjHefILxt7NGxPB9hk2iDt2tE6jSl GNeloDYJUVItFmG+/giza2KrXmDEFKl+/mwfjRI/+PHR8PscWiB7S1zhsVus3DxhbM2mAK4x mmH4k0wNfgClh0Srw9zCU2CKJ6YcuRLi/RAAiyoxBb9wnSuQS5KkxoT32LRNwfyMdwlEtQGp WtC/vBI13XJVabx0Oalx7NtvRCcX1FX9rnKVjSFHX5YJ48heAd0dwRVmzOGL/EGywb1b9Q3O IWe9EFF8tmWV/JHs2thMz492qTHA5pm5JUsHQuZGBhBU+GqdOkdkFvujcNu4w7WyuEITBFAh 5qDiGkvY9FU1OH0fWQqVU/5LHNizzIYN2KjU6529b0VTVGb4e/M0HglwtlWpkpfQzHMAEQEA AYkCJQQYAQIADwUCVfXmrgIbDAUJCWYBgAAKCRCODp3rvH6PqrZtEACKsd/UUtpKmy4mrZwl 053nWp7+WCE+S9ke7CFytmXoMWf1CIrcQTk5cmdBmB4E0l3sr/DgKlJ8UrHTdRLcZZnbVqur +fnmVeQy9lqGkaIZvx/iXVYUqhT3+DNj9Zkjrynbe5pLsrGyxYWfsPRVL6J4mQatChadjuLw 7/WC6PBmWkRA2SxUVpxFEZlirpbboYWLSXk9I3JmS5/iJ+P5kHYiB0YqYkd1twFXXxixv1GB Zi/idvWTK7x6/bUh0AAGTKc5zFhyR4DJRGROGlFTAYM3WDoa9XbrHXsggJDLNoPZJTj9DMww u28SzHLvR3t2pY1dT61jzKNDLoE3pjvzgLKF/Olif0t7+m0IPKY+8umZvUEhJ9CAUcoFPCfG tEbL6t1xrcsT7dsUhZpkIX0Qc77op8GHlfNd/N6wZUt19Vn9G8B6xrH+dinc0ylUc4+4yxt6 6BsiEzma6Ah5jexChYIwaB5Oi21yjc6bBb4l6z01WWJQ052OGaOBzi+tS5iGmc5DWH4/pFqX OIkgJVVgjPv2y41qV66QJJEi2wT4WUKLY1zA9s6KXbt8dVSzJsNFvsrAoFdtzc8v6uqCo0/W f0Id8MBKoqN5FniTHWNxYX6b2dFwq8i5Rh6Oxc6q75Kg8279+co3/tLCkU6pGga28K7tUP2z h9AUWENlnWJX/YhP8IkCJQQYAQoADwIbDAUCWgsSOgUJB9eShwAKCRCODp3rvH6PqtoND/41 ozCKAS4WWBBCU6AYLm2SoJ0EGhg1kIf9VMiqy5PKlSrAnW5yl4WJQcv5wER/7EzvZ49Gj8aG uRWfz3lyQU8dH2KG6KLilDFCZF0mViEo2C7O4QUx5xmbpMUq41fWjY947Xvd3QDisc1T1/7G uNBAALEZdqzwnKsT9G27e9Cd3AW3KsLAD4MhsALFARg6OuuwDCbLl6k5fu++26PEqORGtpJQ rRBWan9ZWb/Y57P126IVIylWiH6vt6iEPlaEHBU8H9+Z0WF6wJ5rNz9gR6GhZhmo1qsyNedD 1HzOsXQhvCinsErpZs99VdZSF3d54dac8ypH4hvbjSmXZjY3Sblhyc6RLYlru5UXJFh7Hy+E TMuCg3hIVbdyFSDkvxVlvhHgUSf8+Uk3Ya4MO4a5l9ElUqxpSqYH7CvuwkG+mH5mN8tK3CCd +aKPCxUFfil62DfTa7YgLovr7sHQB+VMQkNDPXleC+amNqJb423L8M2sfCi9gw/lA1ha6q80 ydgbcFEkNjqz4OtbrSwEHMy/ADsUWksYuzVbw7/pQTc6OAskESBr5igP7B/rIACUgiIjdOVB ktD1IQcezrDcuzVCIpuq8zC6LwLm7V1Tr6zfU9FWwnqzoQeQZH4QlP7MBuOeswCpxIl07mz9 jXz/74kjFsyRgZA+d6a1pGtOwITEBxtxxg== Message-ID: <9d1a86e8-0997-54ba-d3b9-58cc92af3a1f@linux.com> Date: Wed, 14 Aug 2019 14:29:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <201908011311.A06FB03C6C@keescook> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Kees and Robin, On 01.08.2019 23:14, Kees Cook wrote: > On Thu, Aug 01, 2019 at 09:30:58AM +0200, Robin Lindner wrote: >> Cleaned documentation comment up. I removed the "TODO" because it was very old. >> --- >> scripts/gcc-plugins/stackleak_plugin.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/scripts/gcc-plugins/stackleak_plugin.c b/scripts/gcc-plugins/stackleak_plugin.c >> index dbd37460c573e..d8ba12c3bb238 100644 >> --- a/scripts/gcc-plugins/stackleak_plugin.c >> +++ b/scripts/gcc-plugins/stackleak_plugin.c >> @@ -144,8 +144,6 @@ static unsigned int stackleak_instrument_execute(void) >> * >> * Case in point: native_save_fl on amd64 when optimized for size >> * clobbers rdx if it were instrumented here. >> - * >> - * TODO: any more special cases? >> */ >> if (is_leaf && >> !TREE_PUBLIC(current_function_decl) && > > As to the content of the patch, let's also CC Alexander... > > Are there no more special cases? I don't know other special cases when we should avoid the instrumentation. And I can't imagine a method of finding such cases except runtime testing. Robin, I would better save this comment only removing "TODO" if it matters. Best regards, Alexander