Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: livepatch: add missing fragments to config
To:     Anders Roxell <anders.roxell@linaro.org>, shuah@kernel.org,
        pmladek@suse.com, mbenes@suse.cz, jikos@kernel.org,
        jpoimboe@redhat.com
Cc:     live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20190814111651.28433-1-anders.roxell@linaro.org>
From:   Joe Lawrence <joe.lawrence@redhat.com>
Message-ID: <e01a1182-d9cf-b2c2-78a9-35f60861e4a9@redhat.com>
Date:   Wed, 14 Aug 2019 09:20:49 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190814111651.28433-1-anders.roxell@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/14/19 7:16 AM, Anders Roxell wrote:
> When generating config with 'make defconfig kselftest-merge' fragment
> CONFIG_TEST_LIVEPATCH=m isn't set.
> 
> Rework to enable CONFIG_LIVEPATCH and CONFIG_DYNAMIC_DEBUG as well.
> 
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
>   tools/testing/selftests/livepatch/config | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/livepatch/config b/tools/testing/selftests/livepatch/config
> index 0dd7700464a8..ad23100cb27c 100644
> --- a/tools/testing/selftests/livepatch/config
> +++ b/tools/testing/selftests/livepatch/config
> @@ -1 +1,3 @@
> +CONFIG_LIVEPATCH=y
> +CONFIG_DYNAMIC_DEBUG=y
>   CONFIG_TEST_LIVEPATCH=m
> 

Cool, I didn't know about that make target when doing commit 
bae054372aba ("selftests/livepatch: add DYNAMIC_DEBUG config dependency")

How does kselftest-merge verify dependencies?

CONFIG_LIVEPATCH has its own list of configuration dependencies (see 
kernel/livepatch/Kconfig) but we don't list all of those in this config 
file.  Just curious.

Thanks,

-- Joe