From: David Brownell <david-b@pacbell.net>
To: Vitaly Wool <vwool@ru.mvista.com>
Subject: Re: [PATCH/RFC] SPI: add DMAUNSAFE analog
Date: Wed, 14 Dec 2005 11:17:10 -0800
User-Agent: KMail/1.7.1
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org,
       dpervushin@gmail.com, akpm@osdl.org, basicmark@yahoo.com,
       komal_shah802003@yahoo.com, stephen@streetfiresound.com,
       spi-devel-general@lists.sourceforge.net, Joachim_Jaeger@digi.com
References: <20051212182026.4e393d5a.vwool@ru.mvista.com> <200512140922.43877.david-b@pacbell.net> <43A05B58.4030009@ru.mvista.com>
In-Reply-To: <43A05B58.4030009@ru.mvista.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200512141117.11244.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2005
Lines: 49


> static inline ssize_t spi_w8r8(struct spi_device *spi, u8 cmd)
> {
>         ssize_t                 status;
>         u8                      result;
> 
>         status = spi_write_then_read(spi, &cmd, 1, &result, 1);
> 
>         /* return negative errno or unsigned value */
>         return (status < 0) ? status : result;
> }
> 
> You're allocating u8 var on stack, then allocate a 1-byte-long buffer 
> and copy the data instead of letting the controller driver decide 
> whether this allocation/copy is necessary or not.

Yeah, like that matters in the face of the overhead to queue
the message, get to the head of the SPI transfer queue, go
through that queue, then finally wake up the task that was
synchronously blocking in write_then_read().  Oh, and since
that's inlined, GCC may be re-using existing state...

If folk want an "it looks simple" convenient/friendly API,
there is always a price to pay.  In this case, that cost is
dwarfed by the mere fact that they're using a synchronous
model to access shared resources (the SPI controller).


> >>Then he starts messing with allocate-or-use-preallocated stuff etc. etc.
> >>Why isn't he just kmalloc'ing/kfree'ing buffers each time these 
> >>functions are called 
> >
> >So that the typical case, with little SPI contention, doesn't
> >hit the heap?  That's sure what I thought ... though I can't speak
> >for what other people may think I thought.  You were the one that
> >wanted to optimize the atypical case to remove a blocking path!
>  
> I meant kmalloc'ing/kfree'ing buffers is spi_w8r8/spi_w8r16/etc.

As I said:  so the _typical_ case doesn't hit the heap.   There are
inherent overheads for such RPC-style calls.  But there's also no
point in gratuitously increasing them.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/