Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1081796ybl; Wed, 14 Aug 2019 10:24:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqxCgeU4xMoXYVBcEjsAZiFETmVE1fx566bOT7kC7La9yadfW75riuXU6knrx+v6P51KWua7 X-Received: by 2002:a65:6294:: with SMTP id f20mr216836pgv.349.1565803440168; Wed, 14 Aug 2019 10:24:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565803440; cv=none; d=google.com; s=arc-20160816; b=g+CUi9/gDoL/4mfSMPcXPYXNgU9gJikjRLVWjyD55nyf7hxDRXvShPKLfy2RtsDMN+ 0FU1LcrAIUe6eddb6gMSXZAMW3ML2ldwaUB44vMYh000dVecPCM47VoP1ypPt8WHtKPA qoGMguPwM/tsJPlMJi3n4BdgpEEp1GOrG9ETojqvExro9Qf/k3EgR3TzkG4P6Ytno1wF C2RwkRj6kGvxFPvVDSgIFeTJIimWERQPZ9485FCs2/ewx4L7zy2QJ7qKhmoT0rjegdvF WwEwIyq21rU77t+8jf+5KQ12/X4JSeB/89r/LEZmPmIvlJlAMRyhA4yi/sCmsPEyQmN5 S9Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nihqYgM1hRzOwo7oVETXOcz095ijJVKLBhE1qb6EwuY=; b=JSqiLem3MsrXW3Vqj8EWKJvom+2DZDO3XmqB0qtD5LG1CXySKG0hxsfUnTivywI0cv OD4wmil0oI1rmOxAP7lHCYdctOWaOlzY8o7QfCaT4MsUMTO6IX4SMrA+XBF5+/vNqGHW 5JPq1YYiwLq4NWRHj+j6HRDItA/lQy3EvBLz60ysuYuArB0UJcsQJ6NKwpGrumWm1M7Z vlrMMlhje98tPS2h4+Oeu+cvZ0Yo+vKR8E6Se4748iJN9fatNwEYbdEHEUK2EZVMbSjS NZ36uDfsFmv57qdbsPMWtWMKA1C9nYahHGEE0pZ6GJ4oxZ5sACeEel3RNTJkwrY0SBWC BtZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x7351Hfp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i11si203387pgk.309.2019.08.14.10.23.44; Wed, 14 Aug 2019 10:24:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=x7351Hfp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730013AbfHNRH6 (ORCPT + 99 others); Wed, 14 Aug 2019 13:07:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:57674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729993AbfHNRHz (ORCPT ); Wed, 14 Aug 2019 13:07:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C12C521883; Wed, 14 Aug 2019 17:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802475; bh=VBjxKQbmEC3ejwzUV+O9gdG/YAAWgAXWkxhLYsFppDo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x7351Hfp8YBJXo2t7YgNqg1C7wrX8tvox/3YeGSIiCfdV2he2caZvzpoD2/ykO/3f /PaVLHfaS97qO+FBVKTqAWkhBftYr931bfduSlX8Oilppyv9UYveejvKhbaT4GY/7N n20L5JJLu2Uh7mmG6Pl0B0/rq4WTrND3uCjjnQcc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Emmanuel Grumbach , Johannes Berg Subject: [PATCH 5.2 140/144] iwlwifi: dont unmap as page memory that was mapped as single Date: Wed, 14 Aug 2019 19:01:36 +0200 Message-Id: <20190814165805.822748207@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814165759.466811854@linuxfoundation.org> References: <20190814165759.466811854@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Emmanuel Grumbach commit 87e7e25aee6b59fef740856f4e86d4b60496c9e1 upstream. In order to remember how to unmap a memory (as single or as page), we maintain a bit per Transmit Buffer (TBs) in the meta data (structure iwl_cmd_meta). We maintain a bitmap: 1 bit per TB. If the TB is set, we will free the memory as a page. This bitmap was never cleared. Fix this. Cc: stable@vger.kernel.org Fixes: 3cd1980b0cdf ("iwlwifi: pcie: introduce new tfd and tb formats") Signed-off-by: Emmanuel Grumbach Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/wireless/intel/iwlwifi/pcie/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/tx.c @@ -435,6 +435,8 @@ static void iwl_pcie_tfd_unmap(struct iw DMA_TO_DEVICE); } + meta->tbs = 0; + if (trans->cfg->use_tfh) { struct iwl_tfh_tfd *tfd_fh = (void *)tfd;