Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1161203ybl; Wed, 14 Aug 2019 11:45:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqyazVLxtBG0fJ0DQGnQa3jf9LHp2zheiiIUHtbokecVdyCVe3cd2vzUrccytktk9Ob4felT X-Received: by 2002:a17:90a:fa8e:: with SMTP id cu14mr1057799pjb.140.1565808313694; Wed, 14 Aug 2019 11:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565808313; cv=none; d=google.com; s=arc-20160816; b=zKY/PTATJosVicw0+g5c1zQsPA/4EYYFSLfKQI8jmv9eR1I78Mkk73KoHT7y3bzshL nFX015pSDaFfdDrn+NQrl0CZPWJKpbR+8ASRXpwDSry7foSEZWTgJgf+1ZkGTrDScFcy FpylpLlzUNQrg08E9E8ttL03gstW+dDeCIAdDCKq96gWv+2fxTRcvdxT3aNdovri6pD/ FyB+jG0ererZg2XJsvSP3YQer0J5UJUSCTOrvjyT7Bi3FkIZXQiO2OQunOxE1rE9Bb01 WvJbsAIth+MP0SEesCPD+26SmZiB/2uc1nK9VoDGuwtDW4LD9n+t7KTj83kxLADE0LXo Ak1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:dkim-signature; bh=ogTf0C7vEGLcQeFZFv8Efl6J1d0vvpCj4vlJxV70x7Y=; b=XN4GbV2otaCO87NZMcW6MJDw48Tt/p+v2Qc+Ef3aLdT1Pu2as3Z19TnSVAQWdx/aqd IkzULkjGPPMdH1O+2f/pahXog4VRbJcmL1JCyXr8HtIbudp2ZoZAibyyy9Ccs2iAGRiK 5Ccb68rTiHlqKhnshxeCnIYef3ZH8xb8SJAP3lhlx0O9ftMvLyVJwvii5tpbg6ci6tNU mqf4+J+id86asbiz8+WQfr1Q2t1iBPD9KoRAN4MucnlRSTqeG44SANWOzk+X9c2F1+SG ofGXZdZ3S5BzUuaM16WfDMbHezxyozE2sdv4hfS3o5Txo+qxHp1PNc1bPRt+T+O0fH2e s/dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=DINf0EIt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6si399999plr.52.2019.08.14.11.44.57; Wed, 14 Aug 2019 11:45:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=DINf0EIt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729253AbfHNSnh (ORCPT + 99 others); Wed, 14 Aug 2019 14:43:37 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:45808 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728334AbfHNSng (ORCPT ); Wed, 14 Aug 2019 14:43:36 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7EIcmGn136901; Wed, 14 Aug 2019 18:43:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : cc : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=ogTf0C7vEGLcQeFZFv8Efl6J1d0vvpCj4vlJxV70x7Y=; b=DINf0EIt8bJ66rb45YXVqckaWEBxqsKEBl8ld5JcS29HKKAFhCKRUtT9pOTNFJDCbTVZ Rl3yX5oSX4AScdMqI4HDYGaWJsySh1r7kcOgSGhkwCmf6TGIRj4fZNIwlUKD0205vVGO b8kHkCddDfoSAKGs+B3gh2lO0+yG/0sdnWsXswZOVyKkXBt7p6g2sppgdg3UA/CY2r/m GXwqrgbR1yMWabhD5LBLufxiUr8YdQxcHIc5u/13VTaJGPPq0K73Jo3cTqC4UB74Avn6 jsa7h1RKgxeseJUjgDB4RUeB3pZ6Q/NskI9TJ6a1SjcgTe4G1heZ0Z0LmbQ/nSY7wnXW 4w== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2u9pjqpfgj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Aug 2019 18:43:07 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7EIciNM043330; Wed, 14 Aug 2019 18:43:07 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2ubwrhkuf8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Aug 2019 18:43:06 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7EIh6hT008781; Wed, 14 Aug 2019 18:43:06 GMT Received: from aruna-dev.us.oracle.com (/10.211.44.177) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 14 Aug 2019 11:43:05 -0700 Subject: Re: [PATCH 2/5] tracing: Verify if trace array exists before destroying it. To: Divya Indi , Steven Rostedt , linux-kernel@vger.kernel.org References: <1565805327-579-1-git-send-email-divya.indi@oracle.com> <1565805327-579-3-git-send-email-divya.indi@oracle.com> Cc: Joe Jin , Srinivas Eeda From: Aruna Ramakrishna Message-ID: <090274c8-6e8c-2526-5515-dbd5cbc11093@oracle.com> Date: Wed, 14 Aug 2019 11:42:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1565805327-579-3-git-send-email-divya.indi@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9349 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=742 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908140165 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9349 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=812 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908140165 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/14/2019 10:55 AM, Divya Indi wrote: > A trace array can be destroyed from userspace or kernel. Verify if the > trace exists before proceeding to destroy/remove it. > ^^ s/trace/trace array/ As you pointed out yourself. :) All the patches look good to me. For this patchset: Reviewed-by: Aruna Ramakrishna Thanks, Aruna