Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1254576ybl; Wed, 14 Aug 2019 13:28:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqymTgj8u97iRn/BktKWjsYFH//8YQVjtMTy+yf/h6ClTurzR4jESzxjT4+xQv3WaIloItE1 X-Received: by 2002:a63:4a51:: with SMTP id j17mr816604pgl.284.1565814493786; Wed, 14 Aug 2019 13:28:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565814493; cv=none; d=google.com; s=arc-20160816; b=AM75sZd6Gc+eOcLCHN+tFrfKWjryZ4JB2kuUeUokvSG9oDPHk/bak1MhIo3BsyOXUO M6dNNifGiVWwvRLNZ955iCXy0ra/IzJBLB4I6otDE+6XUMvbuDQcItn6YV9HAALKPpFc AtolNJM3PwjSO+E0KEz3+F7EFr5ZDVuajCPmHZYpBM9UHllEr2/mgWYzXEkzOgZTOAxy rGEcNPLX+9IwyROudhIz9kQyPHkjg0vJsv/vRsGblQbP2tdlpK83TYIAVOGxTaoDHfKH wHq90fdxoh4dYd9mc4WnaopYMjtS2a2HPQChgmIErMAp5xFTzu/O9LyZL+EkEufjC4WW nqNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZXy7C0zXv4kya1X3Lecvl+XPpk3oUU/1JLfB5d8wCyM=; b=T7JJprie0D+gcoPvxAY5lT0L5sxWjAAUv7M6l56OTRZp+PZ/v+kATCfTgwaU4Qn4bK b6NG/9sZ9TRj4cvX1K1VOcYXzRByIIfK+lOChZC9vg64aqHTSwW61rpn1WlqcLe94IKo kUaHt63EqhEOqYaEwj512MMWLZZqWSoZm5OYaKjXJOk2N6gr1ifmtXNH2rzVFX+HSVqo I5oVSegcZQx6j/F4Abpcyy+mcG40IjwWEz66CBZNYUdXr3zgGn44faPRV2Jh3aPrJ3jC 73M8Dxk60hNb7Lstn5LtrZ1K1ni4lqzYcL3xHsFYveXY6FthF6VTtGnW1BbJQBfJoZFM W2+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u19si454495pgf.531.2019.08.14.13.27.58; Wed, 14 Aug 2019 13:28:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729621AbfHNU1U (ORCPT + 99 others); Wed, 14 Aug 2019 16:27:20 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:33645 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729595AbfHNU1U (ORCPT ); Wed, 14 Aug 2019 16:27:20 -0400 X-Originating-IP: 87.5.130.64 Received: from uno.homenet.telecomitalia.it (host64-130-dynamic.5-87-r.retail.telecomitalia.it [87.5.130.64]) (Authenticated sender: jacopo@jmondi.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 174B0FF803; Wed, 14 Aug 2019 20:27:16 +0000 (UTC) From: Jacopo Mondi To: Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Laurent Pinchart Cc: Jacopo Mondi , linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)), linux-kernel@vger.kernel.org (open list) Subject: [RFC 4/5] media: i2c: ov5670: Report the camera location Date: Wed, 14 Aug 2019 22:28:14 +0200 Message-Id: <20190814202815.32491-5-jacopo@jmondi.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814202815.32491-1-jacopo@jmondi.org> References: <20190814202815.32491-1-jacopo@jmondi.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The camera location is retrieved from the firmware interface parsing the "location" device property and reported through the read-only V4L2_CID_LOCATION control. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov5670.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c index 041fcbb4eebd..1446aef1fc1e 100644 --- a/drivers/media/i2c/ov5670.c +++ b/drivers/media/i2c/ov5670.c @@ -2059,10 +2059,12 @@ static const struct v4l2_ctrl_ops ov5670_ctrl_ops = { /* Initialize control handlers */ static int ov5670_init_controls(struct ov5670 *ov5670) { + struct i2c_client *client = v4l2_get_subdevdata(&ov5670->sd); struct v4l2_ctrl_handler *ctrl_hdlr; s64 vblank_max; s64 vblank_def; s64 vblank_min; + u32 location; s64 exposure_max; int ret; @@ -2124,6 +2126,15 @@ static int ov5670_init_controls(struct ov5670 *ov5670) ARRAY_SIZE(ov5670_test_pattern_menu) - 1, 0, 0, ov5670_test_pattern_menu); + ret = device_property_read_u32(&client->dev, "location", &location); + if (!ret) { + v4l2_ctrl_new_std(ctrl_hdlr, &ov5670_ctrl_ops, + V4L2_CID_LOCATION, V4L2_LOCATION_FRONT, + V4L2_LOCATION_BACK, 1, + location == V4L2_LOCATION_FRONT ? + V4L2_LOCATION_FRONT : V4L2_LOCATION_BACK); + } + if (ctrl_hdlr->error) { ret = ctrl_hdlr->error; goto error; -- 2.22.0