Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1342757ybl; Wed, 14 Aug 2019 15:18:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1/JuqPFB/88CWQENJl8jJ/UrCOJGghPDbW+h8cZCEuwGPCN3euWcujLDOOQ23nbmGsJnH X-Received: by 2002:a17:90b:8e:: with SMTP id bb14mr106033pjb.35.1565821080524; Wed, 14 Aug 2019 15:18:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565821080; cv=none; d=google.com; s=arc-20160816; b=hjTzW/0HyLtq9rY4iFpAG/UYOoLlcQD+wAkjhQ4mN8VWPraahn7XK805vbE00ISFJu F9QJzjBjDBn1yg0qx3VpPmxgh9nOMKeTGauBxUL8GjyV2Fzi+ScJ5a58yqXpSy0I4kO8 9Rl//icotbwrbi+jOVBkCVBlioMTLZVv5Y5XQz/IhS41UzZS+Ht+d0ibQ6wbUNrcgPMx Sfa9RrfMhv+1jkl6qe0HaH7uP1N0uGKiFuEqT5jgNPBxb+TRdGBqhQk+hCzcCR4zI+hZ r/PaTCEztCfO5OwVKyXur6RhIqeq0bNhud7Z+QfPpQ2rDyMj75AaPGWXrjZNEBXUj8ja 2Unw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=IeZTVOqGP+wB3f/JyvLbqeOCKiqyYCdHj7nmvBSCwtA=; b=IOCMHf25xG+LJsJpZEZDcsaYgtLP1J19rbH3+bjLec7Mn0ISR+J324cQBl95O6IGQb 95+45dU6jhqFydGd9bf5tgDHLHhZiRU/wdMj78zwxGrXhiEOI1bsvP5v8wuF2g4kRVdG 4B/fRzwAxopudKSRE3mMqX0UcJ1xC6LhjrlI0UEzY0aKYi+9GurVu0yuZqWVkdZD6ZXE WlnuNGiK03VzCcutbGnGhNZwza4kmGQJhbnXHa+5hYKsWcux7rzjxXkwOyvJNeMp+iVz 6T/PiYRUeugeso6a/ErZI7qi1NvNTsmRaRI0pTxMbji8htEohbQRDv8Kp+AE7sXBC9YA NMWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e20si604378pgn.181.2019.08.14.15.17.44; Wed, 14 Aug 2019 15:18:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728591AbfHNVhq (ORCPT + 99 others); Wed, 14 Aug 2019 17:37:46 -0400 Received: from correo.us.es ([193.147.175.20]:46810 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbfHNVhq (ORCPT ); Wed, 14 Aug 2019 17:37:46 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 43801C4145 for ; Wed, 14 Aug 2019 23:37:43 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 36B6ADA704 for ; Wed, 14 Aug 2019 23:37:43 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 1FAF264497; Wed, 14 Aug 2019 23:37:43 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 06DF4DA704; Wed, 14 Aug 2019 23:37:41 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 14 Aug 2019 23:37:41 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id CE5724265A2F; Wed, 14 Aug 2019 23:37:40 +0200 (CEST) Date: Wed, 14 Aug 2019 23:37:41 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Nathan Chancellor Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, kbuild test robot Subject: Re: [PATCH] netfilter: nft_bitwise: Adjust parentheses to fix memcmp size argument Message-ID: <20190814213741.ptoel7373xqwzlj5@salvia> References: <20190814165809.46421-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814165809.46421-1-natechancellor@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 14, 2019 at 09:58:09AM -0700, Nathan Chancellor wrote: > clang warns: > > net/netfilter/nft_bitwise.c:138:50: error: size argument in 'memcmp' > call is a comparison [-Werror,-Wmemsize-comparison] > if (memcmp(&priv->xor, &zero, sizeof(priv->xor) || > ~~~~~~~~~~~~~~~~~~^~ Applied, thanks.