Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1370745ybl; Wed, 14 Aug 2019 15:55:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqw2ftlkX1J6QNiMIbCokKm6NbJNO71kJenGLpLUVsrPshMfGxdMaPfqU00YRREOnges6jXe X-Received: by 2002:a63:f401:: with SMTP id g1mr1265149pgi.314.1565823325290; Wed, 14 Aug 2019 15:55:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565823325; cv=none; d=google.com; s=arc-20160816; b=mlYq+jaVUaYvfOoD1V7o1Q7zOMDp7WKfX9MBQ5GR7MBWFAaiBFt6JjG0ykU6HaMIy0 y4yte1cfoEmghrNq6Y207HYYI8qMAIUKF84ikvcFf/ZT5vCoGpmSM19e5nhKRdYTvNQz e39vXvu0gD44AU3wUr1thl8bgNBofYCS3fURNqcbzrADk6EzmKnMlmyI82285nydDQIA yLbC5BtAuuC23XMn6PEhbuK4vCPrnLMJS3LNGNnzkgHK1uMW7FdI4cX40hnKf/nrRdEM dhNemLxcb19/0r7HTVl4vRzcRfNLsme/qVXpqaFfyRSNQRQHjglIqJv+VUig5SymaHlO w+kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=aXoPBB0TLWAOszIsVH99fvtlydnA8QyNOenktPQp5t0=; b=aOLPQ1nLC38oZ0voxeM3Gs/4JBIVeCZlEU+LIn7jh1FbJd9DEfbHANPJjiuRFYFjYf BcfciH05JjArzULEJMWtfsg1QZ4wPDeWOVtB5cyRKUMn7gSp/EmTTEgPG2tF08qmwP1w RNPSpypid1fUwluT+oLftFioY7M7pqgbvMTtdD3r81JkD2gG6H3A98eHvqsSDc1VtBFE EwFDxEESBYCT3XbYen9xOg7oVFXhmAtIrSnkqfJmmra0YCBgtbOrMPcHxVe09oy8HCyS 6+CUPpIqtgmIfiaLUbqon8JCG4a5tzmcIy8RyWGMg/iDbrYhithT1J0ULOOllUqF0l4Z ooPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9si710619plb.317.2019.08.14.15.54.52; Wed, 14 Aug 2019 15:55:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728715AbfHNVKH (ORCPT + 99 others); Wed, 14 Aug 2019 17:10:07 -0400 Received: from emh01.mail.saunalahti.fi ([62.142.5.107]:51686 "EHLO emh01.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728395AbfHNVKH (ORCPT ); Wed, 14 Aug 2019 17:10:07 -0400 Received: from darkstar.musicnaut.iki.fi (85-76-96-82-nat.elisa-mobile.fi [85.76.96.82]) by emh01.mail.saunalahti.fi (Postfix) with ESMTP id A8FA6200B2; Thu, 15 Aug 2019 00:10:02 +0300 (EEST) Date: Thu, 15 Aug 2019 00:10:02 +0300 From: Aaro Koskinen To: Arnd Bergmann Cc: Tony Lindgren , Paul Walmsley , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Linus Walleij , Bartlomiej Zolnierkiewicz , Tomi Valkeinen , linux-kernel@vger.kernel.org Subject: Re: [PATCH 21/22] ARM: omap1: use common clk framework Message-ID: <20190814211002.GA1952@darkstar.musicnaut.iki.fi> References: <20190808212234.2213262-1-arnd@arndb.de> <20190808214347.2865294-1-arnd@arndb.de> <20190808214347.2865294-2-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190808214347.2865294-2-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Aug 08, 2019 at 11:43:39PM +0200, Arnd Bergmann wrote: > The omap1 clock driver now uses types and calling conventions > that are compatible with the common clk core. > > Turn on CONFIG_COMMON_CLK and remove all the code that is > now duplicated. > > Note: if this previous steps didn't already break it, this one > most likely will, because the interfaces are very likely to > have different semantics. QEMU SX1 board works up to this patch (the I/O virtual address change included). With this patch, it seems to fail to allocate memory during omap1_init_early() (the log is a bit messy as I extracted it using QEMU memory dumping): swapper: page allocation failure: order:0, mode:0x0(), nodemask=(null) CPU: 0 PID: 0 Comm: swapper Not tainted 5.3.0-rc4-sx1-los_80efa++ #1 Hardware name: OMAP310 based Siemens SX1 [] (unwind_backtrace) from [] (show_stack+0x10/0x18) [] (show_stack) from [] (dump_stack+0x18/0x24) [] (dump_stack) from [] (warn_alloc+0x90/0x140) [] (warn_alloc) from [] (__alloc_pages_nodemask+0x7a4/0x9cc) [] (__alloc_pages_nodemask) from [] (slob_new_pages.constpro p.2+0x10/0x3c) [] (slob_new_pages.constprop.2) from [] (slob_alloc.constprop.1+0xe4/0x1e8) [] (slob_alloc.constprop.1) from [] (__kmalloc+0x38/0xb0) [] (__kmalloc) from [] (__clk_register+0x20/0x62c) [] (__clk_register) from [] (omap1_clk_init+0x88/0x220) [] (omap1_clk_init) from [] (omap1_init_early+0x20/0x30) [] (omap1_init_early) from [] (start_kernel+0x48/0x408) [] (start_kernel) from [<00000000>] (0x0) Clocks: ARM_SYSST: 0x003a DPLL_CTL: 0x2002 ARM_CKCTL: 0x3000 Clocking rate (xtal/DPLL1/MPU): 12.0/12.0/0.0 MHz "8<--- cut here --- "Unable to handle kernel NULL pointer dereference at virtual address 00000018 "pgd = (ptrval) "[00000018] *pgd=00000000 Internal error: Oops: 5 [#1] ARM CPU: 0 PID: 0 Comm: swapper Not tainted 5.3.0-rc4-sx1-los_80efa++ #1 Hardware name: OMAP310 based Siemens SX1 PC is at clk_hw_get_parent+0x4/0x14 LR is at omap1_clk_enable+0xc/0xcc OMAP310 based Siemens SX1 [ 0.000000] free:0 free_pcp:0 free_cma:0 pc : [] lr : [] psr: 600001d3 sp : c03aff88 ip : 00000000 fp : 00000000 r10: 00000001 r9 : 54029252 r8 : 10000100 r7 : c03b1000 r6 : 00002002 r5 : 0000003a r4 : c03b5444 r3 : 00000000 r2 : c03b9818 r1 : ff03ce08 r0 : c03b5444 Flags: nZCv IRQs off FIQs off Mode SVC_32 ISA ARM Segment user Control: 0000317f Table: 10004000 DAC: 00000055 Process swapper (pid: 0, stack limit = 0x(ptrval)) Stack: (0xc03aff88 to 0xc03b0000) ff80: c03b5438 0000003a 00002002 c01f6734 00000000 00000057 ffa0: 0000313d c01f5820 00000000 c01f09e8 00000000 00000000 00000000 00000000 ffc0: 00000000 00000000 00000000 c0201a38 00000000 c01f0330 00000057 0000313d ffe0: 00000265 10000100 54029252 0000317f 00000000 00000000 00000000 00000000 [] (clk_hw_get_parent) from [] (omap1_clk_enable+0xc/0xcc) [] (omap1_clk_enable) from [] (omap1_clk_init+0x1a8/0x220) [] (omap1_clk_init) from [] (omap1_init_early+0x20/0x30) [] (omap1_init_early) from [] (start_kernel+0x48/0x408) [] (start_kernel) from [<00000000>] (0x0) A.