Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Biwen Li <biwen.li@nxp.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
CC:     "a.zummo@towertech.it" <a.zummo@towertech.it>,
        Leo Li <leoyang.li@nxp.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: rtc: pcf85363/pcf85263: fix error that failed to run
 hwclock -w
Thread-Topic: [EXT] Re: rtc: pcf85363/pcf85263: fix error that failed to run
 hwclock -w
Thread-Index: AQHVUoSfyAMvxeFinU6CH649Ec3dZ6b6a68AgAEvbGA=
Date:   Thu, 15 Aug 2019 04:20:42 +0000
Message-ID: <DB7PR04MB4490882B1235995B82AA67CB8FAC0@DB7PR04MB4490.eurprd04.prod.outlook.com>
References: <20190814093249.40065-1-biwen.li@nxp.com>
 <20190814100930.GI3600@piout.net>
In-Reply-To: <20190814100930.GI3600@piout.net>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 667dddcf-d96b-4006-8ac0-08d72137efe7
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2019 04:20:42.7071
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vRSbzjzeCLg5ekTZawI5CdmQ6CeHAhzgX36M8C85mbbDIs4dk2xVQKpJAxtV6j5+iSplIgFppba3qAuJL3C6tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4665
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Caution: EXT Email
>=20
> Hi,
>=20
> On 14/08/2019 17:32:49+0800, Biwen Li wrote:
> > Issue:
> >     # hwclock -w
> >     hwclock: RTC_SET_TIME: Invalid argument
> >
> > The patch fixes error when run command hwclock -w with rtc
> > pcf85363/pcf85263
> >
>=20
> Could you describe a bit more the issue and what causes it?
1. Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch will alwa=
ys check for unwritable registers, it will compare reg with max_register in=
 regmap_writeable.

2. In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS is 0,=
 max_regiter is 0x2f, then reg will be equal to 0x30, '0x30 < 0x2f' is fals=
e,so regmap_writeable will return false.
>=20
> IIRC I wrote that code and it works on my pcf85363.
>=20
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > ---
> >  drivers/rtc/rtc-pcf85363.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c
> > index a075e77617dc..3450d615974d 100644
> > --- a/drivers/rtc/rtc-pcf85363.c
> > +++ b/drivers/rtc/rtc-pcf85363.c
> > @@ -166,7 +166,12 @@ static int pcf85363_rtc_set_time(struct device *de=
v,
> struct rtc_time *tm)
> >       buf[DT_YEARS] =3D bin2bcd(tm->tm_year % 100);
> >
> >       ret =3D regmap_bulk_write(pcf85363->regmap, CTRL_STOP_EN,
> > -                             tmp, sizeof(tmp));
> > +                             tmp, 2);
> > +     if (ret)
> > +             return ret;
> > +
> > +     ret =3D regmap_bulk_write(pcf85363->regmap, DT_100THS,
> > +                             buf, sizeof(tmp) - 2);
> >       if (ret)
> >               return ret;
> >
> > --
> > 2.17.1
> >
>=20
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbootl=
in.
> com&amp;data=3D02%7C01%7Cbiwen.li%40nxp.com%7C8ef8fda7d05a48ef707
> 308d7209f8029%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 7013741730886353&amp;sdata=3DePC651YZUzvL5ocjXAZqKT0tIZpJM01LgRNSa
> 7i7wLE%3D&amp;reserved=3D0