Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1634363ybl; Wed, 14 Aug 2019 21:39:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzyBdh0h6LVtso4h/9fnymM1kJAMvT/1/yovmjfqNMw6loklc95HbiLQt6FYa3ycYOVLt/m X-Received: by 2002:a63:5807:: with SMTP id m7mr2060353pgb.371.1565843991915; Wed, 14 Aug 2019 21:39:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565843991; cv=none; d=google.com; s=arc-20160816; b=ZPO49i3Ij2TgSq5TxlKg+g8COr1zTv4+RC+Fc+8qje/oVkOdScGyz8KjS5R7FMMm0S 5LKePKkeZSelAEuQz43wOP6J0JyldOseyQDXF5YI0z042xY0nwt57Go/xV0sfg03RVzQ +j0pD+RdfgxWIWgU00XtnlPijbImzzbTMOPXQac2qI42mzm/PGtqBj4qpv9ivEHgIT/z otT/PCwYkkRO48EYQboTY7RnJZ/VwHb4lHEyMsFcqG66jWZ7QnWyjA620oHkZ/lB2Ybk cCcKwVS4aA3lZRj8MDG08MWS50pq1SpZDOsviLjKKmYKQ0AXBbHPq5X7WVqfbG0ka1Tb YOBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:subject:cc:to:from; bh=Qxerm/dRUeQ92/itGshJdarR8Bt+UJXWRH8r7F8k8NU=; b=H8IgBzJLgLaSdQg/LxhzVyaNnknz8LFIt2XpPs0eU2RI2e30vizCyAt9V3qx0OD3QX uGJ3Ig2IQdHvGSOABOG+htcrXXD45S2/krefN7zCgCMMZaeYXc2e1YjTYRHBtwmZ+jc/ MYc4VSNSsTeQbnkgAwdd370IeiRRhUUF6qzLD+A0rEykbd0dVaw0OTMhhkLvrydng2gn PFiTwcE8L8JrDDRv8xyegOnxsTpjoXTBjNWhjKpIEK4peql3jqQUFzfKVeyK0KWreHc4 aazYgF226vWCjatFZHdIv4zSrwo6ixtHZltkKSgIBHEWkExnV95ZxC5ETvmfG90+lOW0 Q+PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b18si1213558plz.389.2019.08.14.21.39.24; Wed, 14 Aug 2019 21:39:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726139AbfHOEMX (ORCPT + 99 others); Thu, 15 Aug 2019 00:12:23 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:7328 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfHOEMX (ORCPT ); Thu, 15 Aug 2019 00:12:23 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7F4CLeh057620 for ; Thu, 15 Aug 2019 00:12:22 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ucy4fhrhh-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 15 Aug 2019 00:12:22 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 15 Aug 2019 05:12:16 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 15 Aug 2019 05:12:11 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7F4Bo6O21168456 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Aug 2019 04:11:50 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 326D04C04A; Thu, 15 Aug 2019 04:12:10 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D3EA24C044; Thu, 15 Aug 2019 04:12:09 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 15 Aug 2019 04:12:09 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id A7A8CA01BD; Thu, 15 Aug 2019 14:12:08 +1000 (AEST) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: stable@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Christophe Leroy , Thomas Gleixner , Qian Cai , Nicholas Piggin , Allison Randal , Greg Kroah-Hartman , Andrew Morton , David Hildenbrand , Mike Rapoport , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] powerpc: Allow flush_icache_range to work across ranges >4GB Date: Thu, 15 Aug 2019 14:10:46 +1000 X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190815041057.13627-1-alastair@au1.ibm.com> References: <20190815041057.13627-1-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19081504-0016-0000-0000-0000029EEC85 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19081504-0017-0000-0000-000032FF0922 Message-Id: <20190815041057.13627-2-alastair@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-15_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=700 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908150045 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alastair D'Silva When calling flush_icache_range with a size >4GB, we were masking off the upper 32 bits, so we would incorrectly flush a range smaller than intended. This patch replaces the 32 bit shifts with 64 bit ones, so that the full size is accounted for. Signed-off-by: Alastair D'Silva Cc: stable@vger.kernel.org --- arch/powerpc/kernel/misc_64.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/misc_64.S b/arch/powerpc/kernel/misc_64.S index b55a7b4cb543..9bc0aa9aeb65 100644 --- a/arch/powerpc/kernel/misc_64.S +++ b/arch/powerpc/kernel/misc_64.S @@ -82,7 +82,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE) subf r8,r6,r4 /* compute length */ add r8,r8,r5 /* ensure we get enough */ lwz r9,DCACHEL1LOGBLOCKSIZE(r10) /* Get log-2 of cache block size */ - srw. r8,r8,r9 /* compute line count */ + srd. r8,r8,r9 /* compute line count */ beqlr /* nothing to do? */ mtctr r8 1: dcbst 0,r6 @@ -98,7 +98,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE) subf r8,r6,r4 /* compute length */ add r8,r8,r5 lwz r9,ICACHEL1LOGBLOCKSIZE(r10) /* Get log-2 of Icache block size */ - srw. r8,r8,r9 /* compute line count */ + srd. r8,r8,r9 /* compute line count */ beqlr /* nothing to do? */ mtctr r8 2: icbi 0,r6 -- 2.21.0