Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: M8VARG8XJ26irO/lf3IBB/YadK1nmM/Z9UXsiFCvxF7gOjZLKx8alOBHEkoWO1cBzCiUcDzc4D
 V4bGYe18N2D4RAQPvPWskOORjzvthBCeVQrAiDcszQIW7w32HwnFazkUkRwt1mOl+skCETnNv1
 2dVsY3xESlxmkCae1pHoxFoaM3gTKd+QrszAdp0pZKOuMTP1kiSsvfdiiwQpq2oZ4sGcnhWd0O
 j0DHU6vN6LYxNmYvXVbEeKwmQQ/eJZB+uOIiRJ8NTHXozvPVFsRTHe/QJhzm+1RYrU3FjQNOWu
 2Dc=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Max Gurtovoy <maxg@mellanox.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
CC:     Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Stephen Bates <sbates@raithlin.com>
Subject: Re: [PATCH v7 04/14] nvmet: make nvmet_copy_ns_identifier()
 non-static
Thread-Topic: [PATCH v7 04/14] nvmet: make nvmet_copy_ns_identifier()
 non-static
Thread-Index: AQHVSMM4pgNQfVl62kW+URoU596DzA==
Date:   Thu, 15 Aug 2019 07:15:04 +0000
Message-ID: <BYAPR04MB5749D194F4AD68F5A8CF0D5E86AC0@BYAPR04MB5749.namprd04.prod.outlook.com>
References: <20190801234514.7941-1-logang@deltatee.com>
 <20190801234514.7941-5-logang@deltatee.com>
 <43951ad9-873b-5bbe-b627-0ad4610fbb11@mellanox.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 51c98259-0cc6-49d4-088f-08d721504b6e
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2019 07:15:04.0838
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Qx6YQQH+tenS4yDfC4NGeCoDuobMNldYnG2oh0j3w0L0XeWY2qYV1e0HUwigvuuXJZbsTR5froCT0hjGCckZs4XE1sR/yf3VLGxY1mPWfso=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4407
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/14/19 7:30 AM, Max Gurtovoy wrote:=0A=
> =0A=
> On 8/2/2019 2:45 AM, Logan Gunthorpe wrote:=0A=
>> This function will be needed by the upcoming passthru code.=0A=
> =0A=
> Same here. As a standalone commit I can't take a lot from here.=0A=
> =0A=
> Maybe should be squashed ?=0A=
=0A=
This commit changes the existing code which is independent of the=0A=
passthru code which we are adding. For that reason I've made this=0A=
standalone as it doesn't have direct modification from w.r.t passthru =0A=
code.=0A=
=0A=
Perhaps more documentation will make this clear.=0A=
=0A=
> =0A=
> =0A=
>>=0A=
>> [chaitanya.kulkarni@wdc.com: this was factored out of a patch=0A=
>>    originally authored by Chaitanya]=0A=
>> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
>> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>=0A=
>> ---=0A=
>>    drivers/nvme/target/admin-cmd.c | 4 ++--=0A=
>>    drivers/nvme/target/nvmet.h     | 2 ++=0A=
>>    2 files changed, 4 insertions(+), 2 deletions(-)=0A=
>>=0A=
>> diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin=
-cmd.c=0A=
>> index 4dc12ea52f23..eeb24f606d00 100644=0A=
>> --- a/drivers/nvme/target/admin-cmd.c=0A=
>> +++ b/drivers/nvme/target/admin-cmd.c=0A=
>> @@ -506,8 +506,8 @@ static void nvmet_execute_identify_nslist(struct nvm=
et_req *req)=0A=
>>    	nvmet_req_complete(req, status);=0A=
>>    }=0A=
>>    =0A=
>> -static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 =
len,=0A=
>> -				    void *id, off_t *off)=0A=
>> +u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,=0A=
>> +			     void *id, off_t *off)=0A=
>>    {=0A=
>>    	struct nvme_ns_id_desc desc =3D {=0A=
>>    		.nidt =3D type,=0A=
>> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h=
=0A=
>> index 217a787952e8..d1a0a3190a24 100644=0A=
>> --- a/drivers/nvme/target/nvmet.h=0A=
>> +++ b/drivers/nvme/target/nvmet.h=0A=
>> @@ -489,6 +489,8 @@ u16 nvmet_bdev_flush(struct nvmet_req *req);=0A=
>>    u16 nvmet_file_flush(struct nvmet_req *req);=0A=
>>    void nvmet_ns_changed(struct nvmet_subsys *subsys, u32 nsid);=0A=
>>    =0A=
>> +u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,=0A=
>> +			     void *id, off_t *off);=0A=
>>    static inline u32 nvmet_rw_len(struct nvmet_req *req)=0A=
>>    {=0A=
>>    	return ((u32)le16_to_cpu(req->cmd->rw.length) + 1) <<=0A=
> =0A=
=0A=