Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Date:   Thu, 15 Aug 2019 16:50:33 +0900
To:     Petr Mladek <pmladek@suse.com>
Cc:     Chuhong Yuan <hslester96@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/8] printk: Replace strncmp with str_has_prefix
Message-ID: <20190815075033.GA26479@tigerII.localdomain>
References: <20190809071034.17279-1-hslester96@gmail.com>
 <20190814104941.qt66ozcau5fdswcs@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190814104941.qt66ozcau5fdswcs@pathway.suse.cz>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On (08/14/19 12:49), Petr Mladek wrote:
> On Fri 2019-08-09 15:10:34, Chuhong Yuan wrote:
> > strncmp(str, const, len) is error-prone because len
> > is easy to have typo.
> > The example is the hard-coded len has counting error
> > or sizeof(const) forgets - 1.
> > So we prefer using newly introduced str_has_prefix()
> > to substitute such strncmp to make code better.
> > 
> > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>

Reviewed-by:  Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss