Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2019494ybl; Thu, 15 Aug 2019 05:16:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDlG0mRDIj7pi28zcPii8SEehjo+UieOkR/T24s8fq4/qk6IT4/6J/lFlTRiJvAheLMDA4 X-Received: by 2002:a17:902:141:: with SMTP id 59mr4149543plb.324.1565871401644; Thu, 15 Aug 2019 05:16:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565871401; cv=none; d=google.com; s=arc-20160816; b=cMDAP4KXwq2m7yE4EWcdhAhFAO5taNsF2M2tHLe4h3RaPLvMA0CgGYcYuPMgZxbGYk 4QHARHGDvZNDJaik6dzJut40VRbjfBVVRgQG7GDfrXcXlqhBMGGxdTe7mUH3wJXA0qHU hnZ7pv2obY5954wGSVEA8hNs/fcf0K2/8X+gg9Hb7P5PuTwir/0ErcnOHSBiDcIybn+d LI2CQP1lSHT/gdtSf/uXne0sSxT5tBWyWKvTYNPTSU2Lq+2UZZLU3OxIV/PkTI4Pzoue ++RLvLwgRaaWLowxY2lHOEDdb2kgpc8s+w3L0/lSOmDc3Zb5+j0EGeGEotXIuX3wvD6K Uy/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6PKsRmbVygfFu0BIrqkGuyU3FP4RgPUSJyj1/o/5NZ8=; b=w7LIQkpK/6dhA9WyWO8DtKTFywLNPkm9XZeuxJ72SymyH8jPuau2XmlAh06gH9zMXX ZWG6GKA0BvjT48IPdqlyZ4XR3s+ANkqHlopwBJLeH/4Gh1KlcvqvL0vR04D/Tpsyavhg ngPHAgqAethR5txSmHwwx3PfFAWzDcOcOrW0+2kc+jdZb7HcUN/T7aEG2I+BjiMS43D6 p56u0TzosvW5zWch8XgQYm3BuS07Bprt1jwMiPJLiBhqtCJQnETUe5Fikbbp2D5z5Beg 3ShuzBA1htLsuRHGm5xR/WmOMGxF1kglJttLMhfov6DRbQxzmS3GMQeLYs78L0fEp5wO gkew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o7si1717327pgv.247.2019.08.15.05.16.25; Thu, 15 Aug 2019 05:16:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730950AbfHOL6x (ORCPT + 99 others); Thu, 15 Aug 2019 07:58:53 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42070 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbfHOL6x (ORCPT ); Thu, 15 Aug 2019 07:58:53 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hyEP0-0007rQ-Rv; Thu, 15 Aug 2019 11:58:46 +0000 From: Colin King To: Lars-Peter Clausen , Michael Hennerich , Stefan Popa , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: dac: ad5380: fix incorrect assignment to val Date: Thu, 15 Aug 2019 12:58:46 +0100 Message-Id: <20190815115846.21800-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Currently the pointer val is being incorrectly incremented instead of the value pointed to by val. Fix this by adding in the missing * indirection operator. Addresses-Coverity: ("Unused value") Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver") Signed-off-by: Colin Ian King --- drivers/iio/dac/ad5380.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c index 4335214800d2..2ebe08326048 100644 --- a/drivers/iio/dac/ad5380.c +++ b/drivers/iio/dac/ad5380.c @@ -220,7 +220,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev, if (ret) return ret; *val >>= chan->scan_type.shift; - val -= (1 << chan->scan_type.realbits) / 2; + *val -= (1 << chan->scan_type.realbits) / 2; return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: *val = 2 * st->vref; -- 2.20.1