Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2056338ybl; Thu, 15 Aug 2019 05:58:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqxv6GYpWESC8euaap41ohZw+OnNm75cNipOmKoIzdeOAWH5qTRssVsgWBuRAFld6sUkcFO5 X-Received: by 2002:a17:902:a01:: with SMTP id 1mr4290870plo.278.1565873884705; Thu, 15 Aug 2019 05:58:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565873884; cv=none; d=google.com; s=arc-20160816; b=vPUh+K9Hh65TI3+u7M7QKEa1kFCKhaA7U21nsyj0bAdykI5Lw64+a45D91qRzR/070 h4zzEb1qnCJeFwpchpGjACT7mb4tbzmgYyum/DIMTfbTjImYQziMhQeFUaon6QKTbPEy o59iv6hDkMrqz1ucidXvD4Bav1Zn3ysfSmVjkyvpcg8JthAxxW4J3Nnpk0Fyk/X0zaQ6 H9iF2R/KaXn/a9LVIOx8JvwviAi9PHNpJaA4YYu36NzplGct/vPaiy79ivAaonUjjy7V ldr/Ur/tWKaF4LuqYzoZhuZSGv4vgZvxYhJMFDUp8XFr1JoxuchY/bJ8zABdeGJ5F8P1 gImw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=xRBcqmzYSlHntWrDNVMM9t5UNCDPrSjl8ZM/obtWCaQ=; b=XlxeXUNBuCzrQ8ri7GUzvJNy2fwNXnRyFzPdlkEwIHC8b2YvAeuffW6td+svBFHf7u GbGnZlYxXa+jlTtaoJvM8jS+lT37sOMvzyPK7YyWDC9Ivjf4kdUvq4mrp7VbiOGvSGfU muDIZiJXogmg0B1YZ957KVV3HVcY82XnE9AhJtBYov+ppdZmZOJBDP+lxOC0DuJqlQl1 ApF+vJcZLKDU+TxWJEWJwi2Jx/D18jQMwo9h6w3dM2Zw4jKgVfmIew7OVUoiYCmCP0CO ZP7lr47sT2R/ApbjwpufBpwItdbRjQg/xZfysOPn/aOxHXmHFtm+cRHq2+igCnIaOv1n DIiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h38si1896263plb.149.2019.08.15.05.57.46; Thu, 15 Aug 2019 05:58:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731454AbfHOMw4 (ORCPT + 99 others); Thu, 15 Aug 2019 08:52:56 -0400 Received: from sauhun.de ([88.99.104.3]:32984 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729627AbfHOMw4 (ORCPT ); Thu, 15 Aug 2019 08:52:56 -0400 Received: from localhost (p54B33431.dip0.t-ipconnect.de [84.179.52.49]) by pokefinder.org (Postfix) with ESMTPSA id 48BCF2C2704; Thu, 15 Aug 2019 14:52:53 +0200 (CEST) Date: Thu, 15 Aug 2019 14:52:52 +0200 From: Wolfram Sang To: Max Staudt Cc: linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org, Wolfram Sang , Jean Delvare , Guenter Roeck , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, glaubitz@physik.fu-berlin.de Subject: Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Message-ID: <20190815125252.GC1916@kunai> References: <20190812235237.21797-1-max@enpas.org> <20190814194714.GB9756@kunai> <20190815071228.GA1054@kunai> <276714fb-6b3a-1e99-0744-bfd037305724@enpas.org> <20190815114809.GA1916@kunai> <54185c85-8c26-916e-41b1-af9b55223e7b@enpas.org> <20190815120430.GB1916@kunai> <4661d2f3-13e1-ff62-22e1-e4391ccc38b2@enpas.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lCAWRPmW1mITcIfM" Content-Disposition: inline In-Reply-To: <4661d2f3-13e1-ff62-22e1-e4391ccc38b2@enpas.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lCAWRPmW1mITcIfM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > The callback, just like getclock(), is from the existing i2c-algo-pcf, > which I don't want to touch right now. So I'm afraid it has to stay, > even if it returns a fixed number. Sure. I was just thinking loud and did not expect you to do it. Maybe I will do it once your driver is upstream. > Touching or forking i2c-algo-pcf will be necessary in order to > implement IRQ support, if I ever get around to it. I've wasted too > much time on debugging IRQ support, and would rather do it another > time, if ever ;) I've left a comment block at the start of i2c-icy.c > for anyone interested in the gory details. Yeah, I read it. I like such documentation. Really helpful! > If this is okay with you, I'll send another round of patches. :) Perfect! --lCAWRPmW1mITcIfM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl1VVaAACgkQFA3kzBSg KbbhYxAApqbkKmM/SfvqaGNqdQxFvjTFrV3E08Ct31M28y210CPVO5YMz4tkj+hq OEi7NDuA7+XTlgNAeuJJb3UQYOlkEUwR8x/6oZMWj4Nh379Bmk3TmlkMqHRwIwJ3 OqItq+oIN3MAcICCf4D/66/WUFoZIzZAprXASzbtdfGQma4Wue3lXxGPvhndYqzR HpO4yhOTRs87PJrHUavD07BV1+bk+VIKBG/NkehpG1BmiIsd+5XrzQtbuMNVaKBN mnpL6uwRROG6nz8NamnHUu+KPKquwakTTW1Nx7KeZs6Th7ySAyCOlhFcbx7x0AbK h8oSwpmrSukBc1pKc+ZDvoqZNppE0ixVBF3AdgZP5Msgrm15xfa0EEXM7/s8o/EE iasali4Zj1S34JX0MFBYXmeRUTxWOVtT/2dDVhNYrPzt5GpXsuG32NyQo+PkTAv6 LwvbOQ1JVU49rqsyYinniA6zGZeSNeJw7z2TRKb7zR9FGZUa+NSmNQs8IciSsnrv H9VOPDviPuTEGQjLdOMzNDPPQ5ZizPkQvRNiYwNCGqgXAFSU++RDwksEsAnUsRVz VPnmIjxE4IC73MzyM/76ILtRBVyvu/+AjGoygjifpNP36a5bhOXysRxwbLZGt1ww +AGF+JAJznrW6JUIRgoaUo+vaxFwW8oFjJff/zezVXOX2+o4UoY= =0mSM -----END PGP SIGNATURE----- --lCAWRPmW1mITcIfM--