Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2092276ybl; Thu, 15 Aug 2019 06:27:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqyiil4RlIlLSRCfWD31qI6L8ERVKyNhG1L9PQxj4a8KbKQCn0zQx8Tb/UoWVlxIs6yD54bs X-Received: by 2002:a17:90a:9a95:: with SMTP id e21mr2193922pjp.98.1565875671405; Thu, 15 Aug 2019 06:27:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565875671; cv=none; d=google.com; s=arc-20160816; b=lZR6m4kLbnjxhMFlIM/1twKT8kDwhNmV4kX8fJ9uuTkgoM2/QOEKkRtYh4uvCepwwM YTMlB5t3ZDEEe58MPBEd3bfYQVLHpY426gYhrLh6UtUNOtT+tx7zS6sxTKaX9vxm1krX FUyeSCR8xfDJpsYNWsPLbE/rXQf4PkWhgsHFcdreD3Bv/kbYEqEwPeZjHYgtgQn1rb7D UpXDF8Fn7Inua4Oja2gbjzpwiGE8oYhKnwdyltxy+vPlLl8IWzj6QpXsdCpNYMPe4Uvd 8axMFkQtJwCY5P3lL9TUKj3eeBP5HivcXiFaqQrW6oI4qQrIn5feERid5C1O8obLb/Ze TrIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Ra/ehep8ImbdWjlNFa9FVALq5WLTR7ufeU82X6j1MBs=; b=RrIpkaaC2l8ET+WcdJ6SBCQghiE0i2Bb8T5vj8x6dsSPWZ6jC5fZsF+DAF6ySS6v3q ClfMIgkavNfduZTDQBPCwgUvJQIxsEBebDgofkqXX4MB6+PqHWopw9cy0e9NRJJoWEF7 CTXVjFJ3VC5BAm8/Lr8vJnlRGRSc6kYsJUldH4eU/F/dQeC+8zgHH7jsSnVe/7gNa9/q ZJAF4TJsigP+kFfr9367A7rveZgKL2Vr9aNHwSldQc/X0SQPc7h6EEvZ5GqI4cSmUlpt gwUsxCPsXjwEWHY/gQmz0n6sqrweBcYvSXa5YKf0+NZBZiGX7L+2Lqz/2JAIm9+gFEZy 4lyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z124si2022144pfb.208.2019.08.15.06.27.35; Thu, 15 Aug 2019 06:27:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732294AbfHON0Z (ORCPT + 99 others); Thu, 15 Aug 2019 09:26:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:45032 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731846AbfHON0Z (ORCPT ); Thu, 15 Aug 2019 09:26:25 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C4A59AE12; Thu, 15 Aug 2019 13:26:22 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 1C66F1E4200; Thu, 15 Aug 2019 15:26:22 +0200 (CEST) Date: Thu, 15 Aug 2019 15:26:22 +0200 From: Jan Kara To: John Hubbard Cc: Ira Weiny , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Jan Kara , Jason Gunthorpe , =?iso-8859-1?B?Suly9G1l?= Glisse , LKML , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [RFC PATCH 2/2] mm/gup: introduce vaddr_pin_pages_remote() Message-ID: <20190815132622.GG14313@quack2.suse.cz> References: <20190812015044.26176-1-jhubbard@nvidia.com> <20190812015044.26176-3-jhubbard@nvidia.com> <20190812234950.GA6455@iweiny-DESK2.sc.intel.com> <38d2ff2f-4a69-e8bd-8f7c-41f1dbd80fae@nvidia.com> <20190813210857.GB12695@iweiny-DESK2.sc.intel.com> <90e5cd11-fb34-6913-351b-a5cc6e24d85d@nvidia.com> <20190814234959.GA463@iweiny-DESK2.sc.intel.com> <2cbdf599-2226-99ae-b4d5-8909a0a1eadf@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 14-08-19 20:01:07, John Hubbard wrote: > On 8/14/19 5:02 PM, John Hubbard wrote: > > On 8/14/19 4:50 PM, Ira Weiny wrote: > > > On Tue, Aug 13, 2019 at 05:56:31PM -0700, John Hubbard wrote: > > > > On 8/13/19 5:51 PM, John Hubbard wrote: > > > > > On 8/13/19 2:08 PM, Ira Weiny wrote: > > > > > > On Mon, Aug 12, 2019 at 05:07:32PM -0700, John Hubbard wrote: > > > > > > > On 8/12/19 4:49 PM, Ira Weiny wrote: > > > > > > > > On Sun, Aug 11, 2019 at 06:50:44PM -0700, john.hubbard@gmail.com wrote: > > > > > > > > > From: John Hubbard > > > > > > > ... > > > > > > Finally, I struggle with converting everyone to a new call.? It is more > > > > > > overhead to use vaddr_pin in the call above because now the GUP code is going > > > > > > to associate a file pin object with that file when in ODP we don't need that > > > > > > because the pages can move around. > > > > > > > > > > What if the pages in ODP are file-backed? > > > > > > > > > > > > > oops, strike that, you're right: in that case, even the file system case is covered. > > > > Don't mind me. :) > > > > > > Ok so are we agreed we will drop the patch to the ODP code?? I'm going to keep > > > the FOLL_PIN flag and addition in the vaddr_pin_pages. > > > > > > > Yes. I hope I'm not overlooking anything, but it all seems to make sense to > > let ODP just rely on the MMU notifiers. > > > > Hold on, I *was* forgetting something: this was a two part thing, and > you're conflating the two points, but they need to remain separate and > distinct. There were: > > 1. FOLL_PIN is necessary because the caller is clearly in the use case that > requires it--however briefly they might be there. As Jan described it, > > "Anything that gets page reference and then touches page data (e.g. > direct IO) needs the new kind of tracking so that filesystem knows > someone is messing with the page data." [1] So when the GUP user uses MMU notifiers to stop writing to pages whenever they are writeprotected with page_mkclean(), they don't really need page pin - their access is then fully equivalent to any other mmap userspace access and filesystem knows how to deal with those. I forgot out this case when I wrote the above sentence. So to sum up there are three cases: 1) DIO case - GUP references to pages serving as DIO buffers are needed for relatively short time, no special synchronization with page_mkclean() or munmap() => needs FOLL_PIN 2) RDMA case - GUP references to pages serving as DMA buffers needed for a long time, no special synchronization with page_mkclean() or munmap() => needs FOLL_PIN | FOLL_LONGTERM This case has also a special case when the pages are actually DAX. Then the caller additionally needs file lease and additional file_pin structure is used for tracking this usage. 3) ODP case - GUP references to pages serving as DMA buffers, MMU notifiers used to synchronize with page_mkclean() and munmap() => normal page references are fine. Honza -- Jan Kara SUSE Labs, CR