Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2120496ybl; Thu, 15 Aug 2019 06:54:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHls59ts2UhYn3SAToAMHXxklHMTft0jtkkHFi72M9itSyYL5KjDjce3+5ZOsOdeNMj0ke X-Received: by 2002:a17:902:7c12:: with SMTP id x18mr4464670pll.123.1565877297198; Thu, 15 Aug 2019 06:54:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565877297; cv=none; d=google.com; s=arc-20160816; b=QLuG6xIisLSHTUyvUqAsfILLAHU+ST3c6OR/brPB6L7prcKCaaoM23IO3DoLf2jdfY eXJvK1MJngf5wKHLKVkY5BQlZ9m21xEVGa/y3oCUraGf5ZjDhoBa6FRg+kOnIi5xfZkM nqNfJYcxOZc2irRkkPsJ/3Td11GAVeM66kA7FKU/q+iwuHTs2uQsUNTluBjWSmUDA83I td8jw+LOcUwM137CT8ucG1lFMvyRZnnCULJ1w6Db8cr1Q9aIyPDwsLrjKgyMu0BquSJR xjhkXEsUaROWD4vYTowyB5S62mTtubcYGMuiar+gEN6nWscQGPr1J/1DrqO5sWe+0JHH vW8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ythiNgSkT2F1jKWc98fvR1vT4VlJXx7yCHnLBRzroqI=; b=WKqJqjXvh1Sv4TWwD8rWPPzMx8l+YZaa2zPJJJZUw4ZXS1CHej0fusrlXvrANWir9m 2b8CeHgiIe0FJa8e9hsDzlZgN/LenWwyqywRJR1UMS8YEAL8epx9lTjbyRx2l6+djAfd 5rT0y9/SGA/C6tuC9Z7hVgGSH8rrqm4+bWuOKHYtqRs3Z950wUgVlo7YYQStlVjN0QfG Jh8LJrltHChJUeGFmJdguORvIUxWjT0N4kUt00f2qlmzraU/Q+gMhY4jTmW+QduM/eiQ m310rsRvyAIHONfKg8IWWJ+Ap5X5lMAsu+70yC/KD9Uv0PXQQMQZqADXpE/Fqvwmnyz1 1Y0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h27si1876863pgh.388.2019.08.15.06.54.41; Thu, 15 Aug 2019 06:54:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732610AbfHONwq (ORCPT + 99 others); Thu, 15 Aug 2019 09:52:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:57502 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732481AbfHONwp (ORCPT ); Thu, 15 Aug 2019 09:52:45 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BDE16AF8A; Thu, 15 Aug 2019 13:52:44 +0000 (UTC) Date: Thu, 15 Aug 2019 15:52:21 +0200 From: Petr Mladek To: Chuhong Yuan Cc: Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/8] printk: Replace strncmp with str_has_prefix Message-ID: <20190815135221.qcgerido7aahmpgn@pathway.suse.cz> References: <20190809071034.17279-1-hslester96@gmail.com> <20190814104941.qt66ozcau5fdswcs@pathway.suse.cz> <20190815075033.GA26479@tigerII.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190815075033.GA26479@tigerII.localdomain> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2019-08-15 16:50:33, Sergey Senozhatsky wrote: > On (08/14/19 12:49), Petr Mladek wrote: > > On Fri 2019-08-09 15:10:34, Chuhong Yuan wrote: > > > strncmp(str, const, len) is error-prone because len > > > is easy to have typo. > > > The example is the hard-coded len has counting error > > > or sizeof(const) forgets - 1. > > > So we prefer using newly introduced str_has_prefix() > > > to substitute such strncmp to make code better. > > > > > > Signed-off-by: Chuhong Yuan > > > > Reviewed-by: Petr Mladek > > Reviewed-by: Sergey Senozhatsky Chuong Yuan, should I take this patch via printk.git? Or will the entire series go via some other tree, please? Best Regards, Petr