Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2250732ybl; Thu, 15 Aug 2019 08:50:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxKldxwlsk1O8qfF+/BfRUdMeAdINpzqrZEVc7ccqNyxHLDsER7dnBt7E1Hfqrjh6lCAx9a X-Received: by 2002:aa7:8007:: with SMTP id j7mr6080553pfi.154.1565884220858; Thu, 15 Aug 2019 08:50:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565884220; cv=none; d=google.com; s=arc-20160816; b=XhwQSA6Y9O+U30o8CUBfsV20o/CRShQ+hWc32wioCvjObJa0KKK8L50HBkJ51/m46T 6gqOBZnhwB3FKcMjEIRvYG5WasiRoVF/mkNvmbvQ8BdMuqQA+wOMge2WbAztbYg1zDq2 FjisGteY4TggfQ2UlzxvxmARk7d65inr43IIkpuxL1B1Fr6ESPughuUvbQtitJ312qbP TRaji7QHPJyBjrNttiv19MPcOJE4uvhjIEPAZGuf80k9u6NrbYNMMatOuOm1lQeQ9NG9 D4ddkLE8Ummlv40dqJ5B9rTA/dZOT7hJq6fsgs3C69qyLZCz34n2SzVhH6YcjPvZz397 868A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:user-agent:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=emtmpN8koXyGRnpKRd+goYJhZ3VVizKGLhWaG2eElpw=; b=K8GjphPP2dSQfugiz09R2pTiX2w/GWVuK4E3W+bxQ3zDMuqardcSkibgAXflAq9r+f 5Bf04Cxd88zDL7AB5yvt6wIrc2Aigt6xCkkB4bTXyJXTRFMied3cAVWCGgzEc1hhyip6 1WorT2CU1NctIzvwzgXGxtNIBWL7cv9GNolauUpH5p5bkzoi/qZhJKkOF5PGuBV7ezBx gS0sHa5an7jqmOqh1hOi3SVSFqSWlqwI3KRF+ayYKaN+GesKIAa1qdiMgRNObEa7TLeJ OVpZ41wEiRoQRNBprjNbqc7k5zOVj+Sr2FSZBmL7gI/Z6BicslZhqZdaVLy9KbzJqyB5 wwng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CgTdZg7C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t16si2368717pfq.88.2019.08.15.08.50.06; Thu, 15 Aug 2019 08:50:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CgTdZg7C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728329AbfHOPSs (ORCPT + 99 others); Thu, 15 Aug 2019 11:18:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:56688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbfHOPSr (ORCPT ); Thu, 15 Aug 2019 11:18:47 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA999206C1; Thu, 15 Aug 2019 15:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565882327; bh=emtmpN8koXyGRnpKRd+goYJhZ3VVizKGLhWaG2eElpw=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CgTdZg7C4TKnbBcwJyBIKQohYSn3rP7ceSj4iWdoGWybsqCHWcLT6u2zkbpHNS+mY ni5KaAhohoeBCsJtfd6ldxVNfg9im9mNK9+B88A95VgPPp4NupMoQ4oVVL5gef2+Kl eV/3sQ1uQdH+8uoIYqY05sSrG8Hn7BAY9r5DYpqo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190815080146.4tkudfzus7uryoe6@flea> References: <20190815041037.3470-1-sboyd@kernel.org> <20190815080146.4tkudfzus7uryoe6@flea> Subject: Re: [PATCH] clk: sunxi: Don't call clk_hw_get_name() on a hw that isn't registered From: Stephen Boyd Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Chen-Yu Tsai To: Maxime Ripard User-Agent: alot/0.8.1 Date: Thu, 15 Aug 2019 08:18:46 -0700 Message-Id: <20190815151846.DA999206C1@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Maxime Ripard (2019-08-15 01:01:46) > On Wed, Aug 14, 2019 at 09:10:37PM -0700, Stephen Boyd wrote: > > The implementation of clk_hw_get_name() relies on the clk_core > > associated with the clk_hw pointer existing. If of_clk_hw_register() > > fails, there isn't a clk_core created yet, so calling clk_hw_get_name() > > here fails. Extract the name first so we can print it later. > > > > Fixes: 1d80c14248d6 ("clk: sunxi-ng: Add common infrastructure") > > Cc: Maxime Ripard > > Cc: Chen-Yu Tsai > > Signed-off-by: Stephen Boyd >=20 > Acked-by: Maxime Ripard >=20 > Do you want to apply it yourself, or should I merge this and send you > a PR later? >=20 I can apply it myself. Thanks! Now to figure out the real problem...