Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2254324ybl; Thu, 15 Aug 2019 08:54:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZcWAu56D4JUHw4Lf0lS6KueCDoFKCKkTpFhUoXA3TDMOSNXD2fiXyrsB7xX0YvuiLAzIs X-Received: by 2002:a17:90a:240e:: with SMTP id h14mr2993104pje.9.1565884454517; Thu, 15 Aug 2019 08:54:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565884454; cv=none; d=google.com; s=arc-20160816; b=fgJy3a+daKCTCyFuWe+21S8lGuVJUMz68U6ZMuVFqfFqWXSoyNka0z8ZTGgNp/Vvo8 pbvSSsp19wU9kvl0s+LMdN0IMZRi19sY4LbOGwgd2l8IBDq9XWw/0/r9mctczFcIHgS+ ZGhsTZWiFGajsGUvBJFdbBUZ6mLhN49Ji1u7ntwTPSFnXUBPETht5ZUT3t7aXv9ex5cP PlV5uxSZPOCtigFv5gH7xYI8VI1854rAHjckdcApeEibQNEHoJ3Z6whc/aGCVGuj124D 95d0mubW8cX7duAJHquBsNpeB+ddCKLZAKb8Q2uT/ReS/0V9tlMp64E7cHmnsEI553vu GZpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=AkYthp7LCueG9x2IINcBzpO2jlClSAIZLBrJ2UUQFGE=; b=T1KZnUPT0XbsVu/QIYkCctyNFjvjA4JdFLklf8ryk67X5l19CZSPwDMPG1SViaUpSt RlE5qkLIpQDmW3uhAS/0dYXCJFNWV7ICx7nDNMedreY/ZFqWRJKN11I3OpbtWPjmTAu3 mMkRC8GiNShicfMX7vDDkT4Yyxaucmqtf4z7hrD6klZ/s5IfWMvdsOXtZnCy0ZzP+eP1 d6S1qpGEIbscsDenjnurCjNVwG0Lqo4zg1cdwbcq9bYcX+x8jNRiFR/8u3y4RHOEHL0W WaWMXHd7MJ88NzgxZ678KAOUywbEzLomiT8n+L/ZhT1RPQFQyp0bCL+7v2He84U4IzLu tJUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ft2ZIUgZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p9si1193457pjp.4.2019.08.15.08.53.58; Thu, 15 Aug 2019 08:54:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ft2ZIUgZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729427AbfHOPZw (ORCPT + 99 others); Thu, 15 Aug 2019 11:25:52 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:44664 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729151AbfHOPZv (ORCPT ); Thu, 15 Aug 2019 11:25:51 -0400 Received: by mail-pl1-f196.google.com with SMTP id t14so1175800plr.11; Thu, 15 Aug 2019 08:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AkYthp7LCueG9x2IINcBzpO2jlClSAIZLBrJ2UUQFGE=; b=Ft2ZIUgZ5Tm+zKB8GUWHYDJlgKa9TJgKcw7PqXTlwXzTWYw1tAluAzGxaWLoa3B6nE sY5iL51DIF2tSJ7ldSn9rAvZ/2/FR6G6wV5hhrgLxQMyBiQdGGy4u3AKEyLlMLjSmMJB z9dMsq8xify2qHYL8bbQWWGqqa37K1n+Ve/paDyLaMsRIpgBDeWPXntdc8Sf8zVUqJhi OLnlkRQcFTFFF8jin7n2cjjbNz0gQ6ig8u+dF4evbd0KK/xM3u84SuvTebV34P49CBXq AEY6K3ijY0Q+cr3PLmu+YAcHg1V5SHy//sx5cWTeVz5n8RqL1VhQdpctfNV4V6k16I2m IHHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AkYthp7LCueG9x2IINcBzpO2jlClSAIZLBrJ2UUQFGE=; b=NAkqMc2EqrAi7hxtpLKdGrvTY59RV6ydkv1lEolYpi87yvgRGy9RLVI3UT5DCVTR19 B4wOjkd3TFbE4P6PPqGtyUHUUeiTojstjSCXQUOf7voU08WXu34kZro+lyhVrRIYuNRz galgucO5sMSlSTrrDAgTa4u4fE02G0Po9FpRU8YYaCi5qu7/5KhJ98VzVjpEMiQUe0Es gstmxyjZBz3V7n5xmX7sOa03eAt/7CBiMY+P62s+3KgGUVDAh6L+evDf34ouipvFHOj2 kZW/bz0JwxRCuk3rfUvhxRhY+RA4a10CSw19lTCBqeQMwEXVaf+npzb8OAD7XgbEYBhI db3Q== X-Gm-Message-State: APjAAAVlRDAGgUj1sjB+iiLy0OiGVIKbVwwIWhg4e+oJrgWXuVo4Hzln fFZnhtUC0Lgc0z/BERVh/rU= X-Received: by 2002:a17:902:2ac7:: with SMTP id j65mr4888600plb.242.1565882751110; Thu, 15 Aug 2019 08:25:51 -0700 (PDT) Received: from localhost.localdomain ([125.142.23.13]) by smtp.gmail.com with ESMTPSA id h70sm2588166pgc.36.2019.08.15.08.25.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2019 08:25:50 -0700 (PDT) Date: Fri, 16 Aug 2019 00:25:44 +0900 From: Suwan Kim To: shuah , Greg KH , Christoph Hellwig Cc: valentina.manea.m@gmail.com, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/2] usbip: Implement SG support Message-ID: <20190815152544.GA4533@localhost.localdomain> References: <20190808155435.10050-1-suwan.kim027@gmail.com> <20190814131951.GA1437@infradead.org> <20190815132356.GB27208@kroah.com> <0cf92881-53c7-09d4-18ac-593034a1a56c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0cf92881-53c7-09d4-18ac-593034a1a56c@kernel.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 08:10:49AM -0600, shuah wrote: > On 8/15/19 7:23 AM, Greg KH wrote: > > On Wed, Aug 14, 2019 at 06:19:51AM -0700, Christoph Hellwig wrote: > > > FYI, I think my > > > > > > "usb: add a HCD_DMA flag instead of guestimating DMA capabilities" > > > > > > is the proper core fix for what your patch 1 works around, as the USB > > > core should not assume DMA capabilities based on the presence of a DMA > > > mask. > > > > I agree. Let's wait for Christoph's series to be applied before taking > > this one. > > > > Great. Thanks you both looking at these. Makes sense. Ok. Then I will drop the patch 1 and leave vhci flags without including the HCD_DMA flag to skip dma mapping. BTW, in my patch 2, I set URB_DMA_MAP_SG flag in vhci_map_urb_for_dma() of patch 1 to tell the server to use SG. I will fix it by setting URB_DMA_MAP_SG flag in other place and resend v6. Is it ok? Regards Suwan Kim