Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2306563ybl; Thu, 15 Aug 2019 09:41:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqwA2YPdPSA3+VGoZzI/d3j4WKE+HJ9VRSAAM/Bd8yS/2sTXRJLVe3lCpNn63AA7vzTChWeg X-Received: by 2002:a63:29c7:: with SMTP id p190mr4129443pgp.124.1565887306802; Thu, 15 Aug 2019 09:41:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565887306; cv=none; d=google.com; s=arc-20160816; b=TbxIriZYIoPpfvPPvLTJU7JwM7pZHTDjac+/MIakhpvr6SOfL1hxrT9/iv0L3N4EeS 14vo/MlixI7H8U7bft9HnCBV8pJq9/SSa3yOjZNm6UnMY4WYxxcF+FmuO1rdz3pii6HG l4YCnplLkVdnflxXQscqS8qd72Op6zn4Bn5qH/qfxYQSAnHsq5g6nkEBOEV7Ef5XNcNT KFsYApscWezNTkWAcslArXK7DWZY2FwkeSgjnnmjBdsVzoi2DRjQdhA5uKgfHjk3X88t LrkpiQqfEpQnDktg69/4IHOmJNK4mJG7E0vVtP11RZ5dQBPdeleeASdvU31oVTfBUJs2 igVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=6grQ9ocx+IbTwjVEIDedYoYdf4O0M4fR1quq8TS70BA=; b=GxgOHVqlUfXq0p6CJ31gDneffM+WZoQ0hZlikTMGF/wZ1ROzlEtiRVuuoiyjMV7CC9 Tb3sLqz2AFL2gr4aS6IPgR7gO004vxo6ahPNZaDnROu6gwFJ0NiK/2luYx2yQ4pUjZ40 5Lvm8gSNMS6W8oMq7vAVjgb6RyHTtR6jvUmujvMYFBiZbFP5JmKIcSQrSi8NcuTQdsLj DP8DNsxEOqeYuiaLN3I+HdyvxwICObEDz+9TbUksXDPcmCgy9mrJ4mztWOLXOxcu0cuN 7oxuZ5RyP/n1bnp0mv9WOAK6n2C6maiO/Yqm6SzwmjeP4EbeRkynjcr1kXcGfklgNbUO b1Vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=FG8b5drl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j192si2089417pge.393.2019.08.15.09.41.30; Thu, 15 Aug 2019 09:41:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=FG8b5drl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731701AbfHOQZz (ORCPT + 99 others); Thu, 15 Aug 2019 12:25:55 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:33824 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731591AbfHOQZx (ORCPT ); Thu, 15 Aug 2019 12:25:53 -0400 Received: by mail-io1-f65.google.com with SMTP id s21so293017ioa.1 for ; Thu, 15 Aug 2019 09:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6grQ9ocx+IbTwjVEIDedYoYdf4O0M4fR1quq8TS70BA=; b=FG8b5drlg1DYNIfZgQ6q7wA0xgFXi0ISvlwrU2ezrkleGRnPhC6qzdm3SG0FXSCCVr 4/+1jBiqIA/aBL/u4qxHoe5NMGu0WLlajJzgMMexeGB9cwiSUIbxX3AD8h9wn7HWJqyy nPWcuORgsACRu+FkFGvFc+Xq0N50z0kcVMdR0HIF/1ABEe2wupgfPrjwsy/1OddU/DCf zGf0IW7nYz9h5AupmY/Kmz5IVJRNmQI5/hil5Rxq0MDbDjzwUixSUDBB8SC6tVLnFnoy WKvTJnuBlqoZmkhsbbW6jTzaG8lq2oyNSIlWVAJ1F3s12sbmXRTLWmpeY4SfwWJfvhtR 4/+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6grQ9ocx+IbTwjVEIDedYoYdf4O0M4fR1quq8TS70BA=; b=X24Yfz86T2Puh41Y4N85FCgWHLLTh9qWFOYYUucxfBaWiYqLzFTobFfD7JBv8bB2q8 D4WZOaVQlfCaOIWNjyzN54SbyCsmvPZn9XSPaoJxBjDHZxdydthJtqFYK4gSE7dFvQXh nATsEkfTfiHv1svt3TBZRz4mCQ6wmxZUrI32bNm7wGEPWhTYbYfIvGooB4R2ULe6dGO6 IwjKh3dos3XYdBzRQX5YvaFc4L6HRGK85Bw2hKvYqKR3lGUWfQOp5r4wu5Npc9ZdMWl3 v4WkV93HMp8CWt1pMUQyT2Y+jICa5vwxlyuXm37n3+8xxUwCzmtEBr17M1bZZaqaT5aI f4dA== X-Gm-Message-State: APjAAAX5QZzgg/ZgChtRaok97ctwDTygqeH+7Apuv4BPUsg9sOQ4gY3o zKOkd6cLnjRFRVawB7ue5oTqNrh0e0px3s+OYxJzaw== X-Received: by 2002:a05:6638:52:: with SMTP id a18mr5943400jap.75.1565886352617; Thu, 15 Aug 2019 09:25:52 -0700 (PDT) MIME-Version: 1.0 References: <20190814070403.6588-1-weijiang.yang@intel.com> <20190814070403.6588-6-weijiang.yang@intel.com> <87a7cbapdw.fsf@vitty.brq.redhat.com> <20190815134329.GA11449@local-michael-cet-test> In-Reply-To: <20190815134329.GA11449@local-michael-cet-test> From: Jim Mattson Date: Thu, 15 Aug 2019 09:25:41 -0700 Message-ID: Subject: Re: [PATCH RESEND v4 5/9] KVM: VMX: Add init/set/get functions for SPP To: Yang Weijiang Cc: Vitaly Kuznetsov , kvm list , LKML , "Michael S. Tsirkin" , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , yu.c.zhang@intel.com, alazar@bitdefender.com, Paolo Bonzini , Sean Christopherson Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 6:41 AM Yang Weijiang wrote: > Hi, Vitaly, > After looked into the issue and others, I feel to make SPP co-existing > with nested VM is not good, the major reason is, L1 pages protected by > SPP are transparent to L1 VM, if it launches L2 VM, probably the > pages would be allocated to L2 VM, and that will bother to L1 and L2. > Given the feature is new and I don't see nested VM can benefit > from it right now, I would like to make SPP and nested feature mutually > exclusive, i.e., detecting if the other part is active before activate one > feature,what do you think of it? > thanks! How do you propose making the features mutually exclusive?