Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2342310ybl; Thu, 15 Aug 2019 10:15:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCB0v64U2MVFdEHZo05qtaDv0hTXGWNa3/GxpB87NDnZUMMwMpRxKnQBUwjUgqY8DsVQCb X-Received: by 2002:a65:6152:: with SMTP id o18mr4143619pgv.279.1565889303325; Thu, 15 Aug 2019 10:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565889303; cv=none; d=google.com; s=arc-20160816; b=SIjHVEqoZISoaIZiIOS9pEweuJr2bAZlx9MkGUEGGmwMIYkBZUy9TafQT230TzBKBK Ni6lOg5l/opXn/MnajfVyCP8dHzdjWTzvHXJXR5IX5MPfFB3b/6BF9nhHNKnWd9+ji8u utwD7w0QsW1Usn97iCqnt9vCoTQGWx90SGyb+o4Sqseaqe8geSpxcpVJSev/WkQ7EJeC gOgoHACZ40NbrKwkTTXZmyjngy9bNjpVNXVk9UUKnIjZgXcHUJHDlHKD9hKFDUsIIKYF DH/OK2kAVYoohywbJVrytcAl6rI5CTOu94juQLcz18VSeRGh25sgLIpi/wx4vvkNNxcj sfQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=z90nPpYO8UuUUSb9IN8rKS3L0KsgC8zXmObZdfo6ctQ=; b=yj7jEexlLhF6P6sZOMk2u6eF0lMyz1NL8rOH7552N1V+fRMwJUlKjlgO/VTxURzcmS 3wqUfXEGoZIh73rjzgo3i1JvcWaFx9pjFsNDbLW124XHCXFGb9c4/a/cgRjx/9joj7b9 4BIdRJ+DaKKqKXIe4CHn4gLGXj1gJBiEF/axutP2eCD/vfkQhZh+rjETpeXEz4TMU8mx 9LgyvJnAWl4uuB5i5PHlabUW/cyV2SZDEY+/rA1CIMkuVwOMJqtHNPBVQyJY0R1uDVfH kM89ilp7xB1gioBJ7v/ixrad7svIIWu9ke/NdyGR1VQ2QnfL9zXBjHNHIhnsnGznHNo8 FKiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=dU2EhV+6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e13si2152386pgs.275.2019.08.15.10.14.48; Thu, 15 Aug 2019 10:15:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=dU2EhV+6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731581AbfHOOvE (ORCPT + 99 others); Thu, 15 Aug 2019 10:51:04 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:39757 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731269AbfHOOvE (ORCPT ); Thu, 15 Aug 2019 10:51:04 -0400 Received: by mail-qk1-f195.google.com with SMTP id 125so2017849qkl.6 for ; Thu, 15 Aug 2019 07:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z90nPpYO8UuUUSb9IN8rKS3L0KsgC8zXmObZdfo6ctQ=; b=dU2EhV+6EWSs1MNrZJWfU76DaiGX5NQgWL4uohTv/GZxgH6FeggKTIKZ+d/6xxWmB5 Uq7EirJG422MX6svb2pK3O0rmVD5upXZhrC0obDyAVUsClwMUccie10LZ+VusUXs6G5t Cfxm7G3duJErwOwTzL6wlTMWxPvhXqi0t55/HXZYJ0ksP5CllSxCeRSJEwA3qeLb3Mw+ H9tQF6/hs2KVjejIpKYI3tuEWzOasQMSO5OrPdyS6Tf6gZNSrPhr0d7BWVqY895GeZU7 3vhMlzFvKziDCq6pld4ycFVFRE1zOEJ/X+8kNMBCMNIgJ/nYLqTQqzhkO3QmO9Oxi/p7 z4xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z90nPpYO8UuUUSb9IN8rKS3L0KsgC8zXmObZdfo6ctQ=; b=MumGr/uMWnLz91B5M6phTelnTAcQ/cB+lcGtNteFLe0lWP7AdF8KzVkNuUHJW98udL nYnogWJfVBDJQL8VFVKu3P9CqFjA3aYVOsTiLfGl+gbnGtb25KpGGkwiFo340qc/dA4h 0k1VizyD268qCTzpQdBzkAJMHXzYB2Tzsdk6NxKK9vrKGJfD3DiUTwH1rl/Oraen2CIm 2rIGRpDikyVVhZ7XIfmkGgJPlwiWGQLpM5MO77ieaw3iLRvNzDb5VsWL4PhAsTEmdzoE atR1DcIp4R+SkCtKjIAPNi0YDN74ELmbBPwlGezjoY3XJldAsaCrgKllQ3Zi1N9CL0a9 +Omw== X-Gm-Message-State: APjAAAUdPrWRZTPj9YtwykQLiXja/uX0VnMw8WgJiWYutZMa8kc3GcRn G8ZzNeffbu2GUh+HTKxYqGas4w== X-Received: by 2002:a05:620a:71a:: with SMTP id 26mr4357407qkc.374.1565880663323; Thu, 15 Aug 2019 07:51:03 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id e15sm805595qtr.51.2019.08.15.07.51.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Aug 2019 07:51:02 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hyH5i-0005L9-BH; Thu, 15 Aug 2019 11:51:02 -0300 Date: Thu, 15 Aug 2019 11:51:02 -0300 From: Jason Gunthorpe To: Jan Kara Cc: John Hubbard , Ira Weiny , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , =?utf-8?B?SsOpcsO0bWU=?= Glisse , LKML , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [RFC PATCH 2/2] mm/gup: introduce vaddr_pin_pages_remote() Message-ID: <20190815145102.GH21596@ziepe.ca> References: <20190812234950.GA6455@iweiny-DESK2.sc.intel.com> <38d2ff2f-4a69-e8bd-8f7c-41f1dbd80fae@nvidia.com> <20190813210857.GB12695@iweiny-DESK2.sc.intel.com> <90e5cd11-fb34-6913-351b-a5cc6e24d85d@nvidia.com> <20190814234959.GA463@iweiny-DESK2.sc.intel.com> <2cbdf599-2226-99ae-b4d5-8909a0a1eadf@nvidia.com> <20190815132622.GG14313@quack2.suse.cz> <20190815133510.GA21302@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190815133510.GA21302@quack2.suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 03:35:10PM +0200, Jan Kara wrote: > > 3) ODP case - GUP references to pages serving as DMA buffers, MMU notifiers > > used to synchronize with page_mkclean() and munmap() => normal page > > references are fine. > > I want to add that I'd like to convert users in cases 1) and 2) from using > GUP to using differently named function. Users in case 3) can stay as they > are for now although ultimately I'd like to denote such use cases in a > special way as well... 3) users also want a special function and path, right now it is called hmm_range_fault() but perhaps it would be good to harmonize it more with the GUP infrastructure? I'm not quite sure what the best plan for that is yet. Jason