Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leo Li <leoyang.li@nxp.com>
To:     Biwen Li <biwen.li@nxp.com>,
        "a.zummo@towertech.it" <a.zummo@towertech.it>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
CC:     "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w
Thread-Topic: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w
Thread-Index: AQHVUoSffVMVL9pU8EWFzlDe9z+sGab6+TgAgAChtoCAAOVX4A==
Date:   Thu, 15 Aug 2019 18:01:22 +0000
Message-ID: <VE1PR04MB66873BEBB6EBCC1C04D0AC238FAC0@VE1PR04MB6687.eurprd04.prod.outlook.com>
References: <20190814093249.40065-1-biwen.li@nxp.com>
 <VE1PR04MB66875AF7A38BF43351970EB08FAD0@VE1PR04MB6687.eurprd04.prod.outlook.com>
 <DB7PR04MB449054F05411CBDC935605F28FAC0@DB7PR04MB4490.eurprd04.prod.outlook.com>
In-Reply-To: <DB7PR04MB449054F05411CBDC935605F28FAC0@DB7PR04MB4490.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d4d1ded-c852-481a-4885-08d721aa954d
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2019 18:01:22.8361
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hlYVC5bSg9cJH/MRBsYFovNKh1SAyNRbg0Lr+Y+hAqO/1lQD6VproLbYixZ70ijxb/LB9hGz1QPc5HzmB0FP1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6368
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Biwen Li
> Sent: Wednesday, August 14, 2019 11:15 PM
> To: Leo Li <leoyang.li@nxp.com>; a.zummo@towertech.it;
> alexandre.belloni@bootlin.com
> Cc: linux-rtc@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock=
 -w
>=20
> > > Subject: rtc: pcf85363/pcf85263: fix error that failed to run
> > > hwclock -w
> > >
> > > Issue:
> > >     # hwclock -w
> > >     hwclock: RTC_SET_TIME: Invalid argument
> > >
> > > The patch fixes error when run command hwclock -w with rtc
> > > pcf85363/pcf85263
> >
> > Can you explain a little bit more in the commit message on how the
> changes fix
> > the above issue?   It is not that clear just from the code.
> 1. Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch will al=
ways
> check for unwritable registers, it will compare reg with max_register in
> regmap_writeable.
>=20
> 2. In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS is =
0,
> max_regiter is 0x2f, then reg will be equal to 0x30, '0x30 < 0x2f' is fal=
se,so
> regmap_writeable will return false.

From you description, it looks like the problem is actually that the buf[] =
was written to a wrong place.  If that's the case, we should say that in th=
e commit message.

>=20
> >
> > >
> > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > ---
> > >  drivers/rtc/rtc-pcf85363.c | 7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c
> > > index a075e77617dc..3450d615974d 100644
> > > --- a/drivers/rtc/rtc-pcf85363.c
> > > +++ b/drivers/rtc/rtc-pcf85363.c
> > > @@ -166,7 +166,12 @@ static int pcf85363_rtc_set_time(struct device
> > > *dev, struct rtc_time *tm)
> > >  	buf[DT_YEARS] =3D bin2bcd(tm->tm_year % 100);
> > >
> > >  	ret =3D regmap_bulk_write(pcf85363->regmap, CTRL_STOP_EN,
> > > -				tmp, sizeof(tmp));
> > > +				tmp, 2);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	ret =3D regmap_bulk_write(pcf85363->regmap, DT_100THS,
> > > +				buf, sizeof(tmp) - 2);
> > >  	if (ret)
> > >  		return ret;
> > >
> > > --
> > > 2.17.1