Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp86061ybl; Thu, 15 Aug 2019 13:10:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwt1GZVFMsDcLhxeWnRPd2x4oPltW+mM2eT64PqP0BOO+HWmEy7VDo9dy/X6FoQjeC5j8Ku X-Received: by 2002:aa7:9477:: with SMTP id t23mr7251136pfq.29.1565899833780; Thu, 15 Aug 2019 13:10:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565899833; cv=none; d=google.com; s=arc-20160816; b=YlyB7Wbl0iOuf1TJh3nVOM1evc5+dACJ4xYxXp3vS5jTzEvQ70lQA698YoNzlvSRp9 M4FyFpsRFXMm+k6ccfyFS9VxQWI/rh2WxnhBzFkzfGpB5Rel6sGvY3QdXVxAXWiH1Q2N Pn8hNJI/jYm6JfEqXlJ8NxLmtk+ovH2jRcVmPpXo9UuCB4wCOJ8qFff3Bjlfiicxj4Mp Hb+moPLmvrYIIejhFpqJZdkJSdr4j8N9lRYDlFkWeivK8syxGgvVxsTtleJam1GUy/IR RrhYFBEgw3+opSP3Ob/IcMAlBbiy+F9Ep3if3yOsAzi4cHznLvbxUmRTUPsV0MVaphWl L5vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=JnqJgAj9vR5wFDfTYSfbSchJ2hiJ4lcDOTAFQiwAzKU=; b=KhBVYZPnKeYinDTzEgPdZsbq0VdBDcchrxKBmzmzY+IyKCFGMpVItU0KX2MUfyPCaw fp+JCrTo9RNmoXDqs4kEguBo3pjXOYDXQjCqu7F4YuBEPslOvua2LIBpZgdQzKSihaIZ CU/NxfGwYiVEUEBgdH7BYzYQr5aCVqAyixQSRZ108f4BrdMFzrK6Wlu2y/gWFkNyndJF U5UliCbpFW6WMWQn4KGO69bLHhRAei1YeIBpaaMtpyFuZlKgGNQZTP3FGJ5lhtqJqfmZ Uvf2iJGQvAEbN7iGXx1KIqLnyNz6RUN0BB1ej6WAV63PMJrYL9GZjFPn4CGa0CRq2F3N wCcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j75si2365613pgc.38.2019.08.15.13.10.18; Thu, 15 Aug 2019 13:10:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733010AbfHOSeu (ORCPT + 99 others); Thu, 15 Aug 2019 14:34:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:47884 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729157AbfHOSet (ORCPT ); Thu, 15 Aug 2019 14:34:49 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F32E013E2E21C; Thu, 15 Aug 2019 11:34:48 -0700 (PDT) Date: Thu, 15 Aug 2019 11:34:46 -0700 (PDT) Message-Id: <20190815.113446.175049349135660993.davem@davemloft.net> To: anders.roxell@linaro.org Cc: shuah@kernel.org, netdev@vger.kernel.org, tim.bird@sony.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue From: David Miller In-Reply-To: <20190815075826.13210-1-anders.roxell@linaro.org> References: <20190815075826.13210-1-anders.roxell@linaro.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 15 Aug 2019 11:34:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anders Roxell Date: Thu, 15 Aug 2019 09:58:26 +0200 > When running tcp_fastopen_backup_key.sh the following issue was seen in > a busybox environment. > ./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected > > Shellcheck showed the following issue. > $ shellcheck tools/testing/selftests/net/tcp_fastopen_backup_key.sh > > In tools/testing/selftests/net/tcp_fastopen_backup_key.sh line 33: > if [ $val -ne 0 ]; then > ^-- SC2086: Double quote to prevent globbing and word splitting. > > Rework to do a string comparison instead. > > Signed-off-by: Anders Roxell Applied.