Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp94154ybl; Thu, 15 Aug 2019 13:20:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqwW6Ikst3viTJRwQAUcHlSyQDSf9yFD9YVsdi9EovAp9j11lvC+2/FEIE2FerFaL1zvTGjr X-Received: by 2002:a17:902:1a4:: with SMTP id b33mr5714278plb.141.1565900411400; Thu, 15 Aug 2019 13:20:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565900411; cv=none; d=google.com; s=arc-20160816; b=RnJxvCwJTc2wAWsSquIYqckpGzShGaXd9vxw8J4oGqj6Kzv1OeU1Y2KqzAJTtrkm9V Orco4Z4axP2dMFgKyjtIsyUXYvRTqXNWo5wU2CVV9Qi9uB1Ix8VqF8xzvEZD9yZ9wgv7 lsT3WBisD/oYNQ55+mSWsOGcxU8lvAogIWdflkf8PtMTNrVplDPUflB4UbGanfcSi3gL qGRfMB3YZl02M/PBYWr5zFfsO+CGBVdZpp5QgDqW48qZZ30n8pYE+ygtkaVATkXJITxV v7MUqpEyD6W5iGO1QNAs+/abokJhnBh5Kcsm4Xf4ZA6mUcwj1DXq6AkCrJChZJNHf7Oi /9rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Fx7xG/HMDzvKMrqjbgNDNFd/i4Ap20+tXNpe1pKkgf0=; b=rsbdZ+drEZGfPH8jDjcWgmKtDB+f9BqZkHiLnc2rklXMeyeJLj3LxqBZ0XqzDde4XQ S8SfedR25Ob86OyLNtcuaz4D4Qx+F/bgx/YR9cCoavFakqnHE1nbvUSikO5F5PfpnoWq civExan47jlVuivlvIwaEQxWG34cKND5cB/n8cfebXvn+qa/MLOWge92LNkEqDP0iMnw POphieX0KvejYyYugGSJ3K4sYbDYrMQ+qHqpasNRS3YPsYpWKYAuZcZn10LRb2EWDksS HWx+ZVmaYHPXZr4XJmOmB2Pq7po8po0n2PPCkLyHvhIlnAzaCf9stI8CUe9WhSOZvDUq Opjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5si1598862pjf.60.2019.08.15.13.19.53; Thu, 15 Aug 2019 13:20:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732929AbfHOThz (ORCPT + 99 others); Thu, 15 Aug 2019 15:37:55 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49114 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732777AbfHOThy (ORCPT ); Thu, 15 Aug 2019 15:37:54 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C449B1400EC46; Thu, 15 Aug 2019 12:37:53 -0700 (PDT) Date: Thu, 15 Aug 2019 12:37:53 -0700 (PDT) Message-Id: <20190815.123753.513875593712522152.davem@davemloft.net> To: wenwen@cs.uga.edu Cc: dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] liquidio: add cleanup in octeon_setup_iq() From: David Miller In-Reply-To: <1565759689-5941-1-git-send-email-wenwen@cs.uga.edu> References: <1565759689-5941-1-git-send-email-wenwen@cs.uga.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 15 Aug 2019 12:37:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang Date: Wed, 14 Aug 2019 00:14:49 -0500 > If oct->fn_list.enable_io_queues() fails, no cleanup is executed, leading > to memory/resource leaks. To fix this issue, invoke > octeon_delete_instr_queue() before returning from the function. > > Signed-off-by: Wenwen Wang Applied.