Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp123242ybl; Thu, 15 Aug 2019 13:57:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9FLZyWd5BxrJ/20jzXRjTL33U/EstJqVoxLa8Zg8Zcl930AW74w0J1cFwRh2FssSHeUJJ X-Received: by 2002:a62:e910:: with SMTP id j16mr7499809pfh.123.1565902673307; Thu, 15 Aug 2019 13:57:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565902673; cv=none; d=google.com; s=arc-20160816; b=Io0W2hsTOa2onomzqwC8H2hRBUnoB4LgKcvMiWFRnYaSZdi35XkTQO/Hov5mA6Uj8x w1VGTLpYDRnL4Xgg38zLioRr58ijSGldwqXvqO2YajypbOD6JKifz0tKvZ6/o/aMciNg RriRwMrJW4zTswggx489ZqllseGDiq3iOwp9bSVqg7ks6AMrmArmys+R0x2JWapYvm6U 7Pp0X/fhlXi96k5tBB8Ba/FUu6IaTqq0NQ5zhRhtY1Hejurg5BLmWy9COyV2nYkuAL6P Sz13QzJRa6yjfpS642Z0YvpkZcW5sr9lhuUkDZpY8f7jFqHnw+/S4G/yWrYbSlfCYhlL eoug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=HGEa3xCLR8cAaY0YzXg9Ny83Awkssh51XOCKiuLXnpY=; b=F5rrCmKDFGSAcN7fiMDfvbCsEym3GrqufwCF4rsctnK686yBbDnbmDLRhZPcLvKjta 6HP+KqCEBCVwjn+SW0gb1xM0xtvvgtfri6Sgvi6KscMQFPGmDRoWBDwIngOHOyPFxkUs ST+cvnmIH1yUld73nyVbM7i+WTTzv1KgzZfAjwTsgtef9mdEK6v7qILThBudm6txvlbO FHUv4id3RqU6T+5etxJAToawY1kga2A6cyPT4Ky/G1+PjUuWsR7fKyNlAJI8o5/A7lsQ uq1ZC5OpYpNtsUNSGIUbtVA3gF4YrrlzDPYewtwU4fjttpWw8zCYZIkciRM7yhKzFbkn 9TQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h15si2596759plr.87.2019.08.15.13.57.36; Thu, 15 Aug 2019 13:57:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730876AbfHOUO4 (ORCPT + 99 others); Thu, 15 Aug 2019 16:14:56 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:40777 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbfHOUO4 (ORCPT ); Thu, 15 Aug 2019 16:14:56 -0400 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hyM92-0005Rc-Vs; Thu, 15 Aug 2019 22:14:49 +0200 Date: Thu, 15 Aug 2019 22:14:48 +0200 (CEST) From: Thomas Gleixner To: Borislav Petkov cc: "Lendacky, Thomas" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "x86@kernel.org" , Ingo Molnar , "Rafael J . Wysocki" , Pavel Machek , Chen Yu , Jonathan Corbet Subject: Re: [PATCH] x86/CPU/AMD: Clear RDRAND CPUID bit on AMD family 15h/16h In-Reply-To: <20190815153447.GH15313@zn.tnic> Message-ID: References: <776cb5c2d33e7fd0d2893904724c0e52b394f24a.1565817448.git.thomas.lendacky@amd.com> <20190815071940.GB15313@zn.tnic> <768aa720-1db1-81ca-4d0d-adf31f4d134b@amd.com> <20190815153447.GH15313@zn.tnic> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Aug 2019, Borislav Petkov wrote: > On Thu, Aug 15, 2019 at 01:47:24PM +0000, Lendacky, Thomas wrote: > > I think this is a clearer indication that the action has taken place. > > Yeah, but what does that bring us? You wanna know this now, while > testing. Once that whole effort is done, it is a useless printing of > info which you have in cpuinfo already. No. Print something useful in dmesg, telling the user that and also why this has been disabled. That avoids stupid questions and if they come up nevertheless we can reduce the answer to LMGT4Y. Thanks, tglx