Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp134389ybl;
        Thu, 15 Aug 2019 14:10:14 -0700 (PDT)
X-Google-Smtp-Source: APXvYqzH4JTS6gKeSaAT8AE6JWNYUNvo7KFDrZOFSluwJ6zEEeDjE87lh8u4gUnXoMdmwZWOk/aT
X-Received: by 2002:a63:2157:: with SMTP id s23mr5110091pgm.167.1565903414490;
        Thu, 15 Aug 2019 14:10:14 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1565903414; cv=none;
        d=google.com; s=arc-20160816;
        b=bmNbg2TbR21j22p7sRsYdJwMvWxu99ChColqjWgS63aaOL+h5mW6tJ2AiHPiHwbKgZ
         UFJuFI0JDhH5pQCIa24cAtJRd1k817Zwd1RNC2vyEqHqCozqEn6za5hW/9IY3YtQ0jAV
         SmDS+6GveUrQuo1tCgVzoGBHr0UoBtTg6EEEXKmLdxCplRIAj+qH2On3mqnNqsZC6+7i
         aAfM3SSrREt3NSZrQNrlyvRyJuJNWXXz6QNVu/RVqvVJCZhez8Tpl1O70PeIwfVMvMFF
         OuNNzqM0QhCxvLOk1ETMKWfgy85EO3jQwt55vXPqlUPauWhrCv18Bw8NYGkQOn5lR3zs
         P+MA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=JNuopfpJLfDjVcolA8yncb4C0j6Blcje3+qSoZfehK0=;
        b=VwPYSmlq0m+n/nC/5D5nJiQiFkvCCmvtaoAL1+03IUif3GoJmfS0ZAFT0Ti3o8z4CC
         h0bmDyDVrQCy4nK30Yu+6S41xj26FpW/zHUD6SD0ZBVvhGkgTCQVX4L/KZhvw3wMHnKD
         bf5d6Xc4cBLoF2nX8N7iT48S7Rm1PFMZuwMLhcFlR2RmwFUGR4Kcczew0AVNxmWgf9ya
         R70/Ple9R5lFItvIHDyAtTsUo9j/rm7Ss5obRvgo0iEJGV6KY+9GI1E30yjgrM0gxnED
         R3FnlAir+DvfTfnwNs+ZHD1puE6Qb8l1QPJKLN9DNWqGR8VoDASNcBL5nmJ+RHdjpPdi
         Q9VA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id n12si2616144plp.341.2019.08.15.14.09.58;
        Thu, 15 Aug 2019 14:10:14 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732331AbfHOU6x (ORCPT <rfc822;vinadhy@gmail.com> + 99 others);
        Thu, 15 Aug 2019 16:58:53 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:50208 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726357AbfHOU6w (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Aug 2019 16:58:52 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 3A4AB1402BC49;
        Thu, 15 Aug 2019 13:58:52 -0700 (PDT)
Date:   Thu, 15 Aug 2019 13:58:51 -0700 (PDT)
Message-Id: <20190815.135851.1942927063321516679.davem@davemloft.net>
To:     hayeswang@realtek.com
Cc:     netdev@vger.kernel.org, nic_swsd@realtek.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152: divide the tx and rx bottom functions
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1394712342-15778-301-Taiwan-albertk@realtek.com>
References: <1394712342-15778-301-Taiwan-albertk@realtek.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 15 Aug 2019 13:58:52 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Hayes Wang <hayeswang@realtek.com>
Date: Wed, 14 Aug 2019 16:30:17 +0800

> Move the tx bottom function from NAPI to a new tasklet. Then, for
> multi-cores, the bottom functions of tx and rx may be run at same
> time with different cores. This is used to improve performance.
> 
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>

Theoretically, yes.

But do you have actual performance numbers showing this to be worth
the change?

Always provide performance numbers with changes that are supposed to
improve performance.