Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp257212ybl; Thu, 15 Aug 2019 16:50:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqwY4zeWOVvWZhcTPc6iFwDEb4IDTLJt/NahlCYL1gfBp+i0F2S1pazUigPjii97ejvPAJOL X-Received: by 2002:a17:902:6507:: with SMTP id b7mr6368463plk.271.1565913014147; Thu, 15 Aug 2019 16:50:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565913014; cv=none; d=google.com; s=arc-20160816; b=jjiSiZFv5WNvruAcMa6EcZmKtTiVeWmMbKskv6akyRoOwPAIgeECZ8hed1xqAst1MQ SQZU4XLQ/e2IjHSaWmb08HPojNcOjSYCwky8oth98SBakMRt4mg/DKqWr9ZpMT+bIXPr iB6vQXSxcHCwRU43STGMXq2RDDFCS9n0VZlpRCL44v+38Qth+u2m1qyf8+GxyBg7FQ3g R2t9KCY0/cXl5S2NUqLx/fco/oz7xZpffoBa30LMQU3/ZsWg8vnsq9KL5pGemsNhdT8G TkjcGLLImiSMV6YebQB57C5Fc6KTemIKOs5ZZesr3qqgdFtRrlrfwQEE5XF87ze9Zt7W Tcrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7Ds0h1FP0bEgRj2xqqDvmLUZg/XyAVILJjOYQC+kx/s=; b=VzIaNZwZdpyGywqSGp8ti1P0cR2HCNme6jKdLCBbWtWL2O2VttP2NlAbiNpJ/Ptb3Y ZQ65hDXy+bDcum2gmdBxvHokUfj7nALF3teG2YuNoYB0z1CAAbKPp6nYdbtCTOkgf6KV J44z894KNc4++N2zL1lu/qwGoKcw6ePqBuKZCUEOh1KVtM+q7Y33X+P+WrIso6n2ge/Y +LCv5uDFBFkJKJRuaU/DHNGSgSqBNpP0CyziOgl6zCkJDF9nH/V/WbS5oCHelXeLDo0R 1m4dBNKmHVRcwytXftP7m75pJaQ+5KzynOYGT6zWxy8VVctTck216jWWkjqBhfUwk4yS zEmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=E9uVc3iP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g17si2770459plo.406.2019.08.15.16.49.58; Thu, 15 Aug 2019 16:50:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=E9uVc3iP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732431AbfHOWba (ORCPT + 99 others); Thu, 15 Aug 2019 18:31:30 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35489 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728861AbfHOWba (ORCPT ); Thu, 15 Aug 2019 18:31:30 -0400 Received: by mail-pg1-f193.google.com with SMTP id n4so1938416pgv.2 for ; Thu, 15 Aug 2019 15:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7Ds0h1FP0bEgRj2xqqDvmLUZg/XyAVILJjOYQC+kx/s=; b=E9uVc3iPa0qz5N5StTnHPAFEPpJeYe7gXMF2B36UCHogMYyWsSbfD0+7W4J/YkG6K8 fdCEcLiWwTaEvD+t4DC6yVIFiOO3rsJDqJiR+PX+3AbENbO1MPCzBtE3SK63sVl/P2JO 9jSmyHGs8JOZArcxdthVT7gUCtpG8VoPbBjig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7Ds0h1FP0bEgRj2xqqDvmLUZg/XyAVILJjOYQC+kx/s=; b=CXNS8mw1UTCfROfC48wfo2yQ6ylXzLDNrC8Mn+SMeUEJvqheCSychYYY8HO6KHo9ck 6afOy3I9wT0LKXTjDrUcPQztksGzhA4e8GL1uvIKxt1n2A9XRtk5apEfgZ62b0608QIu rIFWFPJrtITmdtLVtqjjeFtpKbrXhSFIWIKjam/CVihKCrbhYroPD8jEwSBQ8WiUEhGE OZnyhCp8NCnyBRDW0DysXFGv0BbpkKS8XFSBrK2u9QyNJ50ivSuUo0ay8cpQGHZWYYQ5 Duf/CDAl/GnqHXjePZ3zNdiIuQaMrxJeKKpCHcHZDS/yOn1JltZH9fvvb18tKQzKLbY3 W6kQ== X-Gm-Message-State: APjAAAVNsUzlnxQZNMAr2+SAMSZTOYEl2YLRvDmhRgOb+SPW7xhcoCkm 5Jfc22ASMeOAMdviz4IaO0PIvQ== X-Received: by 2002:a17:90b:911:: with SMTP id bo17mr4047836pjb.40.1565908289602; Thu, 15 Aug 2019 15:31:29 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p20sm3338967pgj.47.2019.08.15.15.31.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Aug 2019 15:31:28 -0700 (PDT) Date: Thu, 15 Aug 2019 15:31:27 -0700 From: Kees Cook To: Joe Perches Cc: hpa@zytor.com, Peter Zijlstra , Pavel Machek , Linus Torvalds , Miguel Ojeda , Borislav Petkov , Thomas Gleixner , Ingo Molnar , "Gustavo A . R . Silva" , Arnaldo Carvalho de Melo , Kan Liang , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Shawn Landden , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use Message-ID: <201908151530.D4B1EF76AA@keescook> References: <1d2830aadbe9d8151728a7df5b88528fc72a0095.1564549413.git.joe@perches.com> <20190731171429.GA24222@amd> <765E740C-4259-4835-A58D-432006628BAC@zytor.com> <20190731184832.GZ31381@hirez.programming.kicks-ass.net> <201907311301.EC1D84F@keescook> <201908151049.809B9AFBA9@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201908151049.809B9AFBA9@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 11:15:53AM -0700, Kees Cook wrote: > I want to recant my position on Coverity coverage being a requirement > here. While I was originally concerned about suddenly adding thousands > more warnings to Coverity scans (if it doesn't support the flag -- > I should know soon), it's been made clear to me we're now at the point For the record, Coverity *does*[1] support the attribute flag. -Kees [1] This should be visible with a Coverity account: https://scan3.coverity.com/reports.htm#v39370/p12360/fileInstanceId=27181923&defectInstanceId=7915635&mergedDefectId=220491 -- Kees Cook